Applied. Thanks!

Alex

On Mon, Feb 14, 2022 at 1:22 PM trix@redhat.com wrote:

From: Tom Rix trix@redhat.com

Clang static analysis reports this problem amdgpu_ctx.c:616:26: warning: Assigned value is garbage or undefined args->out.pstate.flags = stable_pstate; ^ ~~~~~~~~~~~~~ amdgpu_ctx_stable_pstate can fail without setting stable_pstate. So check.

Fixes: 8cda7a4f96e4 ("drm/amdgpu/UAPI: add new CTX OP to get/set stable pstates") Signed-off-by: Tom Rix trix@redhat.com

---

drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c index 1c72f6095f08..f522b52725e4 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c @@ -613,7 +613,8 @@ int amdgpu_ctx_ioctl(struct drm_device *dev, void *data, if (args->in.flags) return -EINVAL; r = amdgpu_ctx_stable_pstate(adev, fpriv, id, false, &stable_pstate);

•           args->out.pstate.flags = stable_pstate;
  

•           if (!r)
  

•                   args->out.pstate.flags = stable_pstate;
            break;
    case AMDGPU_CTX_OP_SET_STABLE_PSTATE:
            if (args->in.flags & ~AMDGPU_CTX_STABLE_PSTATE_FLAGS_MASK)
  

-- 2.26.3