This was found by coccicheck: ./drivers/gpu/drm/kmb/kmb_drv.c:503:2-8: ERROR missing put_device; call of_find_device_by_node on line 490, but without a corresponding object release within this function.
Reported-by: Zeal Robot zealci@zte.com.cn Signed-off-by: jing yangyang jing.yangyang@zte.com.cn --- drivers/gpu/drm/kmb/kmb_drv.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/kmb/kmb_drv.c b/drivers/gpu/drm/kmb/kmb_drv.c index f54392e..58495a9 100644 --- a/drivers/gpu/drm/kmb/kmb_drv.c +++ b/drivers/gpu/drm/kmb/kmb_drv.c @@ -500,8 +500,10 @@ static int kmb_probe(struct platform_device *pdev) ret = kmb_dsi_host_bridge_init(get_device(&dsi_pdev->dev));
if (ret == -EPROBE_DEFER) { + put_device(&dsi_pdev->dev); return -EPROBE_DEFER; } else if (ret) { + put_device(&dsi_pdev->dev); DRM_ERROR("probe failed to initialize DSI host bridge\n"); return ret; } @@ -509,9 +511,10 @@ static int kmb_probe(struct platform_device *pdev) /* Create DRM device */ kmb = devm_drm_dev_alloc(dev, &kmb_driver, struct kmb_drm_private, drm); - if (IS_ERR(kmb)) + if (IS_ERR(kmb)) { + put_device(&dsi_pdev->dev); return PTR_ERR(kmb); - + } dev_set_drvdata(dev, &kmb->drm);
/* Initialize MIPI DSI */
Acked-by: Anitha Chrisanthus anitha.chrisanthus@intel.com
-----Original Message----- From: jing yangyang cgel.zte@gmail.com Sent: Thursday, August 19, 2021 7:10 PM To: Chrisanthus, Anitha anitha.chrisanthus@intel.com Cc: Dea, Edmund J edmund.j.dea@intel.com; David Airlie airlied@linux.ie; Daniel Vetter daniel@ffwll.ch; dri-devel@lists.freedesktop.org; linux- kernel@vger.kernel.org; jing yangyang jing.yangyang@zte.com.cn; Zeal Robot zealci@zte.com.cn Subject: [PATCH linux-next] : add put_device() after of_find_device_by_node()
This was found by coccicheck: ./drivers/gpu/drm/kmb/kmb_drv.c:503:2-8: ERROR missing put_device; call of_find_device_by_node on line 490, but without a corresponding object release within this function.
Reported-by: Zeal Robot zealci@zte.com.cn Signed-off-by: jing yangyang jing.yangyang@zte.com.cn
drivers/gpu/drm/kmb/kmb_drv.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/kmb/kmb_drv.c b/drivers/gpu/drm/kmb/kmb_drv.c index f54392e..58495a9 100644 --- a/drivers/gpu/drm/kmb/kmb_drv.c +++ b/drivers/gpu/drm/kmb/kmb_drv.c @@ -500,8 +500,10 @@ static int kmb_probe(struct platform_device *pdev) ret = kmb_dsi_host_bridge_init(get_device(&dsi_pdev->dev));
if (ret == -EPROBE_DEFER) {
put_device(&dsi_pdev->dev);put_device(&dsi_pdev->dev);@@ -509,9 +511,10 @@ static int kmb_probe(struct platform_device *pdev) /* Create DRM device */ kmb = devm_drm_dev_alloc(dev, &kmb_driver, struct kmb_drm_private, drm);
- if (IS_ERR(kmb))
- if (IS_ERR(kmb)) {
put_device(&dsi_pdev->dev);
} dev_set_drvdata(dev, &kmb->drm);
/* Initialize MIPI DSI */
-- 1.8.3.1
Hi Jing,
-----Original Message----- From: Chrisanthus, Anitha Sent: Monday, August 23, 2021 4:25 PM To: jing yangyang cgel.zte@gmail.com Cc: Dea, Edmund J edmund.j.dea@intel.com; David Airlie airlied@linux.ie; Daniel Vetter daniel@ffwll.ch; dri-devel@lists.freedesktop.org; linux- kernel@vger.kernel.org; jing yangyang jing.yangyang@zte.com.cn; Zeal Robot zealci@zte.com.cn Subject: RE: [PATCH linux-next] : add put_device() after of_find_device_by_node()
Thanks for the patch. Please add drm/kmb: to the subject line and also correct the checkpatch warning. With that ab.
Acked-by: Anitha Chrisanthus anitha.chrisanthus@intel.com
-----Original Message----- From: jing yangyang cgel.zte@gmail.com Sent: Thursday, August 19, 2021 7:10 PM To: Chrisanthus, Anitha anitha.chrisanthus@intel.com Cc: Dea, Edmund J edmund.j.dea@intel.com; David Airlie
Daniel Vetter daniel@ffwll.ch; dri-devel@lists.freedesktop.org; linux- kernel@vger.kernel.org; jing yangyang jing.yangyang@zte.com.cn; Zeal Robot zealci@zte.com.cn Subject: [PATCH linux-next] : add put_device() after
of_find_device_by_node()
This was found by coccicheck: ./drivers/gpu/drm/kmb/kmb_drv.c:503:2-8: ERROR missing put_device; call of_find_device_by_node on line 490, but without a corresponding object release within this function.
Reported-by: Zeal Robot zealci@zte.com.cn Signed-off-by: jing yangyang jing.yangyang@zte.com.cn
drivers/gpu/drm/kmb/kmb_drv.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/kmb/kmb_drv.c b/drivers/gpu/drm/kmb/kmb_drv.c index f54392e..58495a9 100644 --- a/drivers/gpu/drm/kmb/kmb_drv.c +++ b/drivers/gpu/drm/kmb/kmb_drv.c @@ -500,8 +500,10 @@ static int kmb_probe(struct platform_device *pdev) ret = kmb_dsi_host_bridge_init(get_device(&dsi_pdev->dev));
if (ret == -EPROBE_DEFER) {
put_device(&dsi_pdev->dev);put_device(&dsi_pdev->dev);@@ -509,9 +511,10 @@ static int kmb_probe(struct platform_device *pdev) /* Create DRM device */ kmb = devm_drm_dev_alloc(dev, &kmb_driver, struct kmb_drm_private, drm);
- if (IS_ERR(kmb))
- if (IS_ERR(kmb)) {
put_device(&dsi_pdev->dev);
} dev_set_drvdata(dev, &kmb->drm);
/* Initialize MIPI DSI */
-- 1.8.3.1
dri-devel@lists.freedesktop.org
-
Chrisanthus, Anitha -
jing yangyang