[Outreachy kernel][PATCH] gpu: amd: Return boolean types instead of integer values - dri-devel - freedesktop.org experimental mailing list

21 Oct 2020

Return statements for functions returning bool should use truth
and false instead of 1 and 0 respectively.
Modify cik_event_interrupt.c to return false instead of 0.
Issue found with Coccinelle.
Signed-off-by: Sumera Priyadarsini sylphrenadin@gmail.com
---
 drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c b/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c
index 24b471734117..8e64c01565ac 100644
--- a/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c
+++ b/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c
@@ -66,12 +66,12 @@ static bool cik_event_interrupt_isr(struct kfd_dev *dev,
    vmid  = (ihre->ring_id & 0x0000ff00) >> 8;
    if (vmid < dev->vm_info.first_vmid_kfd ||
        vmid > dev->vm_info.last_vmid_kfd)
-		return 0;
+		return false;
/* If there is no valid PASID, it's likely a firmware bug */
    pasid = (ihre->ring_id & 0xffff0000) >> 16;
    if (WARN_ONCE(pasid == 0, "FW bug: No PASID in KFD interrupt"))
-		return 0;
+		return false;
/* Interrupt types we care about: various signals and faults.
     * They will be forwarded to a work queue (see below).
-- 
2.25.1


    