Hi,
Several years ago, I started a thread about stability issues with hp zx1 chipset and ATI FireGL X1 graphics adapter on ia64 platform [1]. As an attempt to minimize problems, a quirk was introduced to restrict AGP mode to 2x [2]. This never solve the stability issues, as the real cause was in fact incorrect settings of the selectable timer interrupt frequency [3].
The attached patch thus removes the useless restriction on AGP mode. Indeed, I'm running at full AGP 4x mode for several weeks now without a problem.
The attached patch applies cleanly against 3.15-rc5.
Thanks,
Émeric
[1] http://marc.info/?l=dri-devel&m=126494456828755&w=2 [2] http://cgit.freedesktop.org/xorg/driver/xf86-video-ati/commit/?id=a7f465f733... [3] http://marc.info/?l=linux-ia64&m=140077543819871&w=2
Oops,
Sorry for the double-post, but the bounce from the sourceforge address let me think that the old list was completely disabled. Well, it seems that mailing to the sourceforge address are forwarded to fdo.
Furthermore, it seems that submitting a patch as an attachment to a message, as outlined in the "Submitting patches" section of the dri/ GettingStarted page is not the correct way to do [1]:
"Submit a patch by posting it to the dri-devel mailing list as an attachment to a message. Make sure you explain clearly what your patch is for."
I'll thus repost my patch as clear text in another message.
Émeric
Removes useless quirk a7f465f73363fce409870f62173d518b1bc02ae6 introduced with fdo #7770 as a failed attempt to minimize stability issues with hp zx1 chipset/ ATI FireGL X1 graphics adapter configuration (see http://marc.info/?l=linux-ia64&m=140077543819871&w=2 for details/reason)
Signed-off-by: Émeric MASCHINO <emeric dot maschino at gmail dot com> ---
diff --git a/drivers/gpu/drm/radeon/radeon_agp.c b/drivers/gpu/drm/radeon/radeon_agp.c index 4243334..a9297b2 100644 --- a/drivers/gpu/drm/radeon/radeon_agp.c +++ b/drivers/gpu/drm/radeon/radeon_agp.c @@ -117,9 +117,6 @@ static struct radeon_agpmode_quirk radeon_agpmode_quirk_list[] = { /* ATI Host Bridge / RV280 [M9+] Needs AGPMode 1 (phoronix forum) */ { PCI_VENDOR_ID_ATI, 0xcbb2, PCI_VENDOR_ID_ATI, 0x5c61, PCI_VENDOR_ID_SONY, 0x8175, 1}, - /* HP Host Bridge / R300 [FireGL X1] Needs AGPMode 2 (fdo #7770) */ - { PCI_VENDOR_ID_HP, 0x122e, PCI_VENDOR_ID_ATI, 0x4e47, - PCI_VENDOR_ID_ATI, 0x0152, 2}, { 0, 0, 0, 0, 0, 0, 0 }, }; #endif
2014-05-22 23:37 GMT+02:00 Émeric MASCHINO emeric.maschino@gmail.com:
Oops,
Sorry for the double-post, but the bounce from the sourceforge address let me think that the old list was completely disabled. Well, it seems that mailing to the sourceforge address are forwarded to fdo.
Furthermore, it seems that submitting a patch as an attachment to a message, as outlined in the "Submitting patches" section of the dri/ GettingStarted page is not the correct way to do [1]:
"Submit a patch by posting it to the dri-devel mailing list as an attachment to a message. Make sure you explain clearly what your patch is for."
I'll thus repost my patch as clear text in another message.
Émeric
On Thu, May 22, 2014 at 5:39 PM, Émeric MASCHINO emeric.maschino@gmail.com wrote:
Removes useless quirk a7f465f73363fce409870f62173d518b1bc02ae6 introduced with fdo #7770 as a failed attempt to minimize stability issues with hp zx1 chipset/ ATI FireGL X1 graphics adapter configuration (see http://marc.info/?l=linux-ia64&m=140077543819871&w=2 for details/reason)
Signed-off-by: Émeric MASCHINO <emeric dot maschino at gmail dot com>
Your patch was mangled, but I was able to apply it manually. Please fix your git email setup. Thanks!
Alex
diff --git a/drivers/gpu/drm/radeon/radeon_agp.c b/drivers/gpu/drm/radeon/radeon_agp.c index 4243334..a9297b2 100644 --- a/drivers/gpu/drm/radeon/radeon_agp.c +++ b/drivers/gpu/drm/radeon/radeon_agp.c @@ -117,9 +117,6 @@ static struct radeon_agpmode_quirk radeon_agpmode_quirk_list[] = { /* ATI Host Bridge / RV280 [M9+] Needs AGPMode 1 (phoronix forum) */ { PCI_VENDOR_ID_ATI, 0xcbb2, PCI_VENDOR_ID_ATI, 0x5c61, PCI_VENDOR_ID_SONY, 0x8175, 1},
- /* HP Host Bridge / R300 [FireGL X1] Needs AGPMode 2 (fdo #7770) */
- { PCI_VENDOR_ID_HP, 0x122e, PCI_VENDOR_ID_ATI, 0x4e47,
PCI_VENDOR_ID_ATI, 0x0152, 2},}; #endif
2014-05-22 23:37 GMT+02:00 Émeric MASCHINO emeric.maschino@gmail.com:
Oops,
Sorry for the double-post, but the bounce from the sourceforge address let me think that the old list was completely disabled. Well, it seems that mailing to the sourceforge address are forwarded to fdo.
Furthermore, it seems that submitting a patch as an attachment to a message, as outlined in the "Submitting patches" section of the dri/ GettingStarted page is not the correct way to do [1]:
"Submit a patch by posting it to the dri-devel mailing list as an attachment to a message. Make sure you explain clearly what your patch is for."
I'll thus repost my patch as clear text in another message.
Émeric
dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
dri-devel@lists.freedesktop.org
-
Alex Deucher -
Émeric MASCHINO