Took Andy's patch [1] and expanded on it a bit.
BR, Jani.
[1] https://patchwork.freedesktop.org/patch/msgid/20211110102857.59604-1-andriy....
Cc: Andy Shevchenko andriy.shevchenko@linux.intel.com
Andy Shevchenko (1): agp/intel-gtt: Replace kernel.h with the necessary inclusions
Jani Nikula (2): drm/i915: include intel-gtt.h only where needed agp/intel-gtt: reduce intel-gtt dependencies more
drivers/char/agp/intel-gtt.c | 1 + drivers/gpu/drm/i915/gt/intel_ggtt.c | 2 ++ drivers/gpu/drm/i915/gt/intel_gt.c | 2 ++ drivers/gpu/drm/i915/i915_drv.h | 1 - include/drm/intel-gtt.h | 8 +++++--- 5 files changed, 10 insertions(+), 4 deletions(-)
Only intel_gt.c and intel_ggtt.c need the interface.
Cc: Andy Shevchenko andriy.shevchenko@linux.intel.com Signed-off-by: Jani Nikula jani.nikula@intel.com --- drivers/gpu/drm/i915/gt/intel_ggtt.c | 1 + drivers/gpu/drm/i915/gt/intel_gt.c | 2 ++ drivers/gpu/drm/i915/i915_drv.h | 1 - 3 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_ggtt.c b/drivers/gpu/drm/i915/gt/intel_ggtt.c index 1fb4a03d7ac3..0c956e5e7fc7 100644 --- a/drivers/gpu/drm/i915/gt/intel_ggtt.c +++ b/drivers/gpu/drm/i915/gt/intel_ggtt.c @@ -9,6 +9,7 @@ #include <asm/smp.h>
#include <drm/i915_drm.h> +#include <drm/intel-gtt.h>
#include "gem/i915_gem_lmem.h"
diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c index 1cb1948ac959..f2422d48be32 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt.c +++ b/drivers/gpu/drm/i915/gt/intel_gt.c @@ -3,6 +3,8 @@ * Copyright © 2019 Intel Corporation */
+#include <drm/intel-gtt.h> + #include "intel_gt_debugfs.h"
#include "gem/i915_gem_lmem.h" diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 21ff781b8149..6f9f20a10c0c 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -50,7 +50,6 @@ #include <linux/stackdepot.h> #include <linux/xarray.h>
-#include <drm/intel-gtt.h> #include <drm/drm_gem.h> #include <drm/drm_auth.h> #include <drm/drm_cache.h>
On Mon, Nov 15, 2021 at 01:53:11PM +0200, Jani Nikula wrote:
Only intel_gt.c and intel_ggtt.c need the interface.
Cc: Andy Shevchenko andriy.shevchenko@linux.intel.com Signed-off-by: Jani Nikula jani.nikula@intel.com
Reviewed-by: Lucas De Marchi lucas.demarchi@intel.com
Lucas De Marchi
From: Andy Shevchenko andriy.shevchenko@linux.intel.com
When kernel.h is used in the headers it adds a lot into dependency hell, especially when there are circular dependencies are involved.
Replace kernel.h inclusion with the list of what is really being used.
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com Signed-off-by: Jani Nikula jani.nikula@intel.com --- include/drm/intel-gtt.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/include/drm/intel-gtt.h b/include/drm/intel-gtt.h index abfefaaf897a..4e5f8e7e25d0 100644 --- a/include/drm/intel-gtt.h +++ b/include/drm/intel-gtt.h @@ -6,7 +6,10 @@
#include <linux/agp_backend.h> #include <linux/intel-iommu.h> -#include <linux/kernel.h> +#include <linux/types.h> + +struct pci_dev; +struct sg_table;
void intel_gtt_get(u64 *gtt_total, phys_addr_t *mappable_base,
On Mon, Nov 15, 2021 at 01:53:12PM +0200, Jani Nikula wrote:
From: Andy Shevchenko andriy.shevchenko@linux.intel.com
When kernel.h is used in the headers it adds a lot into dependency hell, especially when there are circular dependencies are involved.
Replace kernel.h inclusion with the list of what is really being used.
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com Signed-off-by: Jani Nikula jani.nikula@intel.com
Reviewed-by: Lucas De Marchi lucas.demarchi@intel.com
Lucas De Marchi
Don't include stuff on behalf of users if they're not strictly necessary for the header.
Cc: Andy Shevchenko andriy.shevchenko@linux.intel.com Signed-off-by: Jani Nikula jani.nikula@intel.com --- drivers/char/agp/intel-gtt.c | 1 + drivers/gpu/drm/i915/gt/intel_ggtt.c | 1 + include/drm/intel-gtt.h | 3 +-- 3 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/char/agp/intel-gtt.c b/drivers/char/agp/intel-gtt.c index 5bfdf222d5f9..c53cc9868cd8 100644 --- a/drivers/char/agp/intel-gtt.c +++ b/drivers/char/agp/intel-gtt.c @@ -20,6 +20,7 @@ #include <linux/kernel.h> #include <linux/pagemap.h> #include <linux/agp_backend.h> +#include <linux/intel-iommu.h> #include <linux/delay.h> #include <asm/smp.h> #include "agp.h" diff --git a/drivers/gpu/drm/i915/gt/intel_ggtt.c b/drivers/gpu/drm/i915/gt/intel_ggtt.c index 0c956e5e7fc7..555111c3bee5 100644 --- a/drivers/gpu/drm/i915/gt/intel_ggtt.c +++ b/drivers/gpu/drm/i915/gt/intel_ggtt.c @@ -3,6 +3,7 @@ * Copyright © 2020 Intel Corporation */
+#include <linux/agp_backend.h> #include <linux/stop_machine.h>
#include <asm/set_memory.h> diff --git a/include/drm/intel-gtt.h b/include/drm/intel-gtt.h index 4e5f8e7e25d0..67530bfef129 100644 --- a/include/drm/intel-gtt.h +++ b/include/drm/intel-gtt.h @@ -4,10 +4,9 @@ #ifndef _DRM_INTEL_GTT_H #define _DRM_INTEL_GTT_H
-#include <linux/agp_backend.h> -#include <linux/intel-iommu.h> #include <linux/types.h>
+struct agp_bridge_data; struct pci_dev; struct sg_table;
On Mon, Nov 15, 2021 at 01:53:13PM +0200, Jani Nikula wrote:
Don't include stuff on behalf of users if they're not strictly necessary for the header.
Cc: Andy Shevchenko andriy.shevchenko@linux.intel.com Signed-off-by: Jani Nikula jani.nikula@intel.com
Reviewed-by: Lucas De Marchi lucas.demarchi@intel.com
Lucas De Marchi
On Mon, 15 Nov 2021, Jani Nikula jani.nikula@intel.com wrote:
Took Andy's patch [1] and expanded on it a bit.
BR, Jani.
[1] https://patchwork.freedesktop.org/patch/msgid/20211110102857.59604-1-andriy....
Cc: Andy Shevchenko andriy.shevchenko@linux.intel.com
Andy Shevchenko (1): agp/intel-gtt: Replace kernel.h with the necessary inclusions
Forgot to mention, I replaced the drm/i915 prefix with agp/intel-gtt here, no other changes to Andy's patch.
Jani Nikula (2): drm/i915: include intel-gtt.h only where needed agp/intel-gtt: reduce intel-gtt dependencies more
drivers/char/agp/intel-gtt.c | 1 + drivers/gpu/drm/i915/gt/intel_ggtt.c | 2 ++ drivers/gpu/drm/i915/gt/intel_gt.c | 2 ++ drivers/gpu/drm/i915/i915_drv.h | 1 - include/drm/intel-gtt.h | 8 +++++--- 5 files changed, 10 insertions(+), 4 deletions(-)
On Mon, Nov 15, 2021 at 01:55:32PM +0200, Jani Nikula wrote:
On Mon, 15 Nov 2021, Jani Nikula jani.nikula@intel.com wrote:
Took Andy's patch [1] and expanded on it a bit.
BR, Jani.
[1] https://patchwork.freedesktop.org/patch/msgid/20211110102857.59604-1-andriy....
Cc: Andy Shevchenko andriy.shevchenko@linux.intel.com
Andy Shevchenko (1): agp/intel-gtt: Replace kernel.h with the necessary inclusions
Forgot to mention, I replaced the drm/i915 prefix with agp/intel-gtt here, no other changes to Andy's patch.
Acked-by: Daniel Vetter daniel.vetter@ffwll.ch
Also feel free to push through drm-intel.git just in case you wondered about that. -Daniel
Jani Nikula (2): drm/i915: include intel-gtt.h only where needed agp/intel-gtt: reduce intel-gtt dependencies more
drivers/char/agp/intel-gtt.c | 1 + drivers/gpu/drm/i915/gt/intel_ggtt.c | 2 ++ drivers/gpu/drm/i915/gt/intel_gt.c | 2 ++ drivers/gpu/drm/i915/i915_drv.h | 1 - include/drm/intel-gtt.h | 8 +++++--- 5 files changed, 10 insertions(+), 4 deletions(-)
-- Jani Nikula, Intel Open Source Graphics Center
On Mon, 15 Nov 2021, Daniel Vetter daniel@ffwll.ch wrote:
On Mon, Nov 15, 2021 at 01:55:32PM +0200, Jani Nikula wrote:
On Mon, 15 Nov 2021, Jani Nikula jani.nikula@intel.com wrote:
Took Andy's patch [1] and expanded on it a bit.
BR, Jani.
[1] https://patchwork.freedesktop.org/patch/msgid/20211110102857.59604-1-andriy....
Cc: Andy Shevchenko andriy.shevchenko@linux.intel.com
Andy Shevchenko (1): agp/intel-gtt: Replace kernel.h with the necessary inclusions
Forgot to mention, I replaced the drm/i915 prefix with agp/intel-gtt here, no other changes to Andy's patch.
Acked-by: Daniel Vetter daniel.vetter@ffwll.ch
Also feel free to push through drm-intel.git just in case you wondered about that.
Thanks; that's what I was planning on doing anyway. ;)
BR, Jani.
-Daniel
Jani Nikula (2): drm/i915: include intel-gtt.h only where needed agp/intel-gtt: reduce intel-gtt dependencies more
drivers/char/agp/intel-gtt.c | 1 + drivers/gpu/drm/i915/gt/intel_ggtt.c | 2 ++ drivers/gpu/drm/i915/gt/intel_gt.c | 2 ++ drivers/gpu/drm/i915/i915_drv.h | 1 - include/drm/intel-gtt.h | 8 +++++--- 5 files changed, 10 insertions(+), 4 deletions(-)
-- Jani Nikula, Intel Open Source Graphics Center
On Mon, 15 Nov 2021, Jani Nikula jani.nikula@intel.com wrote:
On Mon, 15 Nov 2021, Daniel Vetter daniel@ffwll.ch wrote:
On Mon, Nov 15, 2021 at 01:55:32PM +0200, Jani Nikula wrote:
On Mon, 15 Nov 2021, Jani Nikula jani.nikula@intel.com wrote:
Took Andy's patch [1] and expanded on it a bit.
BR, Jani.
[1] https://patchwork.freedesktop.org/patch/msgid/20211110102857.59604-1-andriy....
Cc: Andy Shevchenko andriy.shevchenko@linux.intel.com
Andy Shevchenko (1): agp/intel-gtt: Replace kernel.h with the necessary inclusions
Forgot to mention, I replaced the drm/i915 prefix with agp/intel-gtt here, no other changes to Andy's patch.
Acked-by: Daniel Vetter daniel.vetter@ffwll.ch
Also feel free to push through drm-intel.git just in case you wondered about that.
Thanks; that's what I was planning on doing anyway. ;)
And pushed to drm-intel-next, thanks for the patch, acks and reviews.
BR, Jani.
BR, Jani.
-Daniel
Jani Nikula (2): drm/i915: include intel-gtt.h only where needed agp/intel-gtt: reduce intel-gtt dependencies more
drivers/char/agp/intel-gtt.c | 1 + drivers/gpu/drm/i915/gt/intel_ggtt.c | 2 ++ drivers/gpu/drm/i915/gt/intel_gt.c | 2 ++ drivers/gpu/drm/i915/i915_drv.h | 1 - include/drm/intel-gtt.h | 8 +++++--- 5 files changed, 10 insertions(+), 4 deletions(-)
-- Jani Nikula, Intel Open Source Graphics Center
On Mon, Nov 15, 2021 at 01:53:10PM +0200, Jani Nikula wrote:
Took Andy's patch [1] and expanded on it a bit.
Thank you! It's always good to have cleanups in the headers, Acked-by: Andy Shevchenko andriy.shevchenko@linux.intel.com for your changes (including ones that you've done against my patch).
[1] https://patchwork.freedesktop.org/patch/msgid/20211110102857.59604-1-andriy....
Cc: Andy Shevchenko andriy.shevchenko@linux.intel.com
Andy Shevchenko (1): agp/intel-gtt: Replace kernel.h with the necessary inclusions
Jani Nikula (2): drm/i915: include intel-gtt.h only where needed agp/intel-gtt: reduce intel-gtt dependencies more
drivers/char/agp/intel-gtt.c | 1 + drivers/gpu/drm/i915/gt/intel_ggtt.c | 2 ++ drivers/gpu/drm/i915/gt/intel_gt.c | 2 ++ drivers/gpu/drm/i915/i915_drv.h | 1 - include/drm/intel-gtt.h | 8 +++++--- 5 files changed, 10 insertions(+), 4 deletions(-)
-- 2.30.2
dri-devel@lists.freedesktop.org