The second lock should be an unlock or it causes a deadlock.
Signed-off-by: Dan Carpenter dan.carpenter@oracle.com
diff --git a/drivers/gpu/drm/radeon/radeon_gart.c b/drivers/gpu/drm/radeon/radeon_gart.c index 2944c78..4a9f797 100644 --- a/drivers/gpu/drm/radeon/radeon_gart.c +++ b/drivers/gpu/drm/radeon/radeon_gart.c @@ -595,7 +595,7 @@ int radeon_vm_bo_rmv(struct radeon_device *rdev, radeon_vm_bo_update_pte(rdev, vm, bo, NULL); radeon_mutex_unlock(&rdev->cs_mutex); list_del(&bo_va->vm_list); - mutex_lock(&vm->mutex); + mutex_unlock(&vm->mutex);
kfree(bo_va); return 0;
On Mon, Jan 9, 2012 at 7:45 AM, Dan Carpenter dan.carpenter@oracle.com wrote:
The second lock should be an unlock or it causes a deadlock.
Signed-off-by: Dan Carpenter dan.carpenter@oracle.com
Reviewed-by: Alex Deucher alexander.deucher@amd.com
diff --git a/drivers/gpu/drm/radeon/radeon_gart.c b/drivers/gpu/drm/radeon/radeon_gart.c index 2944c78..4a9f797 100644 --- a/drivers/gpu/drm/radeon/radeon_gart.c +++ b/drivers/gpu/drm/radeon/radeon_gart.c @@ -595,7 +595,7 @@ int radeon_vm_bo_rmv(struct radeon_device *rdev, radeon_vm_bo_update_pte(rdev, vm, bo, NULL); radeon_mutex_unlock(&rdev->cs_mutex); list_del(&bo_va->vm_list);
- mutex_lock(&vm->mutex);
- mutex_unlock(&vm->mutex);
kfree(bo_va); return 0; _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
dri-devel@lists.freedesktop.org
-
Alex Deucher -
Dan Carpenter