I was handling the request from [0] and then I noticed that some AMD developers were missing from get_maintainers output due to the lack of a reference to their documentation in the MAINTAINERS file.
[0] https://gitlab.freedesktop.org/drm/amd/-/issues/1939#note_1309737
Tales Lelo da Aparecida (2): Documentation/gpu: Add entries to amdgpu glossary MAINTAINERS: add docs entry to AMDGPU
Documentation/gpu/amdgpu/amdgpu-glossary.rst | 13 +++++++++++++ MAINTAINERS | 1 + 2 files changed, 14 insertions(+)
Add missing acronyms to the amdgppu glossary.
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/1939#note_1309737 Signed-off-by: Tales Lelo da Aparecida tales.aparecida@gmail.com --- Documentation/gpu/amdgpu/amdgpu-glossary.rst | 13 +++++++++++++ 1 file changed, 13 insertions(+)
diff --git a/Documentation/gpu/amdgpu/amdgpu-glossary.rst b/Documentation/gpu/amdgpu/amdgpu-glossary.rst index 859dcec6c6f9..48829d097f40 100644 --- a/Documentation/gpu/amdgpu/amdgpu-glossary.rst +++ b/Documentation/gpu/amdgpu/amdgpu-glossary.rst @@ -8,12 +8,19 @@ we have a dedicated glossary for Display Core at
.. glossary::
+ active_cu_number + The number of CUs that are active on the system. The number of active + CUs may be less than SE * SH * CU depending on the board configuration. + CP Command Processor
CPLIB Content Protection Library
+ CU + Compute unit + DFS Digital Frequency Synthesizer
@@ -74,6 +81,12 @@ we have a dedicated glossary for Display Core at SDMA System DMA
+ SE + Shader Engine + + SH + SHader array + SMU System Management Unit
Dear Tales,
Thank you for your patch.
Am 15.04.22 um 21:50 schrieb Tales Lelo da Aparecida:
Add missing acronyms to the amdgppu glossary.
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/1939#note_1309737 Signed-off-by: Tales Lelo da Aparecida tales.aparecida@gmail.com
Documentation/gpu/amdgpu/amdgpu-glossary.rst | 13 +++++++++++++ 1 file changed, 13 insertions(+)
diff --git a/Documentation/gpu/amdgpu/amdgpu-glossary.rst b/Documentation/gpu/amdgpu/amdgpu-glossary.rst index 859dcec6c6f9..48829d097f40 100644 --- a/Documentation/gpu/amdgpu/amdgpu-glossary.rst +++ b/Documentation/gpu/amdgpu/amdgpu-glossary.rst @@ -8,12 +8,19 @@ we have a dedicated glossary for Display Core at
.. glossary::
active_cu_number
The number of CUs that are active on the system. The number of activeCUs may be less than SE * SH * CU depending on the board configuration.CP Command Processor CPLIB Content Protection LibraryCU
Compute unit
Capitalize the U in *unit* as seems to be done in the rest of the files?
DFS Digital Frequency Synthesizer@@ -74,6 +81,12 @@ we have a dedicated glossary for Display Core at SDMA System DMA
- SE
Shader Engine- SH
SHader array
No idea if the H should be capitalized.
SMU System Management Unit
Kind regards,
Paul
Applied the series with minor fix to capitalize the U in Compute Unit. Thanks!
Alex
On Fri, Apr 15, 2022 at 3:52 PM Tales Lelo da Aparecida tales.aparecida@gmail.com wrote:
Add missing acronyms to the amdgppu glossary.
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/1939#note_1309737 Signed-off-by: Tales Lelo da Aparecida tales.aparecida@gmail.com
Documentation/gpu/amdgpu/amdgpu-glossary.rst | 13 +++++++++++++ 1 file changed, 13 insertions(+)
diff --git a/Documentation/gpu/amdgpu/amdgpu-glossary.rst b/Documentation/gpu/amdgpu/amdgpu-glossary.rst index 859dcec6c6f9..48829d097f40 100644 --- a/Documentation/gpu/amdgpu/amdgpu-glossary.rst +++ b/Documentation/gpu/amdgpu/amdgpu-glossary.rst @@ -8,12 +8,19 @@ we have a dedicated glossary for Display Core at
.. glossary::
active_cu_number
The number of CUs that are active on the system. The number of activeCUs may be less than SE * SH * CU depending on the board configuration.CP Command Processor
CPLIB Content Protection Library
CU
Compute unitDFS Digital Frequency Synthesizer
@@ -74,6 +81,12 @@ we have a dedicated glossary for Display Core at SDMA System DMA
- SE
Shader Engine- SH
SHader array- SMU System Management Unit
-- 2.35.1
To make sure maintainers of amdgpu drivers are aware of any changes in their documentation, add its entry to MAINTAINERS.
Signed-off-by: Tales Lelo da Aparecida tales.aparecida@gmail.com --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS index d54b9f15ffce..b3594b2a09de 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -16449,6 +16449,7 @@ S: Supported T: git https://gitlab.freedesktop.org/agd5f/linux.git B: https://gitlab.freedesktop.org/drm/amd/-/issues C: irc://irc.oftc.net/radeon +F: Documentation/gpu/amdgpu/ F: drivers/gpu/drm/amd/ F: drivers/gpu/drm/radeon/ F: include/uapi/drm/amdgpu_drm.h
On 4/16/22 02:50, Tales Lelo da Aparecida wrote:
To make sure maintainers of amdgpu drivers are aware of any changes in their documentation, add its entry to MAINTAINERS.
Did you mean the Documentation/gpu/amdgpu/ is maintained by dri-devel?
Hi Bagas Sanjaya,
Em sáb., 16 de abr. de 2022 às 02:47, Bagas Sanjaya bagasdotme@gmail.com escreveu:
On 4/16/22 02:50, Tales Lelo da Aparecida wrote:
To make sure maintainers of amdgpu drivers are aware of any changes in their documentation, add its entry to MAINTAINERS.
Did you mean the Documentation/gpu/amdgpu/ is maintained by dri-devel?
`Documentation/gpu/amdgpu/` should be maintained by "RADEON and AMDGPU DRM DRIVERS" developers, which are part of the dri-devel community.
Kind regards
Am 15.04.22 um 21:50 schrieb Tales Lelo da Aparecida:
I was handling the request from [0] and then I noticed that some AMD developers were missing from get_maintainers output due to the lack of a reference to their documentation in the MAINTAINERS file.
Acked-by: Christian König christian.koenig@amd.com
[0] https://gitlab.freedesktop.org/drm/amd/-/issues/1939#note_1309737
Tales Lelo da Aparecida (2): Documentation/gpu: Add entries to amdgpu glossary MAINTAINERS: add docs entry to AMDGPU
Documentation/gpu/amdgpu/amdgpu-glossary.rst | 13 +++++++++++++ MAINTAINERS | 1 + 2 files changed, 14 insertions(+)
dri-devel@lists.freedesktop.org
-
Alex Deucher -
Bagas Sanjaya -
Christian König -
Paul Menzel -
Tales -
Tales Lelo da Aparecida