On Fri, Jan 08, 2021 at 06:41:05PM +0800, Tian Tao wrote:

Based on the drm_connector_mode_valid, if the hibmc implementation of mode_valid only returns MODE_OK, then we can not implement the

s/can not/need not/

mode_valid function.

Signed-off-by: Tian Tao tiantao6@hisilicon.com

Reviewed-by: Daniel Vetter daniel.vetter@ffwll.ch

---

drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 7 ------- 1 file changed, 7 deletions(-)

diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c index c76f996..c74a35b 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c @@ -43,12 +43,6 @@ static int hibmc_connector_get_modes(struct drm_connector *connector) return count; }

-static enum drm_mode_status hibmc_connector_mode_valid(struct drm_connector *connector,

• 				       struct drm_display_mode *mode)
  

-{

• return MODE_OK;

-}

static void hibmc_connector_destroy(struct drm_connector *connector) { struct hibmc_connector *hibmc_connector = to_hibmc_connector(connector); @@ -60,7 +54,6 @@ static void hibmc_connector_destroy(struct drm_connector *connector) static const struct drm_connector_helper_funcs hibmc_connector_helper_funcs = { .get_modes = hibmc_connector_get_modes,

• .mode_valid = hibmc_connector_mode_valid,

};

static const struct drm_connector_funcs hibmc_connector_funcs = {

2.7.4