drm_bridge_funcs includes several duplicated operations as atomic variants has been added over time. New bridge drivers shall use the atomic variants - mark the deprecated operations to try to avoid usage in new bridge drivers.
Signed-off-by: Sam Ravnborg sam@ravnborg.org Cc: Laurent Pinchart laurent.pinchart@ideasonboard.com Cc: Andrzej Hajda a.hajda@samsung.com Cc: Maarten Lankhorst maarten.lankhorst@linux.intel.com Cc: Maxime Ripard mripard@kernel.org Cc: Thomas Zimmermann tzimmermann@suse.de Cc: David Airlie airlied@linux.ie Cc: Daniel Vetter daniel@ffwll.ch --- include/drm/drm_bridge.h | 28 ++++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-)
diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h index 2195daa289d2..6805898d70f5 100644 --- a/include/drm/drm_bridge.h +++ b/include/drm/drm_bridge.h @@ -171,6 +171,11 @@ struct drm_bridge_funcs { * signals) feeding it is still running when this callback is called. * * The @disable callback is optional. + * + * NOTE: + * + * This is deprecated, do not use! + * New drivers shall use &drm_bridge_funcs.atomic_disable. */ void (*disable)(struct drm_bridge *bridge);
@@ -190,6 +195,11 @@ struct drm_bridge_funcs { * called. * * The @post_disable callback is optional. + * + * NOTE: + * + * This is deprecated, do not use! + * New drivers shall use &drm_bridge_funcs.atomic_post_disable. */ void (*post_disable)(struct drm_bridge *bridge);
@@ -213,11 +223,15 @@ struct drm_bridge_funcs { * For atomic drivers the adjusted_mode is the mode stored in * &drm_crtc_state.adjusted_mode. * - * NOTE: - * * If a need arises to store and access modes adjusted for other * locations than the connection between the CRTC and the first bridge, * the DRM framework will have to be extended with DRM bridge states. + * + * NOTE: + * + * This is deprecated, do not use! + * New drivers shall set their mode in &drm_bridge_funcs.atomic_enable + * operation. */ void (*mode_set)(struct drm_bridge *bridge, const struct drm_display_mode *mode, @@ -239,6 +253,11 @@ struct drm_bridge_funcs { * there is one) when this callback is called. * * The @pre_enable callback is optional. + * + * NOTE: + * + * This is deprecated, do not use! + * New drivers shall use &drm_bridge_funcs.atomic_pre_enable. */ void (*pre_enable)(struct drm_bridge *bridge);
@@ -259,6 +278,11 @@ struct drm_bridge_funcs { * chain if there is one. * * The @enable callback is optional. + * + * NOTE: + * + * This is deprecated, do not use! + * New drivers shall use &drm_bridge_funcs.atomic_enable. */ void (*enable)(struct drm_bridge *bridge);
On Sat, Jul 10, 2021 at 10:42:40AM +0200, Sam Ravnborg wrote:
drm_bridge_funcs includes several duplicated operations as atomic variants has been added over time. New bridge drivers shall use the atomic variants - mark the deprecated operations to try to avoid usage in new bridge drivers.
Signed-off-by: Sam Ravnborg sam@ravnborg.org Cc: Laurent Pinchart laurent.pinchart@ideasonboard.com Cc: Andrzej Hajda a.hajda@samsung.com Cc: Maarten Lankhorst maarten.lankhorst@linux.intel.com Cc: Maxime Ripard mripard@kernel.org Cc: Thomas Zimmermann tzimmermann@suse.de Cc: David Airlie airlied@linux.ie Cc: Daniel Vetter daniel@ffwll.ch
Acked-by: Maxime Ripard maxime@cerno.tech
Thanks! Maxime
Hi Sam,
Thank you for the patch.
On Sat, Jul 10, 2021 at 10:42:40AM +0200, Sam Ravnborg wrote:
drm_bridge_funcs includes several duplicated operations as atomic variants has been added over time.
s/has/have/
New bridge drivers shall use the atomic variants - mark the deprecated operations to try to avoid usage in new bridge drivers.
Signed-off-by: Sam Ravnborg sam@ravnborg.org Cc: Laurent Pinchart laurent.pinchart@ideasonboard.com Cc: Andrzej Hajda a.hajda@samsung.com Cc: Maarten Lankhorst maarten.lankhorst@linux.intel.com Cc: Maxime Ripard mripard@kernel.org Cc: Thomas Zimmermann tzimmermann@suse.de Cc: David Airlie airlied@linux.ie Cc: Daniel Vetter daniel@ffwll.ch
include/drm/drm_bridge.h | 28 ++++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-)
diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h index 2195daa289d2..6805898d70f5 100644 --- a/include/drm/drm_bridge.h +++ b/include/drm/drm_bridge.h @@ -171,6 +171,11 @@ struct drm_bridge_funcs { * signals) feeding it is still running when this callback is called. * * The @disable callback is optional.
** NOTE:** This is deprecated, do not use!* New drivers shall use &drm_bridge_funcs.atomic_disable.@@ -190,6 +195,11 @@ struct drm_bridge_funcs { * called. * * The @post_disable callback is optional.
** NOTE:** This is deprecated, do not use!* New drivers shall use &drm_bridge_funcs.atomic_post_disable.@@ -213,11 +223,15 @@ struct drm_bridge_funcs { * For atomic drivers the adjusted_mode is the mode stored in * &drm_crtc_state.adjusted_mode. *
* NOTE:*
- If a need arises to store and access modes adjusted for other
- locations than the connection between the CRTC and the first bridge,
- the DRM framework will have to be extended with DRM bridge states.
The DRM framework *has* been extended with DRM bridge states :-) Should this be dropped ?
Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
** NOTE:** This is deprecated, do not use!* New drivers shall set their mode in &drm_bridge_funcs.atomic_enable* operation.@@ -239,6 +253,11 @@ struct drm_bridge_funcs { * there is one) when this callback is called. * * The @pre_enable callback is optional.
** NOTE:** This is deprecated, do not use!* New drivers shall use &drm_bridge_funcs.atomic_pre_enable.@@ -259,6 +278,11 @@ struct drm_bridge_funcs { * chain if there is one. * * The @enable callback is optional.
** NOTE:** This is deprecated, do not use!* New drivers shall use &drm_bridge_funcs.atomic_enable.
Hi Laurent,
On Sat, Jul 10, 2021 at 11:46:24PM +0300, Laurent Pinchart wrote:
Hi Sam,
Thank you for the patch.
On Sat, Jul 10, 2021 at 10:42:40AM +0200, Sam Ravnborg wrote:
drm_bridge_funcs includes several duplicated operations as atomic variants has been added over time.
s/has/have/
New bridge drivers shall use the atomic variants - mark the deprecated operations to try to avoid usage in new bridge drivers.
Signed-off-by: Sam Ravnborg sam@ravnborg.org Cc: Laurent Pinchart laurent.pinchart@ideasonboard.com Cc: Andrzej Hajda a.hajda@samsung.com Cc: Maarten Lankhorst maarten.lankhorst@linux.intel.com Cc: Maxime Ripard mripard@kernel.org Cc: Thomas Zimmermann tzimmermann@suse.de Cc: David Airlie airlied@linux.ie Cc: Daniel Vetter daniel@ffwll.ch
include/drm/drm_bridge.h | 28 ++++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-)
diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h index 2195daa289d2..6805898d70f5 100644 --- a/include/drm/drm_bridge.h +++ b/include/drm/drm_bridge.h @@ -171,6 +171,11 @@ struct drm_bridge_funcs { * signals) feeding it is still running when this callback is called. * * The @disable callback is optional.
** NOTE:** This is deprecated, do not use!* New drivers shall use &drm_bridge_funcs.atomic_disable.@@ -190,6 +195,11 @@ struct drm_bridge_funcs { * called. * * The @post_disable callback is optional.
** NOTE:** This is deprecated, do not use!* New drivers shall use &drm_bridge_funcs.atomic_post_disable.@@ -213,11 +223,15 @@ struct drm_bridge_funcs { * For atomic drivers the adjusted_mode is the mode stored in * &drm_crtc_state.adjusted_mode. *
* NOTE:*
- If a need arises to store and access modes adjusted for other
- locations than the connection between the CRTC and the first bridge,
- the DRM framework will have to be extended with DRM bridge states.
The DRM framework *has* been extended with DRM bridge states :-) Should this be dropped ?
I dropped this while applying.
Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
Tnanks!
Sam
dri-devel@lists.freedesktop.org
-
Laurent Pinchart -
Maxime Ripard -
Sam Ravnborg