On Wed, Jun 01, 2022 at 07:12:55PM +0800, Jiasheng Jiang wrote:

On Wed, Jun 01, 2022 at 05:15:37PM +0800, Laurent Pinchart wrote:

...

...

Well, as far as I am concerned, the adv7511_exit() in the same file has already dealt with the issue. Therefore, it might not be necessary to add another mipi_dsi_driver_unregister().

The issue is that adv7511_exit() is not called if adv7511_init() fails.

Sorry, I can not find the caller of adv7511_init(). Please give me more detail.

It's called by the kernel when the module is unloaded (module_exit). It's not what Laurent is saying though.

His point is that in adv7511, if i2c_add_driver fails, you'll still need to call mipi_dsi_driver_unregister to clean things up.

Maxime