Module parameter descriptions don't take a trailing \n, otherwise it breaks formatting of modinfo's output. Also remove trailing space.
Signed-off-by: Jean Delvare jdelvare@suse.de Cc: David Airlie airlied@linux.ie Cc: Ben Skeggs bskeggs@redhat.com --- drivers/gpu/drm/nouveau/nouveau_drv.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
--- linux-3.2-rc3.orig/drivers/gpu/drm/nouveau/nouveau_drv.c 2011-11-09 15:53:32.000000000 +0100 +++ linux-3.2-rc3/drivers/gpu/drm/nouveau/nouveau_drv.c 2011-11-29 10:33:37.000000000 +0100 @@ -89,7 +89,7 @@ MODULE_PARM_DESC(override_conntype, "Ign int nouveau_override_conntype = 0; module_param_named(override_conntype, nouveau_override_conntype, int, 0400);
-MODULE_PARM_DESC(tv_disable, "Disable TV-out detection\n"); +MODULE_PARM_DESC(tv_disable, "Disable TV-out detection"); int nouveau_tv_disable = 0; module_param_named(tv_disable, nouveau_tv_disable, int, 0400);
@@ -104,23 +104,23 @@ module_param_named(tv_norm, nouveau_tv_n MODULE_PARM_DESC(reg_debug, "Register access debug bitmask:\n" "\t\t0x1 mc, 0x2 video, 0x4 fb, 0x8 extdev,\n" "\t\t0x10 crtc, 0x20 ramdac, 0x40 vgacrtc, 0x80 rmvio,\n" - "\t\t0x100 vgaattr, 0x200 EVO (G80+). "); + "\t\t0x100 vgaattr, 0x200 EVO (G80+)"); int nouveau_reg_debug; module_param_named(reg_debug, nouveau_reg_debug, int, 0600);
-MODULE_PARM_DESC(perflvl, "Performance level (default: boot)\n"); +MODULE_PARM_DESC(perflvl, "Performance level (default: boot)"); char *nouveau_perflvl; module_param_named(perflvl, nouveau_perflvl, charp, 0400);
-MODULE_PARM_DESC(perflvl_wr, "Allow perflvl changes (warning: dangerous!)\n"); +MODULE_PARM_DESC(perflvl_wr, "Allow perflvl changes (warning: dangerous!)"); int nouveau_perflvl_wr; module_param_named(perflvl_wr, nouveau_perflvl_wr, int, 0400);
-MODULE_PARM_DESC(msi, "Enable MSI (default: off)\n"); +MODULE_PARM_DESC(msi, "Enable MSI (default: off)"); int nouveau_msi; module_param_named(msi, nouveau_msi, int, 0400);
-MODULE_PARM_DESC(ctxfw, "Use external HUB/GPC ucode (fermi)\n"); +MODULE_PARM_DESC(ctxfw, "Use external HUB/GPC ucode (fermi)"); int nouveau_ctxfw; module_param_named(ctxfw, nouveau_ctxfw, int, 0400);
On Wednesday 30 November 2011 05:23:55 pm Jean Delvare wrote:
Module parameter descriptions don't take a trailing \n, otherwise it breaks formatting of modinfo's output. Also remove trailing space.
Signed-off-by: Jean Delvare jdelvare@suse.de Cc: David Airlie airlied@linux.ie Cc: Ben Skeggs bskeggs@redhat.com
drivers/gpu/drm/nouveau/nouveau_drv.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (...)
David, Ben, can either of you please pick this patch now? It's pretty trivial and has been waiting for over a month already.
Thanks,
On Wed, 2012-01-11 at 11:28 +0100, Jean Delvare wrote:
On Wednesday 30 November 2011 05:23:55 pm Jean Delvare wrote:
Module parameter descriptions don't take a trailing \n, otherwise it breaks formatting of modinfo's output. Also remove trailing space.
Signed-off-by: Jean Delvare jdelvare@suse.de Cc: David Airlie airlied@linux.ie Cc: Ben Skeggs bskeggs@redhat.com
drivers/gpu/drm/nouveau/nouveau_drv.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (...)
David, Ben, can either of you please pick this patch now? It's pretty trivial and has been waiting for over a month already.
I've picked it up in nouveau's tree.
Thanks, Ben.
Thanks,
dri-devel@lists.freedesktop.org