Most of these are old leftovers from one of the driver merges. This is all dead code.
Signed-off-by: Patrik Jakobsson patrik.r.jakobsson@gmail.com --- drivers/gpu/drm/gma500/psb_drv.h | 75 +------------------------------- 1 file changed, 1 insertion(+), 74 deletions(-)
diff --git a/drivers/gpu/drm/gma500/psb_drv.h b/drivers/gpu/drm/gma500/psb_drv.h index 553d03190ce1..66f61909a8c8 100644 --- a/drivers/gpu/drm/gma500/psb_drv.h +++ b/drivers/gpu/drm/gma500/psb_drv.h @@ -36,12 +36,6 @@ /* Append new drm mode definition here, align with libdrm definition */ #define DRM_MODE_SCALE_NO_SCALE 2
-enum { - CHIP_PSB_8108 = 0, /* Poulsbo */ - CHIP_PSB_8109 = 1, /* Poulsbo */ - CHIP_MRST_4100 = 2, /* Moorestown/Oaktrail */ -}; - #define IS_PSB(drm) ((to_pci_dev((drm)->dev)->device & 0xfffe) == 0x8108) #define IS_MRST(drm) ((to_pci_dev((drm)->dev)->device & 0xfff0) == 0x4100) #define IS_CDV(drm) ((to_pci_dev((drm)->dev)->device & 0xfff0) == 0x0be0) @@ -617,15 +611,7 @@ struct psb_ops { int i2c_bus; /* I2C bus identifier for Moorestown */ };
- - -extern int drm_crtc_probe_output_modes(struct drm_device *dev, int, int); -extern int drm_pick_crtcs(struct drm_device *dev); - /* psb_irq.c */ -extern void psb_irq_uninstall_islands(struct drm_device *dev, int hw_islands); -extern int psb_vblank_wait2(struct drm_device *dev, unsigned int *sequence); -extern int psb_vblank_wait(struct drm_device *dev, unsigned int *sequence); extern int psb_enable_vblank(struct drm_crtc *crtc); extern void psb_disable_vblank(struct drm_crtc *crtc); void @@ -636,17 +622,9 @@ psb_disable_pipestat(struct drm_psb_private *dev_priv, int pipe, u32 mask);
extern u32 psb_get_vblank_counter(struct drm_crtc *crtc);
-/* framebuffer.c */ -extern int psbfb_probed(struct drm_device *dev); -extern int psbfb_remove(struct drm_device *dev, - struct drm_framebuffer *fb); -/* psb_drv.c */ -extern void psb_spank(struct drm_psb_private *dev_priv); - -/* psb_reset.c */ +/* psb_lid.c */ extern void psb_lid_timer_init(struct drm_psb_private *dev_priv); extern void psb_lid_timer_takedown(struct drm_psb_private *dev_priv); -extern void psb_print_pagefault(struct drm_psb_private *dev_priv);
/* modesetting */ extern void psb_modeset_init(struct drm_device *dev); @@ -689,43 +667,7 @@ extern const struct psb_ops oaktrail_chip_ops; /* cdv_device.c */ extern const struct psb_ops cdv_chip_ops;
-/* Debug print bits setting */ -#define PSB_D_GENERAL (1 << 0) -#define PSB_D_INIT (1 << 1) -#define PSB_D_IRQ (1 << 2) -#define PSB_D_ENTRY (1 << 3) -/* debug the get H/V BP/FP count */ -#define PSB_D_HV (1 << 4) -#define PSB_D_DBI_BF (1 << 5) -#define PSB_D_PM (1 << 6) -#define PSB_D_RENDER (1 << 7) -#define PSB_D_REG (1 << 8) -#define PSB_D_MSVDX (1 << 9) -#define PSB_D_TOPAZ (1 << 10) - -extern int drm_idle_check_interval; - /* Utilities */ -static inline u32 MRST_MSG_READ32(int domain, uint port, uint offset) -{ - int mcr = (0xD0<<24) | (port << 16) | (offset << 8); - uint32_t ret_val = 0; - struct pci_dev *pci_root = pci_get_domain_bus_and_slot(domain, 0, 0); - pci_write_config_dword(pci_root, 0xD0, mcr); - pci_read_config_dword(pci_root, 0xD4, &ret_val); - pci_dev_put(pci_root); - return ret_val; -} -static inline void MRST_MSG_WRITE32(int domain, uint port, uint offset, - u32 value) -{ - int mcr = (0xE0<<24) | (port << 16) | (offset << 8) | 0xF0; - struct pci_dev *pci_root = pci_get_domain_bus_and_slot(domain, 0, 0); - pci_write_config_dword(pci_root, 0xD4, value); - pci_write_config_dword(pci_root, 0xD0, mcr); - pci_dev_put(pci_root); -} - static inline uint32_t REGISTER_READ(struct drm_device *dev, uint32_t reg) { struct drm_psb_private *dev_priv = to_drm_psb_private(dev); @@ -806,24 +748,9 @@ static inline void REGISTER_WRITE8(struct drm_device *dev, #define PSB_WVDC32(_val, _offs) iowrite32(_val, dev_priv->vdc_reg + (_offs)) #define PSB_RVDC32(_offs) ioread32(dev_priv->vdc_reg + (_offs))
-/* #define TRAP_SGX_PM_FAULT 1 */ -#ifdef TRAP_SGX_PM_FAULT -#define PSB_RSGX32(_offs) \ -({ \ - if (inl(dev_priv->apm_base + PSB_APM_STS) & 0x3) { \ - pr_err("access sgx when it's off!! (READ) %s, %d\n", \ - __FILE__, __LINE__); \ - melay(1000); \ - } \ - ioread32(dev_priv->sgx_reg + (_offs)); \ -}) -#else #define PSB_RSGX32(_offs) ioread32(dev_priv->sgx_reg + (_offs)) -#endif #define PSB_WSGX32(_val, _offs) iowrite32(_val, dev_priv->sgx_reg + (_offs))
-#define MSVDX_REG_DUMP 0 - #define PSB_WMSVDX32(_val, _offs) iowrite32(_val, dev_priv->msvdx_reg + (_offs)) #define PSB_RMSVDX32(_offs) ioread32(dev_priv->msvdx_reg + (_offs))
Hi Patrik,
On Thu, Mar 17, 2022 at 10:25:52AM +0100, Patrik Jakobsson wrote:
Most of these are old leftovers from one of the driver merges. This is all dead code.
Nice cleanups. For all four patches: Acked-by: Sam Ravnborg sam@ravnborg.org
Hi Patrik
Am 17.03.22 um 10:25 schrieb Patrik Jakobsson:
Most of these are old leftovers from one of the driver merges. This is all dead code.
Signed-off-by: Patrik Jakobsson patrik.r.jakobsson@gmail.com
drivers/gpu/drm/gma500/psb_drv.h | 75 +------------------------------- 1 file changed, 1 insertion(+), 74 deletions(-)
diff --git a/drivers/gpu/drm/gma500/psb_drv.h b/drivers/gpu/drm/gma500/psb_drv.h index 553d03190ce1..66f61909a8c8 100644 --- a/drivers/gpu/drm/gma500/psb_drv.h +++ b/drivers/gpu/drm/gma500/psb_drv.h @@ -36,12 +36,6 @@ /* Append new drm mode definition here, align with libdrm definition */ #define DRM_MODE_SCALE_NO_SCALE 2
-enum {
- CHIP_PSB_8108 = 0, /* Poulsbo */
- CHIP_PSB_8109 = 1, /* Poulsbo */
- CHIP_MRST_4100 = 2, /* Moorestown/Oaktrail */
-};
- #define IS_PSB(drm) ((to_pci_dev((drm)->dev)->device & 0xfffe) == 0x8108) #define IS_MRST(drm) ((to_pci_dev((drm)->dev)->device & 0xfff0) == 0x4100) #define IS_CDV(drm) ((to_pci_dev((drm)->dev)->device & 0xfff0) == 0x0be0)
@@ -617,15 +611,7 @@ struct psb_ops { int i2c_bus; /* I2C bus identifier for Moorestown */ };
-extern int drm_crtc_probe_output_modes(struct drm_device *dev, int, int); -extern int drm_pick_crtcs(struct drm_device *dev);
- /* psb_irq.c */
-extern void psb_irq_uninstall_islands(struct drm_device *dev, int hw_islands); -extern int psb_vblank_wait2(struct drm_device *dev, unsigned int *sequence); -extern int psb_vblank_wait(struct drm_device *dev, unsigned int *sequence); extern int psb_enable_vblank(struct drm_crtc *crtc); extern void psb_disable_vblank(struct drm_crtc *crtc);
The vblank enable/disable functions are also declared in psb_irq.h. The declarations here could be removed as well.
void @@ -636,17 +622,9 @@ psb_disable_pipestat(struct drm_psb_private *dev_priv, int pipe, u32 mask);
extern u32 psb_get_vblank_counter(struct drm_crtc *crtc);
-/* framebuffer.c */ -extern int psbfb_probed(struct drm_device *dev); -extern int psbfb_remove(struct drm_device *dev,
struct drm_framebuffer *fb);-/* psb_drv.c */ -extern void psb_spank(struct drm_psb_private *dev_priv);
This function is still around in psb_drv.c. It should now be declared static.
Best regards Thomas
-/* psb_reset.c */ +/* psb_lid.c */ extern void psb_lid_timer_init(struct drm_psb_private *dev_priv); extern void psb_lid_timer_takedown(struct drm_psb_private *dev_priv); -extern void psb_print_pagefault(struct drm_psb_private *dev_priv);
/* modesetting */ extern void psb_modeset_init(struct drm_device *dev); @@ -689,43 +667,7 @@ extern const struct psb_ops oaktrail_chip_ops; /* cdv_device.c */ extern const struct psb_ops cdv_chip_ops;
-/* Debug print bits setting */ -#define PSB_D_GENERAL (1 << 0) -#define PSB_D_INIT (1 << 1) -#define PSB_D_IRQ (1 << 2) -#define PSB_D_ENTRY (1 << 3) -/* debug the get H/V BP/FP count */ -#define PSB_D_HV (1 << 4) -#define PSB_D_DBI_BF (1 << 5) -#define PSB_D_PM (1 << 6) -#define PSB_D_RENDER (1 << 7) -#define PSB_D_REG (1 << 8) -#define PSB_D_MSVDX (1 << 9) -#define PSB_D_TOPAZ (1 << 10)
-extern int drm_idle_check_interval;
- /* Utilities */
-static inline u32 MRST_MSG_READ32(int domain, uint port, uint offset) -{
- int mcr = (0xD0<<24) | (port << 16) | (offset << 8);
- uint32_t ret_val = 0;
- struct pci_dev *pci_root = pci_get_domain_bus_and_slot(domain, 0, 0);
- pci_write_config_dword(pci_root, 0xD0, mcr);
- pci_read_config_dword(pci_root, 0xD4, &ret_val);
- pci_dev_put(pci_root);
- return ret_val;
-} -static inline void MRST_MSG_WRITE32(int domain, uint port, uint offset,
u32 value)-{
- int mcr = (0xE0<<24) | (port << 16) | (offset << 8) | 0xF0;
- struct pci_dev *pci_root = pci_get_domain_bus_and_slot(domain, 0, 0);
- pci_write_config_dword(pci_root, 0xD4, value);
- pci_write_config_dword(pci_root, 0xD0, mcr);
- pci_dev_put(pci_root);
-}
- static inline uint32_t REGISTER_READ(struct drm_device *dev, uint32_t reg) { struct drm_psb_private *dev_priv = to_drm_psb_private(dev);
@@ -806,24 +748,9 @@ static inline void REGISTER_WRITE8(struct drm_device *dev, #define PSB_WVDC32(_val, _offs) iowrite32(_val, dev_priv->vdc_reg + (_offs)) #define PSB_RVDC32(_offs) ioread32(dev_priv->vdc_reg + (_offs))
-/* #define TRAP_SGX_PM_FAULT 1 */ -#ifdef TRAP_SGX_PM_FAULT -#define PSB_RSGX32(_offs) \ -({ \
- if (inl(dev_priv->apm_base + PSB_APM_STS) & 0x3) { \
pr_err("access sgx when it's off!! (READ) %s, %d\n", \__FILE__, __LINE__); \melay(1000); \- } \
- ioread32(dev_priv->sgx_reg + (_offs)); \
-}) -#else #define PSB_RSGX32(_offs) ioread32(dev_priv->sgx_reg + (_offs)) -#endif #define PSB_WSGX32(_val, _offs) iowrite32(_val, dev_priv->sgx_reg + (_offs))
-#define MSVDX_REG_DUMP 0
- #define PSB_WMSVDX32(_val, _offs) iowrite32(_val, dev_priv->msvdx_reg + (_offs)) #define PSB_RMSVDX32(_offs) ioread32(dev_priv->msvdx_reg + (_offs))
On Thu, Mar 17, 2022 at 8:44 PM Thomas Zimmermann tzimmermann@suse.de wrote:
Hi Patrik
Hi Thomas and Sam, I have already pushed this series with Daniels ack so I'll address any issues in follow-up patches.
Thanks for the extra eyes
Am 17.03.22 um 10:25 schrieb Patrik Jakobsson:
Most of these are old leftovers from one of the driver merges. This is all dead code.
Signed-off-by: Patrik Jakobsson patrik.r.jakobsson@gmail.com
drivers/gpu/drm/gma500/psb_drv.h | 75 +------------------------------- 1 file changed, 1 insertion(+), 74 deletions(-)
diff --git a/drivers/gpu/drm/gma500/psb_drv.h b/drivers/gpu/drm/gma500/psb_drv.h index 553d03190ce1..66f61909a8c8 100644 --- a/drivers/gpu/drm/gma500/psb_drv.h +++ b/drivers/gpu/drm/gma500/psb_drv.h @@ -36,12 +36,6 @@ /* Append new drm mode definition here, align with libdrm definition */ #define DRM_MODE_SCALE_NO_SCALE 2
-enum {
CHIP_PSB_8108 = 0, /* Poulsbo */CHIP_PSB_8109 = 1, /* Poulsbo */CHIP_MRST_4100 = 2, /* Moorestown/Oaktrail */-};
- #define IS_PSB(drm) ((to_pci_dev((drm)->dev)->device & 0xfffe) == 0x8108) #define IS_MRST(drm) ((to_pci_dev((drm)->dev)->device & 0xfff0) == 0x4100) #define IS_CDV(drm) ((to_pci_dev((drm)->dev)->device & 0xfff0) == 0x0be0)
@@ -617,15 +611,7 @@ struct psb_ops { int i2c_bus; /* I2C bus identifier for Moorestown */ };
-extern int drm_crtc_probe_output_modes(struct drm_device *dev, int, int); -extern int drm_pick_crtcs(struct drm_device *dev);
- /* psb_irq.c */
-extern void psb_irq_uninstall_islands(struct drm_device *dev, int hw_islands); -extern int psb_vblank_wait2(struct drm_device *dev, unsigned int *sequence); -extern int psb_vblank_wait(struct drm_device *dev, unsigned int *sequence); extern int psb_enable_vblank(struct drm_crtc *crtc); extern void psb_disable_vblank(struct drm_crtc *crtc);
The vblank enable/disable functions are also declared in psb_irq.h. The declarations here could be removed as well.
They get removed in patch 4/4 in this series.
void @@ -636,17 +622,9 @@ psb_disable_pipestat(struct drm_psb_private *dev_priv, int pipe, u32 mask);
extern u32 psb_get_vblank_counter(struct drm_crtc *crtc);
-/* framebuffer.c */ -extern int psbfb_probed(struct drm_device *dev); -extern int psbfb_remove(struct drm_device *dev,
struct drm_framebuffer *fb);-/* psb_drv.c */ -extern void psb_spank(struct drm_psb_private *dev_priv);
This function is still around in psb_drv.c. It should now be declared static.
Yes it should be static. I have a patch that renames this function (psb_spank is a really bad name). I'll make it static in that patch.
Best regards Thomas
-/* psb_reset.c */ +/* psb_lid.c */ extern void psb_lid_timer_init(struct drm_psb_private *dev_priv); extern void psb_lid_timer_takedown(struct drm_psb_private *dev_priv); -extern void psb_print_pagefault(struct drm_psb_private *dev_priv);
/* modesetting */ extern void psb_modeset_init(struct drm_device *dev); @@ -689,43 +667,7 @@ extern const struct psb_ops oaktrail_chip_ops; /* cdv_device.c */ extern const struct psb_ops cdv_chip_ops;
-/* Debug print bits setting */ -#define PSB_D_GENERAL (1 << 0) -#define PSB_D_INIT (1 << 1) -#define PSB_D_IRQ (1 << 2) -#define PSB_D_ENTRY (1 << 3) -/* debug the get H/V BP/FP count */ -#define PSB_D_HV (1 << 4) -#define PSB_D_DBI_BF (1 << 5) -#define PSB_D_PM (1 << 6) -#define PSB_D_RENDER (1 << 7) -#define PSB_D_REG (1 << 8) -#define PSB_D_MSVDX (1 << 9) -#define PSB_D_TOPAZ (1 << 10)
-extern int drm_idle_check_interval;
- /* Utilities */
-static inline u32 MRST_MSG_READ32(int domain, uint port, uint offset) -{
int mcr = (0xD0<<24) | (port << 16) | (offset << 8);uint32_t ret_val = 0;struct pci_dev *pci_root = pci_get_domain_bus_and_slot(domain, 0, 0);pci_write_config_dword(pci_root, 0xD0, mcr);pci_read_config_dword(pci_root, 0xD4, &ret_val);pci_dev_put(pci_root);return ret_val;-} -static inline void MRST_MSG_WRITE32(int domain, uint port, uint offset,
u32 value)-{
int mcr = (0xE0<<24) | (port << 16) | (offset << 8) | 0xF0;struct pci_dev *pci_root = pci_get_domain_bus_and_slot(domain, 0, 0);pci_write_config_dword(pci_root, 0xD4, value);pci_write_config_dword(pci_root, 0xD0, mcr);pci_dev_put(pci_root);-}
- static inline uint32_t REGISTER_READ(struct drm_device *dev, uint32_t reg) { struct drm_psb_private *dev_priv = to_drm_psb_private(dev);
@@ -806,24 +748,9 @@ static inline void REGISTER_WRITE8(struct drm_device *dev, #define PSB_WVDC32(_val, _offs) iowrite32(_val, dev_priv->vdc_reg + (_offs)) #define PSB_RVDC32(_offs) ioread32(dev_priv->vdc_reg + (_offs))
-/* #define TRAP_SGX_PM_FAULT 1 */ -#ifdef TRAP_SGX_PM_FAULT -#define PSB_RSGX32(_offs) \ -({ \
if (inl(dev_priv->apm_base + PSB_APM_STS) & 0x3) { \pr_err("access sgx when it's off!! (READ) %s, %d\n", \__FILE__, __LINE__); \melay(1000); \} \ioread32(dev_priv->sgx_reg + (_offs)); \-}) -#else #define PSB_RSGX32(_offs) ioread32(dev_priv->sgx_reg + (_offs)) -#endif #define PSB_WSGX32(_val, _offs) iowrite32(_val, dev_priv->sgx_reg + (_offs))
-#define MSVDX_REG_DUMP 0
- #define PSB_WMSVDX32(_val, _offs) iowrite32(_val, dev_priv->msvdx_reg + (_offs)) #define PSB_RMSVDX32(_offs) ioread32(dev_priv->msvdx_reg + (_offs))
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev
Hi Patrik,
I love your patch! Perhaps something to improve:
[auto build test WARNING on drm/drm-next] [also build test WARNING on drm-intel/for-linux-next drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.17-rc8 next-20220317] [cannot apply to airlied/drm-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Patrik-Jakobsson/drm-gma500-Remove-... base: git://anongit.freedesktop.org/drm/drm drm-next config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20220318/202203180409.kj2q4cgM-lkp@i...) compiler: gcc-9 (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/0d50efabcb4ad52bd7a036e2542dbf51bbcf... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Patrik-Jakobsson/drm-gma500-Remove-unused-declarations-and-other-cruft/20220317-172741 git checkout 0d50efabcb4ad52bd7a036e2542dbf51bbcf93b4 # save the config file to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/drm/gma500/
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot lkp@intel.com
All warnings (new ones prefixed by >>):
drivers/gpu/drm/gma500/psb_drv.c:102:6: warning: no previous prototype for 'psb_spank' [-Wmissing-prototypes]
102 | void psb_spank(struct drm_psb_private *dev_priv) | ^~~~~~~~~
vim +/psb_spank +102 drivers/gpu/drm/gma500/psb_drv.c
5c49fd3aa0ab02 Alan Cox 2011-11-03 95 5c209d8056b976 Patrik Jakobsson 2021-02-01 96 /** 5c209d8056b976 Patrik Jakobsson 2021-02-01 97 * psb_spank - reset the 2D engine 5c209d8056b976 Patrik Jakobsson 2021-02-01 98 * @dev_priv: our PSB DRM device 5c209d8056b976 Patrik Jakobsson 2021-02-01 99 * 5c209d8056b976 Patrik Jakobsson 2021-02-01 100 * Soft reset the graphics engine and then reload the necessary registers. 5c209d8056b976 Patrik Jakobsson 2021-02-01 101 */ 5c209d8056b976 Patrik Jakobsson 2021-02-01 @102 void psb_spank(struct drm_psb_private *dev_priv) 5c209d8056b976 Patrik Jakobsson 2021-02-01 103 { 5c209d8056b976 Patrik Jakobsson 2021-02-01 104 PSB_WSGX32(_PSB_CS_RESET_BIF_RESET | _PSB_CS_RESET_DPM_RESET | 5c209d8056b976 Patrik Jakobsson 2021-02-01 105 _PSB_CS_RESET_TA_RESET | _PSB_CS_RESET_USE_RESET | 5c209d8056b976 Patrik Jakobsson 2021-02-01 106 _PSB_CS_RESET_ISP_RESET | _PSB_CS_RESET_TSP_RESET | 5c209d8056b976 Patrik Jakobsson 2021-02-01 107 _PSB_CS_RESET_TWOD_RESET, PSB_CR_SOFT_RESET); 5c209d8056b976 Patrik Jakobsson 2021-02-01 108 PSB_RSGX32(PSB_CR_SOFT_RESET); 5c209d8056b976 Patrik Jakobsson 2021-02-01 109 5c209d8056b976 Patrik Jakobsson 2021-02-01 110 msleep(1); 5c209d8056b976 Patrik Jakobsson 2021-02-01 111 5c209d8056b976 Patrik Jakobsson 2021-02-01 112 PSB_WSGX32(0, PSB_CR_SOFT_RESET); 5c209d8056b976 Patrik Jakobsson 2021-02-01 113 wmb(); 5c209d8056b976 Patrik Jakobsson 2021-02-01 114 PSB_WSGX32(PSB_RSGX32(PSB_CR_BIF_CTRL) | _PSB_CB_CTRL_CLEAR_FAULT, 5c209d8056b976 Patrik Jakobsson 2021-02-01 115 PSB_CR_BIF_CTRL); 5c209d8056b976 Patrik Jakobsson 2021-02-01 116 wmb(); 5c209d8056b976 Patrik Jakobsson 2021-02-01 117 (void) PSB_RSGX32(PSB_CR_BIF_CTRL); 5c209d8056b976 Patrik Jakobsson 2021-02-01 118 5c209d8056b976 Patrik Jakobsson 2021-02-01 119 msleep(1); 5c209d8056b976 Patrik Jakobsson 2021-02-01 120 PSB_WSGX32(PSB_RSGX32(PSB_CR_BIF_CTRL) & ~_PSB_CB_CTRL_CLEAR_FAULT, 5c209d8056b976 Patrik Jakobsson 2021-02-01 121 PSB_CR_BIF_CTRL); 5c209d8056b976 Patrik Jakobsson 2021-02-01 122 (void) PSB_RSGX32(PSB_CR_BIF_CTRL); 5c209d8056b976 Patrik Jakobsson 2021-02-01 123 PSB_WSGX32(dev_priv->gtt.gatt_start, PSB_CR_BIF_TWOD_REQ_BASE); 5c209d8056b976 Patrik Jakobsson 2021-02-01 124 } 5c209d8056b976 Patrik Jakobsson 2021-02-01 125
--- 0-DAY CI Kernel Test Service https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Hi Patrik,
I love your patch! Perhaps something to improve:
[auto build test WARNING on drm/drm-next] [also build test WARNING on drm-intel/for-linux-next drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.17-rc8 next-20220317] [cannot apply to airlied/drm-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Patrik-Jakobsson/drm-gma500-Remove-... base: git://anongit.freedesktop.org/drm/drm drm-next config: i386-randconfig-a011 (https://download.01.org/0day-ci/archive/20220318/202203180538.gWcM5ABA-lkp@i...) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project a6ec1e3d798f8eab43fb3a91028c6ab04e115fcb) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/0d50efabcb4ad52bd7a036e2542dbf51bbcf... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Patrik-Jakobsson/drm-gma500-Remove-unused-declarations-and-other-cruft/20220317-172741 git checkout 0d50efabcb4ad52bd7a036e2542dbf51bbcf93b4 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/drm/gma500/
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot lkp@intel.com
All warnings (new ones prefixed by >>):
drivers/gpu/drm/gma500/psb_drv.c:102:6: warning: no previous prototype for function 'psb_spank' [-Wmissing-prototypes]
void psb_spank(struct drm_psb_private *dev_priv) ^ drivers/gpu/drm/gma500/psb_drv.c:102:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void psb_spank(struct drm_psb_private *dev_priv) ^ static drivers/gpu/drm/gma500/psb_drv.c:419:20: warning: unused function 'get_brightness' [-Wunused-function] static inline void get_brightness(struct backlight_device *bd) ^ 2 warnings generated.
vim +/psb_spank +102 drivers/gpu/drm/gma500/psb_drv.c
5c49fd3aa0ab02 Alan Cox 2011-11-03 95 5c209d8056b976 Patrik Jakobsson 2021-02-01 96 /** 5c209d8056b976 Patrik Jakobsson 2021-02-01 97 * psb_spank - reset the 2D engine 5c209d8056b976 Patrik Jakobsson 2021-02-01 98 * @dev_priv: our PSB DRM device 5c209d8056b976 Patrik Jakobsson 2021-02-01 99 * 5c209d8056b976 Patrik Jakobsson 2021-02-01 100 * Soft reset the graphics engine and then reload the necessary registers. 5c209d8056b976 Patrik Jakobsson 2021-02-01 101 */ 5c209d8056b976 Patrik Jakobsson 2021-02-01 @102 void psb_spank(struct drm_psb_private *dev_priv) 5c209d8056b976 Patrik Jakobsson 2021-02-01 103 { 5c209d8056b976 Patrik Jakobsson 2021-02-01 104 PSB_WSGX32(_PSB_CS_RESET_BIF_RESET | _PSB_CS_RESET_DPM_RESET | 5c209d8056b976 Patrik Jakobsson 2021-02-01 105 _PSB_CS_RESET_TA_RESET | _PSB_CS_RESET_USE_RESET | 5c209d8056b976 Patrik Jakobsson 2021-02-01 106 _PSB_CS_RESET_ISP_RESET | _PSB_CS_RESET_TSP_RESET | 5c209d8056b976 Patrik Jakobsson 2021-02-01 107 _PSB_CS_RESET_TWOD_RESET, PSB_CR_SOFT_RESET); 5c209d8056b976 Patrik Jakobsson 2021-02-01 108 PSB_RSGX32(PSB_CR_SOFT_RESET); 5c209d8056b976 Patrik Jakobsson 2021-02-01 109 5c209d8056b976 Patrik Jakobsson 2021-02-01 110 msleep(1); 5c209d8056b976 Patrik Jakobsson 2021-02-01 111 5c209d8056b976 Patrik Jakobsson 2021-02-01 112 PSB_WSGX32(0, PSB_CR_SOFT_RESET); 5c209d8056b976 Patrik Jakobsson 2021-02-01 113 wmb(); 5c209d8056b976 Patrik Jakobsson 2021-02-01 114 PSB_WSGX32(PSB_RSGX32(PSB_CR_BIF_CTRL) | _PSB_CB_CTRL_CLEAR_FAULT, 5c209d8056b976 Patrik Jakobsson 2021-02-01 115 PSB_CR_BIF_CTRL); 5c209d8056b976 Patrik Jakobsson 2021-02-01 116 wmb(); 5c209d8056b976 Patrik Jakobsson 2021-02-01 117 (void) PSB_RSGX32(PSB_CR_BIF_CTRL); 5c209d8056b976 Patrik Jakobsson 2021-02-01 118 5c209d8056b976 Patrik Jakobsson 2021-02-01 119 msleep(1); 5c209d8056b976 Patrik Jakobsson 2021-02-01 120 PSB_WSGX32(PSB_RSGX32(PSB_CR_BIF_CTRL) & ~_PSB_CB_CTRL_CLEAR_FAULT, 5c209d8056b976 Patrik Jakobsson 2021-02-01 121 PSB_CR_BIF_CTRL); 5c209d8056b976 Patrik Jakobsson 2021-02-01 122 (void) PSB_RSGX32(PSB_CR_BIF_CTRL); 5c209d8056b976 Patrik Jakobsson 2021-02-01 123 PSB_WSGX32(dev_priv->gtt.gatt_start, PSB_CR_BIF_TWOD_REQ_BASE); 5c209d8056b976 Patrik Jakobsson 2021-02-01 124 } 5c209d8056b976 Patrik Jakobsson 2021-02-01 125
--- 0-DAY CI Kernel Test Service https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
drivers/gpu/drm/gma500/psb_drv.c:102:6: warning: symbol 'psb_spank' was not declared. Should it be static?
Reported-by: kernel test robot lkp@intel.com Signed-off-by: kernel test robot lkp@intel.com --- drivers/gpu/drm/gma500/psb_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c index eeb681be9c955..e400b284ffd48 100644 --- a/drivers/gpu/drm/gma500/psb_drv.c +++ b/drivers/gpu/drm/gma500/psb_drv.c @@ -99,7 +99,7 @@ static const struct drm_ioctl_desc psb_ioctls[] = { * * Soft reset the graphics engine and then reload the necessary registers. */ -void psb_spank(struct drm_psb_private *dev_priv) +static void psb_spank(struct drm_psb_private *dev_priv) { PSB_WSGX32(_PSB_CS_RESET_BIF_RESET | _PSB_CS_RESET_DPM_RESET | _PSB_CS_RESET_TA_RESET | _PSB_CS_RESET_USE_RESET |
Hi Patrik,
I love your patch! Perhaps something to improve:
[auto build test WARNING on drm/drm-next] [also build test WARNING on drm-intel/for-linux-next drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.17-rc8 next-20220317] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Patrik-Jakobsson/drm-gma500-Remove-... base: git://anongit.freedesktop.org/drm/drm drm-next config: i386-randconfig-s002 (https://download.01.org/0day-ci/archive/20220318/202203180839.vNEFesvz-lkp@i...) compiler: gcc-9 (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0 reproduce: # apt-get install sparse # sparse version: v0.6.4-dirty # https://github.com/0day-ci/linux/commit/0d50efabcb4ad52bd7a036e2542dbf51bbcf... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Patrik-Jakobsson/drm-gma500-Remove-unused-declarations-and-other-cruft/20220317-172741 git checkout 0d50efabcb4ad52bd7a036e2542dbf51bbcf93b4 # save the config file to linux build tree mkdir build_dir make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/drm/gma500/
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot lkp@intel.com
sparse warnings: (new ones prefixed by >>)
drivers/gpu/drm/gma500/psb_drv.c:102:6: sparse: sparse: symbol 'psb_spank' was not declared. Should it be static?
Please review and possibly fold the followup patch.
--- 0-DAY CI Kernel Test Service https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
dri-devel@lists.freedesktop.org
-
kernel test robot -
Patrik Jakobsson -
Sam Ravnborg -
Thomas Zimmermann