Add support of generic DT binding for annoucing RTS/CTS lines. The initial binding 'st,hw-flow-control' is not needed anymore since generic binding is available, but is kept for backward compatibility.
Erwan Le Ray (2): dt-bindings: serial: add generic DT binding for announcing RTS/CTS lines serial: stm32: Use generic DT binding for announcing RTS/CTS lines
Documentation/devicetree/bindings/serial/st,stm32-uart.yaml | 4 +++- drivers/tty/serial/stm32-usart.c | 5 +++-- 2 files changed, 6 insertions(+), 3 deletions(-)
Add support of generic DT binding for annoucing RTS/CTS lines. The initial binding 'st,hw-flow-control' is not needed anymore since generic binding is available, but is kept for backward compatibility.
Signed-off-by: Erwan Le Ray erwan.leray@st.com
diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml index 75b8521eb7cb..06d5f251ec88 100644 --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml @@ -35,9 +35,11 @@ properties: description: label associated with this uart
st,hw-flow-ctrl: - description: enable hardware flow control + description: enable hardware flow control (deprecated) $ref: /schemas/types.yaml#/definitions/flag
+ uart-has-rtscts: true + dmas: minItems: 1 maxItems: 2
On Wed, May 20, 2020 at 03:39:31PM +0200, Erwan Le Ray wrote:
Add support of generic DT binding for annoucing RTS/CTS lines. The initial binding 'st,hw-flow-control' is not needed anymore since generic binding is available, but is kept for backward compatibility.
Signed-off-by: Erwan Le Ray erwan.leray@st.com
diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml index 75b8521eb7cb..06d5f251ec88 100644 --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml @@ -35,9 +35,11 @@ properties: description: label associated with this uart
st,hw-flow-ctrl:
- description: enable hardware flow control
description: enable hardware flow control (deprecated) $ref: /schemas/types.yaml#/definitions/flag
uart-has-rtscts: true
dmas: minItems: 1 maxItems: 2
-- 2.17.1
Did this get ignored by the DT maintainers? :(
On 6/27/20 4:18 PM, Greg Kroah-Hartman wrote:
On Wed, May 20, 2020 at 03:39:31PM +0200, Erwan Le Ray wrote:
Add support of generic DT binding for annoucing RTS/CTS lines. The initial binding 'st,hw-flow-control' is not needed anymore since generic binding is available, but is kept for backward compatibility.
Signed-off-by: Erwan Le Ray erwan.leray@st.com
diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml index 75b8521eb7cb..06d5f251ec88 100644 --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml @@ -35,9 +35,11 @@ properties: description: label associated with this uart
st,hw-flow-ctrl:
- description: enable hardware flow control
description: enable hardware flow control (deprecated) $ref: /schemas/types.yaml#/definitions/flag
uart-has-rtscts: true
dmas: minItems: 1 maxItems: 2
-- 2.17.1
Did this get ignored by the DT maintainers? :(
Hi Rob,
Gentle reminder. Could you please provide your feedback on this patch ?
Best Regards, Erwan.
On Sat, Jun 27, 2020 at 8:18 AM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
On Wed, May 20, 2020 at 03:39:31PM +0200, Erwan Le Ray wrote:
Add support of generic DT binding for annoucing RTS/CTS lines. The initial binding 'st,hw-flow-control' is not needed anymore since generic binding is available, but is kept for backward compatibility.
Signed-off-by: Erwan Le Ray erwan.leray@st.com
diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml index 75b8521eb7cb..06d5f251ec88 100644 --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml @@ -35,9 +35,11 @@ properties: description: label associated with this uart
st,hw-flow-ctrl:
- description: enable hardware flow control
description: enable hardware flow control (deprecated) $ref: /schemas/types.yaml#/definitions/flag
uart-has-rtscts: true
dmas: minItems: 1 maxItems: 2
-- 2.17.1
Did this get ignored by the DT maintainers? :(
When it doesn't go to the DT list, you are playing roulette whether I happen to see it. :(
Anyways,
Reviewed-by: Rob Herring robh@kernel.org
Add support of generic DT binding for annoucing RTS/CTS lines. The initial binding 'st,hw-flow-control' is not needed anymore since generic binding is available, but is kept for backward compatibility.
Signed-off-by: Erwan Le Ray erwan.leray@st.com
diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c index 17c2f3276888..9cfcf355567a 100644 --- a/drivers/tty/serial/stm32-usart.c +++ b/drivers/tty/serial/stm32-usart.c @@ -1033,8 +1033,9 @@ static struct stm32_port *stm32_of_get_stm32_port(struct platform_device *pdev) if (WARN_ON(id >= STM32_MAX_PORTS)) return NULL;
- stm32_ports[id].hw_flow_control = of_property_read_bool(np, - "st,hw-flow-ctrl"); + stm32_ports[id].hw_flow_control = + of_property_read_bool (np, "st,hw-flow-ctrl") /*deprecated*/ || + of_property_read_bool (np, "uart-has-rtscts"); stm32_ports[id].port.line = id; stm32_ports[id].cr1_irq = USART_CR1_RXNEIE; stm32_ports[id].cr3_irq = 0;
dri-devel@lists.freedesktop.org
-
Erwan Le Ray -
Erwan LE RAY
-
Greg Kroah-Hartman -
Rob Herring