The model and make of the LCD panel of the Vivax TPC-9150 is unknown, hence the panel settings that were retrieved with a FEX dump are named after the device NOT the actual panel.
The LCD in question is a 50 pin MISO TFT LCD panel of the resolution 1024x600 used by the aforementioned device.
Signed-off-by: Nikola Pavlica pavlica.nikola@gmail.com --- drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 4e2dad314c79..97fc3c5740bb 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -4090,6 +4090,29 @@ static const struct panel_desc arm_rtsm = { .bus_format = MEDIA_BUS_FMT_RGB888_1X24, };
+static const struct drm_display_mode vivax_tpc9150_panel_mode = { + .clock = 60000, + .hdisplay = 1024, + .hsync_start = 1024 + 160, + .hsync_end = 1024 + 160 + 100, + .htotal = 1024 + 160 + 100 + 60, + .vdisplay = 600, + .vsync_start = 600 + 12, + .vsync_end = 600 + 12 + 10, + .vtotal = 600 + 12 + 10 + 13, +}; + +static const struct panel_desc vivax_tpc9150_panel = { + .modes = &vivax_tpc9150_panel_mode, + .num_modes = 1, + .size = { + .width = 223, + .height = 125, + }, + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, + .bus_flags = DRM_BUS_FLAG_DE_HIGH, +}; + static const struct of_device_id platform_of_match[] = { { .compatible = "ampire,am-1280800n3tzqw-t00h", @@ -4103,6 +4126,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "arm,rtsm-display", .data = &arm_rtsm, + }, { + .compatible = "vivax,tpc9150-panel", + .data = &vivax_tpc9150_panel, }, { .compatible = "armadeus,st0700-adapt", .data = &armadeus_st0700_adapt,
On Tue, Aug 17, 2021 at 10:32:01AM +0200, Nikola Pavlica wrote:
The model and make of the LCD panel of the Vivax TPC-9150 is unknown, hence the panel settings that were retrieved with a FEX dump are named after the device NOT the actual panel.
The LCD in question is a 50 pin MISO TFT LCD panel of the resolution 1024x600 used by the aforementioned device.
Signed-off-by: Nikola Pavlica pavlica.nikola@gmail.com
drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 4e2dad314c79..97fc3c5740bb 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -4090,6 +4090,29 @@ static const struct panel_desc arm_rtsm = { .bus_format = MEDIA_BUS_FMT_RGB888_1X24, };
+static const struct drm_display_mode vivax_tpc9150_panel_mode = {
- .clock = 60000,
- .hdisplay = 1024,
- .hsync_start = 1024 + 160,
- .hsync_end = 1024 + 160 + 100,
- .htotal = 1024 + 160 + 100 + 60,
- .vdisplay = 600,
- .vsync_start = 600 + 12,
- .vsync_end = 600 + 12 + 10,
- .vtotal = 600 + 12 + 10 + 13,
+};
+static const struct panel_desc vivax_tpc9150_panel = {
- .modes = &vivax_tpc9150_panel_mode,
- .num_modes = 1,
- .size = {
.width = 223,.height = 125,- },
- .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
- .bus_flags = DRM_BUS_FLAG_DE_HIGH,
+};
These were originally supposed to be alphabetically ordered by compatible string, though it looks like at least the data structures for ARM RTSM weren't properly ordered.
Perhaps you can prepend a patch correcting that order and then make sure your patch keeps the alphabetical ordering, too?
static const struct of_device_id platform_of_match[] = { { .compatible = "ampire,am-1280800n3tzqw-t00h", @@ -4103,6 +4126,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "arm,rtsm-display", .data = &arm_rtsm,
- }, {
.compatible = "vivax,tpc9150-panel",.data = &vivax_tpc9150_panel,
Also make sure to keep the alphabetical order here.
Thierry
Hi Nikola,
see a few comments in the following.
On Tue, Aug 17, 2021 at 10:32:01AM +0200, Nikola Pavlica wrote:
The model and make of the LCD panel of the Vivax TPC-9150 is unknown, hence the panel settings that were retrieved with a FEX dump are named after the device NOT the actual panel.
The LCD in question is a 50 pin MISO TFT LCD panel of the resolution 1024x600 used by the aforementioned device.
Signed-off-by: Nikola Pavlica pavlica.nikola@gmail.com
drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 4e2dad314c79..97fc3c5740bb 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -4090,6 +4090,29 @@ static const struct panel_desc arm_rtsm = { .bus_format = MEDIA_BUS_FMT_RGB888_1X24, };
+static const struct drm_display_mode vivax_tpc9150_panel_mode = {
- .clock = 60000,
- .hdisplay = 1024,
- .hsync_start = 1024 + 160,
- .hsync_end = 1024 + 160 + 100,
- .htotal = 1024 + 160 + 100 + 60,
- .vdisplay = 600,
- .vsync_start = 600 + 12,
- .vsync_end = 600 + 12 + 10,
- .vtotal = 600 + 12 + 10 + 13,
+};
.flags?
+static const struct panel_desc vivax_tpc9150_panel = {
- .modes = &vivax_tpc9150_panel_mode,
- .num_modes = 1,
- .size = {
.width = 223,.height = 125,- },
- .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
- .bus_flags = DRM_BUS_FLAG_DE_HIGH,
+};
Specifying .connector_type is mandatory today. Please specify .bpc too.
Consider if .bus_flags cover it all, they can be a little tricky to add them all. And many many displays have failed to do so.
I hope to see a new version soon with these comments and also the comments from Thierry fixed.
Sam
static const struct of_device_id platform_of_match[] = { { .compatible = "ampire,am-1280800n3tzqw-t00h", @@ -4103,6 +4126,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "arm,rtsm-display", .data = &arm_rtsm,
- }, {
.compatible = "vivax,tpc9150-panel",.data = &vivax_tpc9150_panel,-- 2.32.0
dri-devel@lists.freedesktop.org
-
Nikola Pavlica -
Sam Ravnborg -
Thierry Reding