Date: Wed, 8 Aug 2012 23:12:19 +0200
Connecting an ASUS VW222S [1] over VGA a garbled screen is shown with vertical stripes in the top half.
In commit bc42aabc [2]
commit bc42aabc6a01b92b0f961d65671564e0e1cd7592 Author: Adam Jackson ajax@redhat.com Date: Wed May 23 16:26:54 2012 -0400
drm/edid/quirks: ViewSonic VA2026w
Adam Jackson added the quirk `EDID_QUIRK_FORCE_REDUCED_BLANKING` which is also needed for this ASUS monitor.
All log files and output from `xrandr` is included in the referenced Bugzilla report #17629.
[1] http://www.asus.com/Display/LCD_Monitors/VW222S/ [2] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=bc42...
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=17629 Signed-off-by: Paul Menzel paulepanter@users.sourceforge.net Cc: dri-devel@lists.freedesktop.org Cc: Adam Jackson ajax@redhat.com Cc: Ian Pilcher arequipeno@gmail.com Cc: stable@vger.kernel.org --- Same comment as in previous patch.
Ian, I did not base this patch on your series, to make it easier to get back ported. I can easily rebase it though, so hopefully some maintainer can tell me what to do. --- drivers/gpu/drm/drm_edid.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 75e252e..102346d 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -87,6 +87,9 @@ static struct edid_quirk { int product_id; u32 quirks; } edid_quirk_list[] = { + /* ASUS VW222S */ + { "ACI", 22a2, EDID_QUIRK_FORCE_REDUCED_BLANKING }, + /* Acer AL1706 */ { "ACR", 44358, EDID_QUIRK_PREFER_LARGE_60 }, /* Acer F51 */
Date: Wed, 8 Aug 2012 23:12:19 +0200 Subject: [PATCH v2] drm: Add EDID_QUIRK_FORCE_REDUCED_BLANKING for ASUS VW222S
Connecting an ASUS VW222S [1] over VGA a garbled screen is shown with vertical stripes in the top half.
In commit bc42aabc [2]
commit bc42aabc6a01b92b0f961d65671564e0e1cd7592 Author: Adam Jackson ajax@redhat.com Date: Wed May 23 16:26:54 2012 -0400
drm/edid/quirks: ViewSonic VA2026w
Adam Jackson added the quirk `EDID_QUIRK_FORCE_REDUCED_BLANKING` which is also needed for this ASUS monitor.
All log files and output from `xrandr` is included in the referenced Bugzilla report #17629.
Please note that this monitor only has a VGA (D-Sub) connector [1].
[1] http://www.asus.com/Display/LCD_Monitors/VW222S/ [2] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=bc42...
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=17629 Signed-off-by: Paul Menzel paulepanter@users.sourceforge.net Cc: dri-devel@lists.freedesktop.org Cc: Adam Jackson ajax@redhat.com Cc: Ian Pilcher arequipeno@gmail.com Cc: stable@vger.kernel.org --- v2: • Prepend model number with 0x to fix compilation. • Update commit message to mention that there is only a VGA connector.
Same comment as in previous patch.
Ian, I did not base this patch on your series, to make it easier to get back ported. I can easily rebase it though, so hopefully some maintainer can tell me what to do. --- drivers/gpu/drm/drm_edid.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 75e252e..4befc7f 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -87,6 +87,9 @@ static struct edid_quirk { int product_id; u32 quirks; } edid_quirk_list[] = { + /* ASUS VW222S */ + { "ACI", 0x22a2, EDID_QUIRK_FORCE_REDUCED_BLANKING }, + /* Acer AL1706 */ { "ACR", 44358, EDID_QUIRK_PREFER_LARGE_60 }, /* Acer F51 */
Hi all!
On Wed, 15 Aug 2012 17:40:40 +0200 Paul Menzel paulepanter@users.sourceforge.net wrote:
Date: Wed, 8 Aug 2012 23:12:19 +0200
Connecting an ASUS VW222S [1] over VGA a garbled screen is shown with vertical stripes in the top half.
This patch, which was merged in v3.6-rc4, makes the image on my ASUS VW222U ca. 1 inch too wide left/right and top/bottom. The effect is as if the image was zoomed (bigger, more pixely).
Reverting it fixes the problem.
The Monitor is connected via VGA, but also has a DVI interface.
Maybe the quirk-apply criteria is too unspecific?
Regards, Flo
drivers/gpu/drm/drm_edid.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 75e252e..102346d 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -87,6 +87,9 @@ static struct edid_quirk { int product_id; u32 quirks; } edid_quirk_list[] = {
- /* ASUS VW222S */
- { "ACI", 22a2, EDID_QUIRK_FORCE_REDUCED_BLANKING },
- /* Acer AL1706 */ { "ACR", 44358, EDID_QUIRK_PREFER_LARGE_60 }, /* Acer F51 */
Dear Florian,
Am Dienstag, den 18.12.2012, 21:03 +0100 schrieb Florian Mickler:
On Wed, 15 Aug 2012 17:40:40 +0200 Paul Menzel wrote:
Date: Wed, 8 Aug 2012 23:12:19 +0200
Connecting an ASUS VW222S [1] over VGA a garbled screen is shown with vertical stripes in the top half.
This patch, which was merged in v3.6-rc4, makes the image on my ASUS VW222U ca. 1 inch too wide left/right and top/bottom. The effect is as if the image was zoomed (bigger, more pixely).
Reverting it fixes the problem.
I am sorry for the trouble caused by this. As a work around, you could also specify the QUIRKS on the Linux command line.
The Monitor is connected via VGA, but also has a DVI interface.
Maybe the quirk-apply criteria is too unspecific?
Hmm, I guess everything is identical but the DVI connector they added to the VW222U. Though I should have noticed the effect on the VW222S and did not. :(
Could you please send the `edid-decode` output on your system and `/var/log/Xorg.0.log`.
Also I wonder how this quirk could create such a behavior.
Thanks,
Paul
On 12/18/2012 04:33 PM, Paul Menzel wrote:
I am sorry for the trouble caused by this. As a work around, you could also specify the QUIRKS on the Linux command line.
Those patches never made it in. I gave up when I was asked to rewrite everything without using unions.
On Tue, 18 Dec 2012 23:33:20 +0100 Paul Menzel paulepanter@users.sourceforge.net wrote:
Dear Florian,
Am Dienstag, den 18.12.2012, 21:03 +0100 schrieb Florian Mickler:
On Wed, 15 Aug 2012 17:40:40 +0200 Paul Menzel wrote:
Date: Wed, 8 Aug 2012 23:12:19 +0200
Connecting an ASUS VW222S [1] over VGA a garbled screen is shown with vertical stripes in the top half.
This patch, which was merged in v3.6-rc4, makes the image on my ASUS VW222U ca. 1 inch too wide left/right and top/bottom. The effect is as if the image was zoomed (bigger, more pixely).
Reverting it fixes the problem.
I am sorry for the trouble caused by this. As a work around, you could also specify the QUIRKS on the Linux command line.
The Monitor is connected via VGA, but also has a DVI interface.
Maybe the quirk-apply criteria is too unspecific?
Hmm, I guess everything is identical but the DVI connector they added to the VW222U. Though I should have noticed the effect on the VW222S and did not. :(
Hm.. why should you have noticed the effect on the VW222S? Does it happen there too?
Could you please send the `edid-decode` output on your system and `/var/log/Xorg.0.log`.
I attached the xrandr --verbose output and the # get-edid | parse-edid output from http://www.polypux.org/projects/read-edid/ which I already had installed. Hope this works for you too.
Also I wonder how this quirk could create such a behavior.
Yes. I'm not shure how this could happen. It probably is either a bug somewhere, or it is the 'natural' effect of misconfiguring the vga pipeline. Maybe someone more knowledgeable than me could make a more educated guess about this.
Dear Florian,
Am Freitag, den 21.12.2012, 14:52 +0100 schrieb Florian Mickler:
On Tue, 18 Dec 2012 23:33:20 +0100 Paul Menzel paulepanter@users.sourceforge.net wrote:
Am Dienstag, den 18.12.2012, 21:03 +0100 schrieb Florian Mickler:
On Wed, 15 Aug 2012 17:40:40 +0200 Paul Menzel wrote:
Date: Wed, 8 Aug 2012 23:12:19 +0200
Connecting an ASUS VW222S [1] over VGA a garbled screen is shown with vertical stripes in the top half.
This patch, which was merged in v3.6-rc4, makes the image on my ASUS VW222U ca. 1 inch too wide left/right and top/bottom. The effect is as if the image was zoomed (bigger, more pixely).
Reverting it fixes the problem.
I am sorry for the trouble caused by this. As a work around, you could also specify the QUIRKS on the Linux command line.
The Monitor is connected via VGA, but also has a DVI interface.
Maybe the quirk-apply criteria is too unspecific?
Hmm, I guess everything is identical but the DVI connector they added to the VW222U. Though I should have noticed the effect on the VW222S and did not. :(
Hm.. why should you have noticed the effect on the VW222S? Does it happen there too?
No, it did not happen there with an Intel 915GM chip. Could you please send the `Xorg.0.log`, so that we see what you use. Maybe also a dmesg output with `dri.debug=6`.
Could you please send the `edid-decode` output on your system and `/var/log/Xorg.0.log`.
I attached the xrandr --verbose output and the # get-edid | parse-edid output from http://www.polypux.org/projects/read-edid/ which I already had installed. Hope this works for you too.
Also I wonder how this quirk could create such a behavior.
Yes. I'm not shure how this could happen. It probably is either a bug somewhere, or it is the 'natural' effect of misconfiguring the vga pipeline. Maybe someone more knowledgeable than me could make a more educated guess about this.
What should be done about this? Revert this until the reason for the regression is figured out or fix the regression? For the second option, Florian could you please create a new ticket?
Thanks,
Paul
Dear Paul,
do you have a quick pointer to your decoded EDID? Maybe we can tell the VW222S and the VW222U apart. Then a small hack to the quirk-code should do the trick.
Else, I'm afraid the right thing to do is to revert the quirk.
I will provide the log files as soon as I'm back with that monitor, which should be next year... (Means tomorrow or the day after)
Regards, Flo
On Mon, 31 Dec 2012 17:37:24 +0100 Paul Menzel paulepanter@users.sourceforge.net wrote:
Dear Florian,
Am Freitag, den 21.12.2012, 14:52 +0100 schrieb Florian Mickler:
On Tue, 18 Dec 2012 23:33:20 +0100 Paul Menzel paulepanter@users.sourceforge.net wrote:
Am Dienstag, den 18.12.2012, 21:03 +0100 schrieb Florian Mickler:
On Wed, 15 Aug 2012 17:40:40 +0200 Paul Menzel wrote:
Date: Wed, 8 Aug 2012 23:12:19 +0200
Connecting an ASUS VW222S [1] over VGA a garbled screen is shown with vertical stripes in the top half.
This patch, which was merged in v3.6-rc4, makes the image on my ASUS VW222U ca. 1 inch too wide left/right and top/bottom. The effect is as if the image was zoomed (bigger, more pixely).
Reverting it fixes the problem.
I am sorry for the trouble caused by this. As a work around, you could also specify the QUIRKS on the Linux command line.
The Monitor is connected via VGA, but also has a DVI interface.
Maybe the quirk-apply criteria is too unspecific?
Hmm, I guess everything is identical but the DVI connector they added to the VW222U. Though I should have noticed the effect on the VW222S and did not. :(
Hm.. why should you have noticed the effect on the VW222S? Does it happen there too?
No, it did not happen there with an Intel 915GM chip. Could you please send the `Xorg.0.log`, so that we see what you use. Maybe also a dmesg output with `dri.debug=6`.
Could you please send the `edid-decode` output on your system and `/var/log/Xorg.0.log`.
I attached the xrandr --verbose output and the # get-edid | parse-edid output from http://www.polypux.org/projects/read-edid/ which I already had installed. Hope this works for you too.
Also I wonder how this quirk could create such a behavior.
Yes. I'm not shure how this could happen. It probably is either a bug somewhere, or it is the 'natural' effect of misconfiguring the vga pipeline. Maybe someone more knowledgeable than me could make a more educated guess about this.
What should be done about this? Revert this until the reason for the regression is figured out or fix the regression? For the second option, Florian could you please create a new ticket?
Thanks,
Paul
Dear Florian,
first, I wish everyone a Happy New Year!
Am Montag, den 31.12.2012, 18:22 +0100 schrieb Florian Mickler:
do you have a quick pointer to your decoded EDID?
yes, everything is in the bug report the patch was supposed to fix [1].
Maybe we can tell the VW222S and the VW222U apart. Then a small hack to the quirk-code should do the trick.
The EDID luckily is different.
$ diff -u asus-vw222s.edid asus-vw222u.edid --- asus-vw222s.edid 2012-08-15 17:22:32.172213340 +0200 +++ asus-vw222u.edid 2013-01-01 04:33:45.271951086 +0100 @@ -1,8 +1,8 @@ -00ffffffffffff000469a22201010101 -0c1201031e2f1e78eec4f6a3574a9c23 +00ffffffffffff000469a222a6180000 +2e1101031e2f1e78eec4f6a3574a9c23 114f54bfef00714f818081409500a940 b3000101010121399030621a274068b0 3600d9281100001c000000fd00384b1f 5111000a202020202020000000fc0056 573232320a20202020202020000000ff -0038334c4d51533037393235300a00b3 +0037424c4d51433030363331302000d1
Here the strings output by `edid-decode`.
### VW222S ###
$ ./edid-decode asus-vw222s.edid […] Manufacturer: ACI Model 22a2 Serial Number 16843009 Made week 12 of 2008 EDID version: 1.3 Analog display, Input voltage level: 0.7/0.3 V Configurable signal levels Sync: Separate Composite SyncOnGreen Maximum image size: 47 cm x 30 cm Gamma: 2.20 DPMS levels: Standby Suspend Off RGB color display Default (sRGB) color space is primary color space First detailed timing is preferred timing Established timings supported: 720x400@70Hz 640x480@60Hz 640x480@67Hz 640x480@72Hz 640x480@75Hz 800x600@56Hz 800x600@60Hz 800x600@72Hz 800x600@75Hz 832x624@75Hz 1024x768@60Hz 1024x768@70Hz 1024x768@75Hz 1280x1024@75Hz Standard timings supported: 1152x864@75Hz 1280x1024@60Hz 1280x960@60Hz 1440x900@60Hz 1600x1200@60Hz 1680x1050@60Hz Detailed mode: Clock 146.250 MHz, 473 mm x 296 mm 1680 1784 1960 2240 hborder 0 1050 1053 1059 1089 vborder 0 -hsync +vsync Monitor ranges (GTF): 56-75Hz V, 31-81kHz H, max dotclock 170MHz Monitor name: VW222 Serial number: 83LMQS079250 Checksum: 0xb3 (valid)
### VW222U ###
$ ./edid-decode asus-vw222u.edid […] Manufacturer: ACI Model 22a2 Serial Number 6310 Made week 46 of 2007 EDID version: 1.3 Analog display, Input voltage level: 0.7/0.3 V Configurable signal levels Sync: Separate Composite SyncOnGreen Maximum image size: 47 cm x 30 cm Gamma: 2.20 DPMS levels: Standby Suspend Off RGB color display Default (sRGB) color space is primary color space First detailed timing is preferred timing Established timings supported: 720x400@70Hz 640x480@60Hz 640x480@67Hz 640x480@72Hz 640x480@75Hz 800x600@56Hz 800x600@60Hz 800x600@72Hz 800x600@75Hz 832x624@75Hz 1024x768@60Hz 1024x768@70Hz 1024x768@75Hz 1280x1024@75Hz Standard timings supported: 1152x864@75Hz 1280x1024@60Hz 1280x960@60Hz 1440x900@60Hz 1600x1200@60Hz 1680x1050@60Hz Detailed mode: Clock 146.250 MHz, 473 mm x 296 mm 1680 1784 1960 2240 hborder 0 1050 1053 1059 1089 vborder 0 -hsync +vsync Monitor ranges (GTF): 56-75Hz V, 31-81kHz H, max dotclock 170MHz Monitor name: VW222 Serial number: 7BLMQC006310 Checksum: 0xd1 (valid)
So both advertise the same name and model. :(
Else, I'm afraid the right thing to do is to revert the quirk.
Yes, the no regression rule.
I will provide the log files as soon as I'm back with that monitor, which should be next year... (Means tomorrow or the day after)
Awesome. When you find out the graphics chip and you are near the monitor it would be awesome, if you could also connect a to a system with a different graphics chip so we can get an indication where the problem might be.
So if nobody has a great idea, the roadmap looks as follows. Revert the patch, find out why the graphics driver chokes on the reduced blanking (report a bug) and commit the patch again.
Thanks,
Paul
Dear Paul,
On Tue, 01 Jan 2013 04:43:39 +0100 Paul Menzel paulepanter@users.sourceforge.net wrote:
So if nobody has a great idea, the roadmap looks as follows. Revert the patch, find out why the graphics driver chokes on the reduced blanking (report a bug) and commit the patch again.
I reported a bug at: https://bugzilla.kernel.org/show_bug.cgi?id=52281
Regards, Flo
dri-devel@lists.freedesktop.org
-
Florian Mickler -
Ian Pilcher -
Paul Menzel