Hey Bernard,

Thanks for the patch.

With the below fixed, feel free to add my r-b. Reviewed-by: Robert Foss robert.foss@linaro.org

On Tue, 2 Feb 2021 at 13:09, Bernard Zhao bernard@vivo.com wrote:

Line 1590 DRM_ERROR is redundant because devm_kzalloc() already prints an error.

The line number will not be so helpful for reading this commit message in the future, so remove it and maybe just refer to DRM_ERROR being removed.

Signed-off-by: Bernard Zhao bernard@vivo.com

drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index aa1bb86293fd..8f6258eb9960 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -1586,10 +1586,8 @@ static int analogix_dp_create_bridge(struct drm_device *drm_dev, int ret;

    bridge = devm_kzalloc(drm_dev->dev, sizeof(*bridge), GFP_KERNEL);

•   if (!bridge) {
  

•           DRM_ERROR("failed to allocate for drm bridge\n");
  

•   if (!bridge)
            return -ENOMEM;
  

•   }
  
    dp->bridge = bridge;
  
  

-- 2.29.0