From: Thierry Reding treding@nvidia.com
Commit 6c87e5c3ec6d ("drm: Rename drm_connector_unplug_all() to drm_connector_unregister_all()") didn't update the Atmel HLCDC driver, causing it to fail to build. While at it, remove unnecessary locking.
Cc: Boris Brezillon boris.brezillon@free-electrons.com Cc: Alexey Brodkin Alexey.Brodkin@synopsys.com Signed-off-by: Thierry Reding treding@nvidia.com --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c index 3d8d16402d07..3cddd8d0f9e5 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c @@ -612,13 +612,6 @@ err: return ret; }
-static void atmel_hlcdc_dc_connector_unplug_all(struct drm_device *dev) -{ - mutex_lock(&dev->mode_config.mutex); - drm_connector_unplug_all(dev); - mutex_unlock(&dev->mode_config.mutex); -} - static void atmel_hlcdc_dc_lastclose(struct drm_device *dev) { struct atmel_hlcdc_dc *dc = dev->dev_private; @@ -758,7 +751,7 @@ static int atmel_hlcdc_dc_drm_remove(struct platform_device *pdev) { struct drm_device *ddev = platform_get_drvdata(pdev);
- atmel_hlcdc_dc_connector_unplug_all(ddev); + drm_connector_unregister_all(ddev); drm_dev_unregister(ddev); atmel_hlcdc_dc_unload(ddev); drm_dev_unref(ddev);
On Wed, Mar 30, 2016 at 02:24:38PM +0200, Thierry Reding wrote:
From: Thierry Reding treding@nvidia.com
Commit 6c87e5c3ec6d ("drm: Rename drm_connector_unplug_all() to drm_connector_unregister_all()") didn't update the Atmel HLCDC driver, causing it to fail to build. While at it, remove unnecessary locking.
Cc: Boris Brezillon boris.brezillon@free-electrons.com Cc: Alexey Brodkin Alexey.Brodkin@synopsys.com Signed-off-by: Thierry Reding treding@nvidia.com
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)
Nevermind, I see there are patches for this already.
Thierry
dri-devel@lists.freedesktop.org