Hi Linus,
This is an optional pull request, Alex was waiting for some alsa bits and some amdgpu bits to land to enable audio support on some AMD APUs. The number of chips using this is quite low, and it's just enabling the audio block for those GPUs.
I'm happy enough it shouldn't cause any problems, just wanted to check if you'd take it now or not.
Dave.
The following changes since commit 36f90b0a2ddd60823fe193a85e60ff1906c2a9b3:
Linux 4.5-rc2 (2016-01-31 18:12:16 -0800)
are available in the git repository at:
git://people.freedesktop.org/~airlied/linux drm-fixes-amd-acp
for you to fetch changes up to f32fea771ca2af4d34ee72ba0f52c87b97db8cac:
Merge branch 'drm-fixes-4.5-acp' of git://people.freedesktop.org/~agd5f/linux into drm-fixes (2016-02-03 08:15:35 +1000)
---------------------------------------------------------------- Dave Airlie (1): Merge branch 'drm-fixes-4.5-acp' of git://people.freedesktop.org/~agd5f/linux into drm-fixes
Maruthi Bayyavarapu (1): drm/amd: add ACP driver support
Maruthi Srinivas Bayyavarapu (1): drm/amd: add pm domain for ACP IP sub blocks
drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/amd/acp/Kconfig | 11 + drivers/gpu/drm/amd/acp/Makefile | 8 + drivers/gpu/drm/amd/acp/acp_hw.c | 50 +++ drivers/gpu/drm/amd/acp/include/acp_gfx_if.h | 34 ++ drivers/gpu/drm/amd/amdgpu/Makefile | 13 +- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 12 + drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 502 +++++++++++++++++++++++++++ drivers/gpu/drm/amd/amdgpu/amdgpu_acp.h | 42 +++ drivers/gpu/drm/amd/amdgpu/vi.c | 12 + drivers/gpu/drm/amd/include/amd_shared.h | 1 + 11 files changed, 686 insertions(+), 1 deletion(-) create mode 100644 drivers/gpu/drm/amd/acp/Kconfig create mode 100644 drivers/gpu/drm/amd/acp/Makefile create mode 100644 drivers/gpu/drm/amd/acp/acp_hw.c create mode 100644 drivers/gpu/drm/amd/acp/include/acp_gfx_if.h create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_acp.h
On Wed, Feb 3, 2016 at 4:04 PM, Dave Airlie airlied@linux.ie wrote:
I'm happy enough it shouldn't cause any problems, just wanted to check if you'd take it now or not.
Honestly, this feels like "might as well wait for 4.6" to me.
I'm generally ok with taking completely new drivers later in the rc if there's a good reason for it, but then I want to feel like there's no way that can regress (because it doesn't impact an existing driver), and I also tend to only do that if the driver is something critical for new machines (ie a new network or video driver can be the difference between "that machine is usable" and "that machine is a doorstop").
This fails both those guidelines - it *might* screw up machines that work now, and while audio certainly isn't unimportant, it generally isn't a "you can't use the machine for anything" kind of issue.
Thus the "I'd rather get this in a few weeks during the next merge window" reaction.
Linus
dri-devel@lists.freedesktop.org