Hi,
git branch drm-fixes-3.12, git commit cdf6e8058415ba4d808537e30a0a6be9fb29e95a
In si_dpm.c, the vddc phase shedding mask does overwrite the vddc voltage mask (lines 3889 and 3920 in si_populate_smc_voltage_tables function). Expected?
(my tahiti based board seems not to have vddc phase shedding, then I could not check if the 2 masks could work together).
regards,
On Tue, Oct 29, 2013 at 2:20 PM, Sylvain BERTRAND sylware@legeek.net wrote:
Hi,
git branch drm-fixes-3.12, git commit cdf6e8058415ba4d808537e30a0a6be9fb29e95a
In si_dpm.c, the vddc phase shedding mask does overwrite the vddc voltage mask (lines 3889 and 3920 in si_populate_smc_voltage_tables function). Expected?
They are different tables (voltageMaskTable and phaseMaskTable), unless I'm not understanding your question.
table->voltageMaskTable.lowMask[SISLANDS_SMC_VOLTAGEMASK_VDDC] = cpu_to_be32(eg_pi->vddc_voltage_table.mask_low);
table->phaseMaskTable.lowMask[SISLANDS_SMC_VOLTAGEMASK_VDDC] = cpu_to_be32(si_pi->vddc_phase_shed_table.mask_low);
Alex
(my tahiti based board seems not to have vddc phase shedding, then I could not check if the 2 masks could work together).
regards,
-- Sylvain _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
On Wed, Oct 30, 2013 at 2:28 PM, Sylvain BERTRAND sylware@legeek.net wrote:
unless I'm not understanding your question.
Nope, my bad, I miss-read and did not double-check.
:)
BTW, which generations/families/types(mobile...) do support phase shedding?
Southern Islands and Sea Islands dGPU parts as far as I know.
Alex
regards,
-- Sylvain
BTW, which generations/families/types(mobile...) do support phase shedding?
Southern Islands and Sea Islands dGPU parts as far as I know.
Erf, for tahiti discret gpu, the atombios rom does not have a VOLTAGE_OBJ_PHASE_LUT for VOLTAGE_TYPE_VDDC.
I probably miss something in dpm code.
regards,
On Wed, Oct 30, 2013 at 6:41 PM, Sylvain BERTRAND sylware@legeek.net wrote:
BTW, which generations/families/types(mobile...) do support phase shedding?
Southern Islands and Sea Islands dGPU parts as far as I know.
Erf, for tahiti discret gpu, the atombios rom does not have a VOLTAGE_OBJ_PHASE_LUT for VOLTAGE_TYPE_VDDC.
I probably miss something in dpm code.
It depends on the individual card configuration. Different cards have different features enabled. It's up to the OEM AFAIK.
Alex
regards,
-- Sylvain BERTRAND
dri-devel@lists.freedesktop.org
-
Alex Deucher -
Sylvain BERTRAND