Hello DRI and fbdev developers,
I've now mostly checked all queued-up patches on the fbdev mailing list: https://patchwork.kernel.org/project/linux-fbdev/list/
and applied the ones which seemed appropriate. IMHO there is nothing really critical/important/conflicting in there. Shortlog is below, the git "fbdev for-next" branch is here: https://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git/log/?...
If you see critical things in there or want me to drop (or add) something, just please let me know. If everything goes well I plan to send a pull request when the merge window for kernel v5.18 opens.
Helge
---------------------------------------------------------------- Arnd Bergmann (1): agp: define proper stubs for empty helpers
Cai Huoqing (11): video: fbdev: au1200fb: Make use of dma_mmap_coherent() video: fbdev: omapfb: panel-lgphilips-lb035q02: Make use of the helper function dev_err_probe() video: fbdev: omapfb: lcd_ams_delta: Make use of the helper function dev_err_probe() video: fbdev: omapfb: panel-sharp-ls037v7dw01: Make use of the helper function dev_err_probe() video: fbdev: omapfb: panel-tpo-td043mtea1: Make use of the helper function dev_err_probe() video: fbdev: da8xx-fb: Make use of the helper function dev_err_probe() video: fbdev: pxa168fb: Make use of the helper function dev_err_probe() video: fbdev: pxa3xx-gcu: Make use of the helper function dev_err_probe() video: fbdev: ssd1307fb: Make use of the helper function dev_err_probe() video: fbdev: s3c-fb: Make use of the helper function dev_err_probe() video: fbdev: mmp: Make use of the helper function dev_err_probe()
Changcheng Deng (1): video: fbmem: use swap() to make code cleaner in fb_rotate_logo()
Chunyang Zhong (1): video: fbdev: ocfb: add const to of_device_id
Colin Ian King (6): video: fbdev: aty128fb: make some arrays static const video: fbdev: mb862xx: remove redundant assignment to pointer ptr video: fbdev: via: Fix spelling mistake "bellow" -> "below" video: fbdev: atyfb: Remove assigned but never used variable statements video: fbdev: asiliantfb: remove redundant assignment to variable Ftarget video: fbdev: pxa168fb: Initialize pointers with NULL and not plain integer 0
Dan Carpenter (3): video: fbdev: savagefb: make a variable local video: fbdev: atmel_lcdfb: fix an error code in atmel_lcdfb_probe() video: fbdev: fbcvt.c: fix printing in fb_cvt_print_name()
Evgeny Novikov (1): video: fbdev: w100fb: Reset global state
George Kennedy (1): video: fbdev: cirrusfb: check pixclock to avoid divide by zero
Greg Kroah-Hartman (1): video: fbdev: omapfb: use default_groups in kobj_type
Jiasheng Jiang (1): video: fbdev: imxfb: Check for null res pointer
Krzysztof Kozlowski (1): video: fbdev: s3c-fb: drop unneeded MODULE_ALIAS
Luca Weiss (2): backlight: qcom-wled: Add PM6150L compatible dt-bindings: simple-framebuffer: allow standalone compatible
Minghao Chi (1): video: fbdev: mach64_ct: remove redundant res variable
Tim Gardner (1): video: fbdev: nvidiafb: Use strscpy() to prevent buffer overflow
Wang Hai (1): video: fbdev: smscufx: Fix null-ptr-deref in ufx_usb_probe()
Xu Wang (2): backlight: lm3630a_bl: Remove redundant 'flush_workqueue()' calls video: fbdev: omapfb: Remove redundant 'flush_workqueue()' calls
Yang Guang (2): video: fbdev: sis: use swap() to make code cleaner video: fbdev: omapfb: acx565akm: replace snprintf with sysfs_emit
YueHaibing (1): video: fbdev: controlfb: Fix COMPILE_TEST build
Z. Liu (1): video: fbdev: matroxfb: set maxvram of vbG200eW to the same as vbG200 to avoid black screen
Hi Helge,
On Sun, Jan 30, 2022 at 10:05:39PM +0100, Helge Deller wrote:
Hello DRI and fbdev developers,
I've now mostly checked all queued-up patches on the fbdev mailing list: https://patchwork.kernel.org/project/linux-fbdev/list/
Nice to see all the pending fbdev patches processed.
I do not see why most of them are applied - why bother with dev_err_probe or spelling fixes in old drivers that does not see any active development. But that's your call.
How come there are backlight, dt-bindings and agp in between the fbdev patches? It would be nice to be able to trust that if the fbdev tree has patches then it is mentioned when the tree touches files outside the fbdev dir.
These are the patches that caught my eye:
Arnd Bergmann (1): agp: define proper stubs for empty helpers
Luca Weiss (2): backlight: qcom-wled: Add PM6150L compatible dt-bindings: simple-framebuffer: allow standalone compatible
Xu Wang (2): backlight: lm3630a_bl: Remove redundant 'flush_workqueue()' calls
If this was mentioned then fine - but now it looks like patches that do not belong here.
Sam
Hello Sam,
On 2/2/22 18:56, Sam Ravnborg wrote:
Hi Helge,
On Sun, Jan 30, 2022 at 10:05:39PM +0100, Helge Deller wrote:
Hello DRI and fbdev developers,
I've now mostly checked all queued-up patches on the fbdev mailing list: https://patchwork.kernel.org/project/linux-fbdev/list/
Nice to see all the pending fbdev patches processed.
Thanks!
I do not see why most of them are applied - why bother with dev_err_probe or spelling fixes in old drivers that does not see any active development. But that's your call.
Doesn't for every driver at some point the development ceases? Reasons might be that it's not used anymore, or simply because it does what it should do.
How come there are backlight, dt-bindings
I didn't know, and I picked up those at the beginning. I did agreed with the backlight maintainers that I should keep those which are already in my tree, and that I will ignore any upcoming new ones.
and agp in between the fbdev patches?
It wasn't picked up yet, agp somehow belongs to fbdev and as maintainer for parisc I was somehow involved as well. I'm happy to drop it if you think it belongs somewhere else...
It would be nice to be able to trust that if the fbdev tree has patches then it is mentioned when the tree touches files outside the fbdev dir.
Sure. Usually I also send out the diffstat.
Helge
These are the patches that caught my eye:
Arnd Bergmann (1): agp: define proper stubs for empty helpers
Luca Weiss (2): backlight: qcom-wled: Add PM6150L compatible dt-bindings: simple-framebuffer: allow standalone compatible
Xu Wang (2): backlight: lm3630a_bl: Remove redundant 'flush_workqueue()' calls
If this was mentioned then fine - but now it looks like patches that do not belong here.
Sam
Hi Helge,
How come there are backlight, dt-bindings
I didn't know, and I picked up those at the beginning. I did agreed with the backlight maintainers that I should keep those which are already in my tree, and that I will ignore any upcoming new ones.
Fine, just include this in the cover letter to explain it.
and agp in between the fbdev patches?
It wasn't picked up yet, agp somehow belongs to fbdev and as maintainer for parisc I was somehow involved as well. I'm happy to drop it if you think it belongs somewhere else...
I see no point in dropping as you are involved and patch seems relevant. But please explain this in the cover letter so readers are not left wondering.
Sam
Hello Sam,
On 2/2/22 19:39, Sam Ravnborg wrote:
Hi Helge,
How come there are backlight, dt-bindings
I didn't know, and I picked up those at the beginning. I did agreed with the backlight maintainers that I should keep those which are already in my tree, and that I will ignore any upcoming new ones.
Fine, just include this in the cover letter to explain it.
Ok, I'll do.
and agp in between the fbdev patches?
It wasn't picked up yet, agp somehow belongs to fbdev and as maintainer for parisc I was somehow involved as well. I'm happy to drop it if you think it belongs somewhere else...
I see no point in dropping as you are involved and patch seems relevant. But please explain this in the cover letter so readers are not left wondering.
Ok.
Thanks a lot for your feedback ! Helge
dri-devel@lists.freedesktop.org
-
Helge Deller -
Sam Ravnborg