[drm:drm-next 23/23] drivers/gpu/drm/vgem/vgem_drv.c:198:5: sparse: symbol 'vgem_gem_dumb_map' was not declared. Should it be static?
tree: git://people.freedesktop.org/~airlied/linux.git drm-next head: 502e95c6678505474f1056480310cd9382bacbac commit: 502e95c6678505474f1056480310cd9382bacbac [23/23] drm/vgem: implement virtual GEM reproduce: # apt-get install sparse git checkout 502e95c6678505474f1056480310cd9382bacbac make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
drivers/gpu/drm/vgem/vgem_drv.c:198:5: sparse: symbol 'vgem_gem_dumb_map' was not declared. Should it be static? drivers/gpu/drm/vgem/vgem_drv.c:238:5: sparse: symbol 'vgem_drm_gem_mmap' was not declared. Should it be static? drivers/gpu/drm/vgem/vgem_drv.c:328:19: sparse: symbol 'vgem_device' was not declared. Should it be static?
Please review and possibly fold the followup patch.
--- 0-DAY kernel test infrastructure Open Source Technology Center http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
Signed-off-by: Fengguang Wu fengguang.wu@intel.com --- vgem_drv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c index cb3b435..f7440e8c8 100644 --- a/drivers/gpu/drm/vgem/vgem_drv.c +++ b/drivers/gpu/drm/vgem/vgem_drv.c @@ -195,7 +195,7 @@ static int vgem_gem_dumb_create(struct drm_file *file, struct drm_device *dev, return 0; }
-int vgem_gem_dumb_map(struct drm_file *file, struct drm_device *dev, +static int vgem_gem_dumb_map(struct drm_file *file, struct drm_device *dev, uint32_t handle, uint64_t *offset) { int ret = 0; @@ -235,7 +235,7 @@ unlock: return ret; }
-int vgem_drm_gem_mmap(struct file *filp, struct vm_area_struct *vma) +static int vgem_drm_gem_mmap(struct file *filp, struct vm_area_struct *vma) { struct drm_file *priv = filp->private_data; struct drm_device *dev = priv->minor->dev; @@ -325,7 +325,7 @@ static struct drm_driver vgem_driver = { .minor = DRIVER_MINOR, };
-struct drm_device *vgem_device; +static struct drm_device *vgem_device;
static int __init vgem_init(void) {
On Thu, 2015-04-02 at 10:59 +0800, kbuild test robot wrote:
Signed-off-by: Fengguang Wu fengguang.wu@intel.com
[]
diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
[]
@@ -195,7 +195,7 @@ static int vgem_gem_dumb_create(struct drm_file *file, struct drm_device *dev, return 0; }
-int vgem_gem_dumb_map(struct drm_file *file, struct drm_device *dev, +static int vgem_gem_dumb_map(struct drm_file *file, struct drm_device *dev, uint32_t handle, uint64_t *offset)
Hello Fengguang.
When you or your robot does these, can you please make sure the entire statement is indented properly?
thanks,
On Wed, Apr 01, 2015 at 08:04:55PM -0700, Joe Perches wrote:
On Thu, 2015-04-02 at 10:59 +0800, kbuild test robot wrote:
Signed-off-by: Fengguang Wu fengguang.wu@intel.com
[]
diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
[]
@@ -195,7 +195,7 @@ static int vgem_gem_dumb_create(struct drm_file *file, struct drm_device *dev, return 0; }
-int vgem_gem_dumb_map(struct drm_file *file, struct drm_device *dev, +static int vgem_gem_dumb_map(struct drm_file *file, struct drm_device *dev, uint32_t handle, uint64_t *offset)
Hello Fengguang.
When you or your robot does these, can you please make sure the entire statement is indented properly?
OK, added it to the TODO list. Sorry for the inconvenience!
Thanks, Fengguang
Once the indentation is fixed: Reviewed-by: Zach Reizner zachr@google.com
On Wed, Apr 1, 2015 at 8:00 PM kbuild test robot fengguang.wu@intel.com wrote:
Signed-off-by: Fengguang Wu fengguang.wu@intel.com
vgem_drv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_ drv.c index cb3b435..f7440e8c8 100644 --- a/drivers/gpu/drm/vgem/vgem_drv.c +++ b/drivers/gpu/drm/vgem/vgem_drv.c @@ -195,7 +195,7 @@ static int vgem_gem_dumb_create(struct drm_file *file, struct drm_device *dev, return 0; }
-int vgem_gem_dumb_map(struct drm_file *file, struct drm_device *dev, +static int vgem_gem_dumb_map(struct drm_file *file, struct drm_device *dev, uint32_t handle, uint64_t *offset) { int ret = 0; @@ -235,7 +235,7 @@ unlock: return ret; }
-int vgem_drm_gem_mmap(struct file *filp, struct vm_area_struct *vma) +static int vgem_drm_gem_mmap(struct file *filp, struct vm_area_struct *vma) { struct drm_file *priv = filp->private_data; struct drm_device *dev = priv->minor->dev; @@ -325,7 +325,7 @@ static struct drm_driver vgem_driver = { .minor = DRIVER_MINOR, };
-struct drm_device *vgem_device; +static struct drm_device *vgem_device;
static int __init vgem_init(void) {
dri-devel@lists.freedesktop.org
-
Fengguang Wu -
Joe Perches -
kbuild test robot
-
Zachary Reizner