On Mon, Jul 13, 2020 at 05:12:35PM +0300, Dan Carpenter wrote:
On Mon, Jul 13, 2020 at 05:50:14PM +0530, Suraj Upadhyay wrote:
Simplify while loops into more readable and simple for loops.
I don't think either is more clear that the other. Walter Harms hates count down loops and he's not entirely wrong...
regards, dan carpenter
Hi Dan, Thanks for your response. Should I send a v2 of this patch or not ?? Also do you have any problems with the other two patches doing the same thing in different files ?? I am all ears.
Thanks,
Suraj Upadhyay.
On Tue, Jul 14, 2020 at 12:10:22PM +0530, Suraj Upadhyay wrote:
On Mon, Jul 13, 2020 at 05:12:35PM +0300, Dan Carpenter wrote:
On Mon, Jul 13, 2020 at 05:50:14PM +0530, Suraj Upadhyay wrote:
Simplify while loops into more readable and simple for loops.
I don't think either is more clear that the other. Walter Harms hates count down loops and he's not entirely wrong...
regards, dan carpenter
Hi Dan, Thanks for your response. Should I send a v2 of this patch or not ?? Also do you have any problems with the other two patches doing the same thing in different files ?? I am all ears.
I would just resend patch 6/6. If this is your driver and you're going to be working on it extensively then you do what makes you feel comfortable. But to me the original code seems fine with while count down loops.
regards, dan carpenter
dri-devel@lists.freedesktop.org
-
Dan Carpenter -
Suraj Upadhyay