This is the latest revision of my series cleaning up imx-drm and hopefully getting it ready to be moved out of drivers/staging. This series is updated to v3.14-rc2.
Since the last round of patches were posted, the component support has been merged into mainline, and thus dropped from this series. Greg has taken the first three patches and merged them into his linux-next tree - however, I include them here for completness.
Most of the comments from last time still apply, and I'll look at incorporating some of the other patches that were posted in the coming week.
If I can have some acks for this, I'll start sending some of it to Greg - I'd like to at least get the five or six initial imx-hdmi patches to Greg and queued up for the next merge window sooner rather than later, preferably getting most of this ready for that window too.
arch/arm/boot/dts/imx51-babbage.dts | 10 +- arch/arm/boot/dts/imx53-m53evk.dts | 8 +- arch/arm/boot/dts/imx53-mba53.dts | 6 + arch/arm/boot/dts/imx53-qsb.dts | 8 +- arch/arm/boot/dts/imx6dl.dtsi | 5 + arch/arm/boot/dts/imx6q-sabresd.dts | 4 + arch/arm/boot/dts/imx6q.dtsi | 5 + arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 6 + arch/arm/boot/dts/imx6qdl.dtsi | 9 + drivers/staging/imx-drm/Makefile | 3 +- drivers/staging/imx-drm/imx-drm-core.c | 831 ++++++++++------------------- drivers/staging/imx-drm/imx-drm.h | 39 +- drivers/staging/imx-drm/imx-fb.c | 47 -- drivers/staging/imx-drm/imx-fbdev.c | 74 --- drivers/staging/imx-drm/imx-hdmi.c | 680 +++++++++-------------- drivers/staging/imx-drm/imx-ldb.c | 125 ++--- drivers/staging/imx-drm/imx-tve.c | 134 +++-- drivers/staging/imx-drm/ipu-v3/ipu-di.c | 317 +++++------ drivers/staging/imx-drm/ipuv3-crtc.c | 56 +- drivers/staging/imx-drm/parallel-display.c | 100 ++-- 20 files changed, 934 insertions(+), 1533 deletions(-)
Am Montag, den 10.02.2014, 12:28 +0000 schrieb Russell King - ARM Linux:
This is the latest revision of my series cleaning up imx-drm and hopefully getting it ready to be moved out of drivers/staging. This series is updated to v3.14-rc2.
Since the last round of patches were posted, the component support has been merged into mainline, and thus dropped from this series. Greg has taken the first three patches and merged them into his linux-next tree - however, I include them here for completness.
Most of the comments from last time still apply, and I'll look at incorporating some of the other patches that were posted in the coming week.
If I can have some acks for this, I'll start sending some of it to
Greg - I'd like to at least get the five or six initial imx-hdmi patches to Greg and queued up for the next merge window sooner rather than later, preferably getting most of this ready for that window too.
For the first 9 patches up to (including) "imx-drm: ipu-v3: more clocking fixes": Acked-by: Philipp Zabel p.zabel@pengutronix.de
As you say, comments about the device tree bindings still apply. I'd prefer if the patches that currently use the crtcs property were reworked to use the v4l2 style device tree bindings before they hit mainline.
regards Philipp
On Mon, Feb 10, 2014 at 04:12:19PM +0100, Philipp Zabel wrote:
Am Montag, den 10.02.2014, 12:28 +0000 schrieb Russell King - ARM Linux:
This is the latest revision of my series cleaning up imx-drm and hopefully getting it ready to be moved out of drivers/staging. This series is updated to v3.14-rc2.
Since the last round of patches were posted, the component support has been merged into mainline, and thus dropped from this series. Greg has taken the first three patches and merged them into his linux-next tree - however, I include them here for completness.
Most of the comments from last time still apply, and I'll look at incorporating some of the other patches that were posted in the coming week.
If I can have some acks for this, I'll start sending some of it to
Greg - I'd like to at least get the five or six initial imx-hdmi patches to Greg and queued up for the next merge window sooner rather than later, preferably getting most of this ready for that window too.
For the first 9 patches up to (including) "imx-drm: ipu-v3: more clocking fixes": Acked-by: Philipp Zabel p.zabel@pengutronix.de
As you say, comments about the device tree bindings still apply. I'd prefer if the patches that currently use the crtcs property were reworked to use the v4l2 style device tree bindings before they hit mainline.
I'm trying /not/ to do that much more work on this because there's other things that need my attention, like a complete rewrite of the SDHCI mess. I want to get the imx-drm stuff off my plate so I don't have to worry about it.
So, I'd really like _all_ these patches to go into mainline for v3.15 with the least rework possible so I can spend the next few months working on rewriting SDHCI.
What I don't want is carrying hundreds of patches across multiple kernel versions.
Now, mind explaining what "v4l2 style device tree bindings" means? I've no idea since I'm relatively new to DT.
On Mon, 10 Feb 2014 15:18:21 +0000 Russell King - ARM Linux linux@arm.linux.org.uk wrote:
Now, mind explaining what "v4l2 style device tree bindings" means? I've no idea since I'm relatively new to DT.
Documentation/devicetree/bindings/media/video-interfaces.txt
For the Cubox, I have:
tda998x: hdmi-encoder { compatible = "nxp,tda998x"; ... port { tda998x_0: endpoint@0 { remote-endpoint = <&lcd0_0>; }; }; };
&lcd0 { status = "okay"; ... port { lcd0_0: endpoint@0 { remote-endpoint = <&tda998x_0>; }; }; };
Hi Russell,
On Mon, Feb 10, 2014 at 4:18 PM, Russell King - ARM Linux < linux@arm.linux.org.uk> wrote:
On Mon, Feb 10, 2014 at 04:12:19PM +0100, Philipp Zabel wrote:
Am Montag, den 10.02.2014, 12:28 +0000 schrieb Russell King - ARM Linux:
This is the latest revision of my series cleaning up imx-drm and hopefully getting it ready to be moved out of drivers/staging. This series is updated to v3.14-rc2.
Since the last round of patches were posted, the component support has been merged into mainline, and thus dropped from this series. Greg has taken the first three patches and merged them into his linux-next tree - however, I include them here for completness.
Most of the comments from last time still apply, and I'll look at incorporating some of the other patches that were posted in the coming week.
If I can have some acks for this, I'll start sending some of it to
Greg - I'd like to at least get the five or six initial imx-hdmi patches to Greg and queued up for the next merge window sooner rather than later, preferably getting most of this ready for that window too.
For the first 9 patches up to (including) "imx-drm: ipu-v3: more clocking fixes": Acked-by: Philipp Zabel p.zabel@pengutronix.de
As you say, comments about the device tree bindings still apply. I'd prefer if the patches that currently use the crtcs property were reworked to use the v4l2 style device tree bindings before they hit mainline.
I'm trying /not/ to do that much more work on this because there's other things that need my attention, like a complete rewrite of the SDHCI mess. I want to get the imx-drm stuff off my plate so I don't have to worry about it.
So, I'd really like _all_ these patches to go into mainline for v3.15
with the least rework possible so I can spend the next few months
working on rewriting SDHCI.
I'd like all of them to go through, too. If you don't want to have the DT changes integrated, I'd appreciate if you could have a look at my patches on top of your series and possibly append them to your series or let me synchronize somehow:
http://archive.arm.linux.org.uk/lurker/message/20140106.145159.a1d82ba9.en.h...
I'll prepare an updated more complete version that should work on the CarrierOne. Some feedback would be appreciated so I can improve them in time for your series' final submission. The only thing I'd like to avoid is to have a stable v3.15 release with the old IPU specific bindings widely used due to the newly added HDMI support.
What I don't want is carrying hundreds of patches across multiple
kernel versions.
No complaints there.
Now, mind explaining what "v4l2 style device tree bindings" means? I've
no idea since I'm relatively new to DT.
Sorry, I was under the impression that people at the 2013 kernel summit drm/dt discussion were aware of those bindings and kind of agreed on (or at least did not oppose) them:
Documentation/devicetree/bindings/media/video-interfaces.txt
The first patch of the above patchset adds the i.MX6 specific connections for the output paths according to this binding: http://archive.arm.linux.org.uk/lurker/message/20140106.145200.24ed4a48.en.h...
regards Philipp
On Mon, Feb 10, 2014 at 06:37:26PM +0100, Philipp Zabel wrote:
I'd like all of them to go through, too. If you don't want to have the DT changes integrated, I'd appreciate if you could have a look at my patches on top of your series and possibly append them to your series or let me synchronize somehow:
http://archive.arm.linux.org.uk/lurker/message/20140106.145159.a1d82ba9.en.h...
I replied to your 2nd patch there...
I'm not happy ending up with a hard dependency between v4l2 code and code needed for the display side to work, especially when we can end up with imx-drm being the primary console display. I've outlined my thoughts about what I think needs to happen in the reply to patch 2.
Hi Russell,
Am Montag, den 10.02.2014, 17:56 +0000 schrieb Russell King - ARM Linux:
On Mon, Feb 10, 2014 at 06:37:26PM +0100, Philipp Zabel wrote:
I'd like all of them to go through, too. If you don't want to have the DT changes integrated, I'd appreciate if you could have a look at my patches on top of your series and possibly append them to your series or let me synchronize somehow:
http://archive.arm.linux.org.uk/lurker/message/20140106.145159.a1d82ba9.en.h...
I replied to your 2nd patch there...
I'm not happy ending up with a hard dependency between v4l2 code and code needed for the display side to work, especially when we can end up with imx-drm being the primary console display. I've outlined my thoughts about what I think needs to happen in the reply to patch 2.
Thanks for your comments there. I have just updated and resent this series ([RFC PATCH v3 0/9] imx-drm dt bindings), still with a temporary local copy of the v4l2_of functions, as long as the final resting place of the v4l2_of/of_graph functions seems to be a matter of discussion.
regards Philipp
On Tue, Feb 18, 2014 at 12:45:09PM +0100, Philipp Zabel wrote:
Thanks for your comments there. I have just updated and resent this series ([RFC PATCH v3 0/9] imx-drm dt bindings), still with a temporary local copy of the v4l2_of functions, as long as the final resting place of the v4l2_of/of_graph functions seems to be a matter of discussion.
Okay. My plans are to send more of these patches imminently to Greg. I've just pulled them forward to -rc3, which means that four have now dropped out of the series (as three have been recently merged and one due to that build fix for imx-hdmi.)
I'm just debating whether I need to send the whole series out again or not before doing that... any opinion?
Nothing's really changed in the patch set since the last time.
On Mon, Feb 10, 2014 at 12:28:03PM +0000, Russell King - ARM Linux wrote:
This is the latest revision of my series cleaning up imx-drm and hopefully getting it ready to be moved out of drivers/staging. This series is updated to v3.14-rc2.
Since the last round of patches were posted, the component support has been merged into mainline, and thus dropped from this series. Greg has taken the first three patches and merged them into his linux-next tree - however, I include them here for completness.
Most of the comments from last time still apply, and I'll look at incorporating some of the other patches that were posted in the coming week.
If I can have some acks for this, I'll start sending some of it to Greg - I'd like to at least get the five or six initial imx-hdmi patches to Greg and queued up for the next merge window sooner rather than later, preferably getting most of this ready for that window too.
So far, only the first few patches have been acked by one person. What about the remainder? There's been no comments on them either...
Am Mittwoch, den 12.02.2014, 09:56 +0000 schrieb Russell King - ARM Linux:
On Mon, Feb 10, 2014 at 12:28:03PM +0000, Russell King - ARM Linux wrote:
This is the latest revision of my series cleaning up imx-drm and hopefully getting it ready to be moved out of drivers/staging. This series is updated to v3.14-rc2.
Since the last round of patches were posted, the component support has been merged into mainline, and thus dropped from this series. Greg has taken the first three patches and merged them into his linux-next tree - however, I include them here for completness.
Most of the comments from last time still apply, and I'll look at incorporating some of the other patches that were posted in the coming week.
If I can have some acks for this, I'll start sending some of it to Greg - I'd like to at least get the five or six initial imx-hdmi patches to Greg and queued up for the next merge window sooner rather than later, preferably getting most of this ready for that window too.
So far, only the first few patches have been acked by one person. What about the remainder? There's been no comments on them either...
With the understanding that I loathe the current DT bindings, which are not the fault of this series:
Acked-by: Philipp Zabel p.zabel@pengutronix.de
regards Philipp
On Mon, Feb 10, 2014 at 10:28 AM, Russell King - ARM Linux linux@arm.linux.org.uk wrote:
This is the latest revision of my series cleaning up imx-drm and hopefully getting it ready to be moved out of drivers/staging. This series is updated to v3.14-rc2.
Since the last round of patches were posted, the component support has been merged into mainline, and thus dropped from this series. Greg has taken the first three patches and merged them into his linux-next tree - however, I include them here for completness.
Most of the comments from last time still apply, and I'll look at incorporating some of the other patches that were posted in the coming week.
If I can have some acks for this, I'll start sending some of it to Greg - I'd like to at least get the five or six initial imx-hdmi patches to Greg and queued up for the next merge window sooner rather than later, preferably getting most of this ready for that window too.
Series looks good:
Reviewed-by: Fabio Estevam fabio.estevam@freescale.com
Patch 04/35 will not be needed in the final submission, as there is already a fix for the build issue in Greg's tree.
Regards,
Fabio Estevam
2014-02-12 12:53 GMT+01:00 Fabio Estevam festevam@gmail.com:
On Mon, Feb 10, 2014 at 10:28 AM, Russell King - ARM Linux linux@arm.linux.org.uk wrote:
This is the latest revision of my series cleaning up imx-drm and hopefully getting it ready to be moved out of drivers/staging. This series is updated to v3.14-rc2.
Since the last round of patches were posted, the component support has been merged into mainline, and thus dropped from this series. Greg has taken the first three patches and merged them into his linux-next tree - however, I include them here for completness.
Most of the comments from last time still apply, and I'll look at incorporating some of the other patches that were posted in the coming week.
If I can have some acks for this, I'll start sending some of it to Greg - I'd like to at least get the five or six initial imx-hdmi patches to Greg and queued up for the next merge window sooner rather than later, preferably getting most of this ready for that window too.
Series looks good:
Reviewed-by: Fabio Estevam fabio.estevam@freescale.com
Patch 04/35 will not be needed in the final submission, as there is already a fix for the build issue in Greg's tree.
I am the only one who does not get the whole series?
Even here ony a handfull of patches are listed: http://www.spinics.net/lists/arm-kernel/threads.html#306292
-- Christian Gmeiner, MSc
On Wed, Feb 12, 2014 at 01:04:30PM +0100, Christian Gmeiner wrote:
2014-02-12 12:53 GMT+01:00 Fabio Estevam festevam@gmail.com:
On Mon, Feb 10, 2014 at 10:28 AM, Russell King - ARM Linux linux@arm.linux.org.uk wrote:
This is the latest revision of my series cleaning up imx-drm and hopefully getting it ready to be moved out of drivers/staging. This series is updated to v3.14-rc2.
Since the last round of patches were posted, the component support has been merged into mainline, and thus dropped from this series. Greg has taken the first three patches and merged them into his linux-next tree - however, I include them here for completness.
Most of the comments from last time still apply, and I'll look at incorporating some of the other patches that were posted in the coming week.
If I can have some acks for this, I'll start sending some of it to Greg - I'd like to at least get the five or six initial imx-hdmi patches to Greg and queued up for the next merge window sooner rather than later, preferably getting most of this ready for that window too.
Series looks good:
Reviewed-by: Fabio Estevam fabio.estevam@freescale.com
Patch 04/35 will not be needed in the final submission, as there is already a fix for the build issue in Greg's tree.
I am the only one who does not get the whole series?
Even here ony a handfull of patches are listed: http://www.spinics.net/lists/arm-kernel/threads.html#306292
You will find it all on the devel@driverdev.osuosl.org archive.
2014-02-12 13:45 GMT+01:00 Russell King - ARM Linux linux@arm.linux.org.uk:
On Wed, Feb 12, 2014 at 01:04:30PM +0100, Christian Gmeiner wrote:
2014-02-12 12:53 GMT+01:00 Fabio Estevam festevam@gmail.com:
On Mon, Feb 10, 2014 at 10:28 AM, Russell King - ARM Linux linux@arm.linux.org.uk wrote:
This is the latest revision of my series cleaning up imx-drm and hopefully getting it ready to be moved out of drivers/staging. This series is updated to v3.14-rc2.
Since the last round of patches were posted, the component support has been merged into mainline, and thus dropped from this series. Greg has taken the first three patches and merged them into his linux-next tree - however, I include them here for completness.
Most of the comments from last time still apply, and I'll look at incorporating some of the other patches that were posted in the coming week.
If I can have some acks for this, I'll start sending some of it to Greg - I'd like to at least get the five or six initial imx-hdmi patches to Greg and queued up for the next merge window sooner rather than later, preferably getting most of this ready for that window too.
Series looks good:
Reviewed-by: Fabio Estevam fabio.estevam@freescale.com
Patch 04/35 will not be needed in the final submission, as there is already a fix for the build issue in Greg's tree.
I am the only one who does not get the whole series?
Even here ony a handfull of patches are listed: http://www.spinics.net/lists/arm-kernel/threads.html#306292
You will find it all on the devel@driverdev.osuosl.org archive.
thanks - thumbs up for this series. -- Christian Gmeiner, MSc
On Mon, Feb 10, 2014 at 12:28:03PM +0000, Russell King - ARM Linux wrote:
This is the latest revision of my series cleaning up imx-drm and hopefully getting it ready to be moved out of drivers/staging. This series is updated to v3.14-rc2.
Since the last round of patches were posted, the component support has been merged into mainline, and thus dropped from this series. Greg has taken the first three patches and merged them into his linux-next tree - however, I include them here for completness.
Most of the comments from last time still apply, and I'll look at incorporating some of the other patches that were posted in the coming week.
If I can have some acks for this, I'll start sending some of it to Greg - I'd like to at least get the five or six initial imx-hdmi patches to Greg and queued up for the next merge window sooner rather than later, preferably getting most of this ready for that window too.
For the series,
Acked-by: Shawn Guo shawn.guo@linaro.org
dri-devel@lists.freedesktop.org
-
Christian Gmeiner -
Fabio Estevam -
Jean-Francois Moine -
Philipp Zabel -
Philipp Zabel -
Russell King - ARM Linux -
Shawn Guo