the variable sender is dereferenced in line 190, so it is no reason to check null again in line 198.
Signed-off-by: Cong Ding dinggnu@gmail.com --- drivers/gpu/drm/nouveau/nouveau_fence.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c b/drivers/gpu/drm/nouveau/nouveau_fence.c index 1d049be..b6b8e49 100644 --- a/drivers/gpu/drm/nouveau/nouveau_fence.c +++ b/drivers/gpu/drm/nouveau/nouveau_fence.c @@ -195,11 +195,9 @@ nouveau_fence_new(struct nouveau_channel *chan, struct nouveau_fence **pfence) return -ENOMEM; kref_init(&fence->kref);
- if (chan) { - ret = nouveau_fence_emit(fence, chan); - if (ret) - nouveau_fence_unref(&fence); - } + ret = nouveau_fence_emit(fence, chan); + if (ret) + nouveau_fence_unref(&fence);
*pfence = fence; return ret;
Cong Ding dinggnu@gmail.com wrote:
the variable sender is dereferenced in line 190, so it is no reason to check null again in line 198.
Did you mean "The variable 'chan'"?
David
On Tue, Jan 15, 2013 at 10:39:23AM +0000, David Howells wrote:
Cong Ding dinggnu@gmail.com wrote:
the variable sender is dereferenced in line 190, so it is no reason to check null again in line 198.
Did you mean "The variable 'chan'"?
sorry, my fault. so should I send a new version to correct the typo? - cong
Cong Ding dinggnu@gmail.com wrote:
the variable sender is dereferenced in line 190, so it is no reason to check null again in line 198.
Did you mean "The variable 'chan'"?
sorry, my fault. so should I send a new version to correct the typo?
Yep.
David
the variable chan is dereferenced in line 190, so it is no reason to check null again in line 198.
Signed-off-by: Cong Ding dinggnu@gmail.com --- drivers/gpu/drm/nouveau/nouveau_fence.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c b/drivers/gpu/drm/nouveau/nouveau_fence.c index 1d049be..b6b8e49 100644 --- a/drivers/gpu/drm/nouveau/nouveau_fence.c +++ b/drivers/gpu/drm/nouveau/nouveau_fence.c @@ -195,11 +195,9 @@ nouveau_fence_new(struct nouveau_channel *chan, struct nouveau_fence **pfence) return -ENOMEM; kref_init(&fence->kref);
- if (chan) { - ret = nouveau_fence_emit(fence, chan); - if (ret) - nouveau_fence_unref(&fence); - } + ret = nouveau_fence_emit(fence, chan); + if (ret) + nouveau_fence_unref(&fence);
*pfence = fence; return ret;
dri-devel@lists.freedesktop.org