https://bugs.freedesktop.org/show_bug.cgi?id=93236
Bug ID: 93236 Summary: Tonga garbled desktop since amdgpu/gfxv8: Cleanup of gfx_v8_0_tiling_mode_table_init() Product: DRI Version: DRI git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: DRM/AMDgpu Assignee: dri-devel@lists.freedesktop.org Reporter: adf.lists@gmail.com
Created attachment 120318 --> https://bugs.freedesktop.org/attachment.cgi?id=120318&action=edit An xwd showing corrupted desktop.
Tried the latest powerplay today and I get a shredded desktop (fluxbox) as soon as I startx.
Apart from the X corruption everything else seems OK, fbcon is OK.
Seems to be -
commit 3e199b1535a70d6169fd11ee309f8bc4c8ba5bb9 Author: Tom St Denis tom.stdenis@amd.com Date: Tue Dec 1 11:47:21 2015 -0500
amdgpu/gfxv8: Cleanup of gfx_v8_0_tiling_mode_table_init()
Simplification and LOC reduction of function gfx_v8_0_tiling_mode_table_init()
https://bugs.freedesktop.org/show_bug.cgi?id=93236
Andy Furniss adf.lists@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #120318|text/plain |image/png mime type| |
https://bugs.freedesktop.org/show_bug.cgi?id=93236
--- Comment #1 from Andy Furniss adf.lists@gmail.com --- Created attachment 120319 --> https://bugs.freedesktop.org/attachment.cgi?id=120319&action=edit dmesg
https://bugs.freedesktop.org/show_bug.cgi?id=93236
--- Comment #2 from Andy Furniss adf.lists@gmail.com --- Created attachment 120320 --> https://bugs.freedesktop.org/attachment.cgi?id=120320&action=edit xorg log
https://bugs.freedesktop.org/show_bug.cgi?id=93236
--- Comment #3 from Andy Furniss adf.lists@gmail.com --- Seems this is because there is no longer a default as there was in the case statement.
If I add a couple of printk sitting on the commit before "bad" I hit the default case during bootup (before I startx).
[ 5.030315] ADF: Hit first default, reg_offset = 31 [ 5.030406] ADF: Hit second default, reg_offset = 15
diff and full dmesg attached to show timing/position of output.
https://bugs.freedesktop.org/show_bug.cgi?id=93236
--- Comment #4 from Andy Furniss adf.lists@gmail.com --- Created attachment 120337 --> https://bugs.freedesktop.org/attachment.cgi?id=120337&action=edit debugging diff
https://bugs.freedesktop.org/show_bug.cgi?id=93236
--- Comment #5 from Andy Furniss adf.lists@gmail.com --- Created attachment 120338 --> https://bugs.freedesktop.org/attachment.cgi?id=120338&action=edit dmesg with debugging output
https://bugs.freedesktop.org/show_bug.cgi?id=93236
--- Comment #6 from Andy Furniss adf.lists@gmail.com --- Of course had I looked at the code rather than just the diff on fdo cgit I wouldn't have needed to bother with printks -
const u32 num_tile_mode_states = 32; const u32 num_secondary_tile_mode_states = 16;
https://bugs.freedesktop.org/show_bug.cgi?id=93236
--- Comment #7 from Andy Furniss adf.lists@gmail.com --- Ugh never mind, I see that the last slot should already be set to 0 :-(
Where's the delete post button :-)
https://bugs.freedesktop.org/show_bug.cgi?id=93236
--- Comment #8 from Andy Furniss adf.lists@gmail.com --- Created attachment 120343 --> https://bugs.freedesktop.org/attachment.cgi?id=120343&action=edit removes stray break
OK I think I've found it now.
There's a stray break in the TONGA bit of the new code.
After a quick search I can't find any others.
https://bugs.freedesktop.org/show_bug.cgi?id=93236
Alex Deucher alexdeucher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #9 from Alex Deucher alexdeucher@gmail.com --- Updated patch pushed.
dri-devel@lists.freedesktop.org