[PATCH 0/3] drm: Use tabs for code indents

List overview All Threads
Download

newer

older

[PATCH v3 0/2]...

[PATCH] drm/ttm: fix error...

Beatriz Martins de Carvalho

21 Apr 2021 21 Apr '21

7:42 p.m.

Remove space and use tabs for indent the code to follow the Linux kernel coding conventions. Problem found by checkpatch

Beatriz Martins de Carvalho (3): drm: drm_atomic_uapi.c: Use tabs for code indents drm: drm_blend.c: Use tabs for code indents drm: drm_connector.c: Use tabs for code indents

drivers/gpu/drm/drm_atomic_uapi.c | 6 ++--- drivers/gpu/drm/drm_blend.c | 4 ++-- drivers/gpu/drm/drm_connector.c | 38 +++++++++++++++---------------- 3 files changed, 24 insertions(+), 24 deletions(-)

-- 2.25.1

Show replies by date

Beatriz Martins de Carvalho

21 Apr 21 Apr

7:42 p.m.

New subject: [PATCH 1/3] drm: drm_atomic_uapi.c: Use tabs for code indents

Remove space and use tabs for indent the code to follow the Linux kernel coding conventions. Problem found by checkpatch.

Signed-off-by: Beatriz Martins de Carvalho martinsdecarvalhobeatriz@gmail.com --- drivers/gpu/drm/drm_atomic_uapi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/drm_atomic_uapi.c index 268bb69c2e2f..438e9585b225 100644 --- a/drivers/gpu/drm/drm_atomic_uapi.c +++ b/drivers/gpu/drm/drm_atomic_uapi.c @@ -78,8 +78,8 @@ int drm_atomic_set_mode_for_crtc(struct drm_crtc_state *state, drm_mode_convert_to_umode(&umode, mode); state->mode_blob = drm_property_create_blob(state->crtc->dev, - sizeof(umode), - &umode); + sizeof(umode), + &umode); if (IS_ERR(state->mode_blob)) return PTR_ERR(state->mode_blob);

@@ -114,7 +114,7 @@ EXPORT_SYMBOL(drm_atomic_set_mode_for_crtc); * Zero on success, error code on failure. Cannot return -EDEADLK. */ int drm_atomic_set_mode_prop_for_crtc(struct drm_crtc_state *state, - struct drm_property_blob *blob) + struct drm_property_blob *blob) { struct drm_crtc *crtc = state->crtc;

-- 2.25.1

Beatriz Martins de Carvalho

7:42 p.m.

New subject: [PATCH 2/3] drm: drm_blend.c: Use tabs for code indents

Remove space and use tabs for indent the code to follow the Linux kernel coding conventions. Problem found by checkpatch.

Signed-off-by: Beatriz Martins de Carvalho martinsdecarvalhobeatriz@gmail.com --- drivers/gpu/drm/drm_blend.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_blend.c b/drivers/gpu/drm/drm_blend.c index 26e2f2ffd255..ec37cbfabb50 100644 --- a/drivers/gpu/drm/drm_blend.c +++ b/drivers/gpu/drm/drm_blend.c @@ -328,8 +328,8 @@ unsigned int drm_rotation_simplify(unsigned int rotation, if (rotation & ~supported_rotations) { rotation ^= DRM_MODE_REFLECT_X | DRM_MODE_REFLECT_Y; rotation = (rotation & DRM_MODE_REFLECT_MASK) | - BIT((ffs(rotation & DRM_MODE_ROTATE_MASK) + 1) - % 4); + BIT((ffs(rotation & DRM_MODE_ROTATE_MASK) + 1) + % 4); }

return rotation;

-- 2.25.1

Beatriz Martins de Carvalho

7:42 p.m.

New subject: [PATCH 3/3] drm: drm_connector.c: Use tabs for code indents

Remove space and use tabs for indent the code to follow the Linux kernel coding conventions. Problem found by checkpatch

Signed-off-by: Beatriz Martins de Carvalho martinsdecarvalhobeatriz@gmail.com --- drivers/gpu/drm/drm_connector.c | 38 ++++++++++++++++----------------- 1 file changed, 19 insertions(+), 19 deletions(-)

diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index 7631f76e7f34..38600c3a6ab2 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm/drm_connector.c @@ -1958,11 +1958,11 @@ int drm_connector_set_path_property(struct drm_connector *connector, int ret;

ret = drm_property_replace_global_blob(dev, - &connector->path_blob_ptr, - strlen(path) + 1, - path, - &connector->base, - dev->mode_config.path_property); + &connector->path_blob_ptr, + strlen(path) + 1, + path, + &connector->base, + dev->mode_config.path_property); return ret; } EXPORT_SYMBOL(drm_connector_set_path_property); @@ -1988,11 +1988,11 @@ int drm_connector_set_tile_property(struct drm_connector *connector)

if (!connector->has_tile) { ret = drm_property_replace_global_blob(dev, - &connector->tile_blob_ptr, - 0, - NULL, - &connector->base, - dev->mode_config.tile_property); + &connector->tile_blob_ptr, + 0, + NULL, + &connector->base, + dev->mode_config.tile_property); return ret; }

@@ -2003,11 +2003,11 @@ int drm_connector_set_tile_property(struct drm_connector *connector) connector->tile_h_size, connector->tile_v_size);

ret = drm_property_replace_global_blob(dev, - &connector->tile_blob_ptr, - strlen(tile) + 1, - tile, - &connector->base, - dev->mode_config.tile_property); + &connector->tile_blob_ptr, + strlen(tile) + 1, + tile, + &connector->base, + dev->mode_config.tile_property); return ret; } EXPORT_SYMBOL(drm_connector_set_tile_property); @@ -2076,10 +2076,10 @@ int drm_connector_update_edid_property(struct drm_connector *connector,

ret = drm_property_replace_global_blob(dev, &connector->edid_blob_ptr, - size, - edid, - &connector->base, - dev->mode_config.edid_property); + size, + edid, + &connector->base, + dev->mode_config.edid_property); if (ret) return ret; return drm_connector_set_tile_property(connector);

-- 2.25.1

Daniel Vetter

22 Apr 22 Apr

8:47 a.m.

New subject: [PATCH 3/3] drm: drm_connector.c: Use tabs for code indents

On Wed, Apr 21, 2021 at 08:42:49PM +0100, Beatriz Martins de Carvalho wrote:

...

Remove space and use tabs for indent the code to follow the Linux kernel coding conventions. Problem found by checkpatch

Signed-off-by: Beatriz Martins de Carvalho martinsdecarvalhobeatriz@gmail.com

Both of your patch sets applied to drm-misc-next for 5.14, thanks a lot. -Daniel

...

drivers/gpu/drm/drm_connector.c | 38 ++++++++++++++++----------------- 1 file changed, 19 insertions(+), 19 deletions(-)

ret = drm_property_replace_global_blob(dev,

                                      &connector->path_blob_ptr,

                                      strlen(path) + 1,

                                      path,

                                      &connector->base,

                                      dev->mode_config.path_property);

```
			       &connector->path_blob_ptr,
```
```
			       strlen(path) + 1,
```
```
			       path,
```
```
			       &connector->base,
```

			       dev->mode_config.path_property);

return ret;

} EXPORT_SYMBOL(drm_connector_set_path_property); @@ -1988,11 +1988,11 @@ int drm_connector_set_tile_property(struct drm_connector *connector)

if (!connector->has_tile) { ret = drm_property_replace_global_blob(dev,

                                        &connector->tile_blob_ptr,

0,

                                        NULL,

                                        &connector->base,

                                        dev->mode_config.tile_property);

```
					&connector->tile_blob_ptr,
```
```
					0,
```
```
					NULL,
```
```
					&connector->base,
```
```
					dev->mode_config.tile_property);
```
return ret; }

@@ -2003,11 +2003,11 @@ int drm_connector_set_tile_property(struct drm_connector *connector) connector->tile_h_size, connector->tile_v_size);

ret = drm_property_replace_global_blob(dev,

                                      &connector->tile_blob_ptr,

                                      strlen(tile) + 1,

                                      tile,

                                      &connector->base,

                                      dev->mode_config.tile_property);

```
			       &connector->tile_blob_ptr,
```
```
			       strlen(tile) + 1,
```
```
			       tile,
```
```
			       &connector->base,
```

			       dev->mode_config.tile_property);

return ret;

} EXPORT_SYMBOL(drm_connector_set_tile_property); @@ -2076,10 +2076,10 @@ int drm_connector_update_edid_property(struct drm_connector *connector,

ret = drm_property_replace_global_blob(dev, &connector->edid_blob_ptr,

                                      size,

                                      edid,

                                      &connector->base,

                                      dev->mode_config.edid_property);

```
			       size,
```
```
			       edid,
```
```
			       &connector->base,
```
```
			       dev->mode_config.edid_property);
```
if (ret) return ret; return drm_connector_set_tile_property(connector);

-- 2.25.1

-- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

1489

Age (days ago)

1490

Last active (days ago)

dri-devel@lists.freedesktop.org

4 comments

2 participants

tags (0)

participants (2)

Beatriz Martins de Carvalho
Daniel Vetter