From: Markus Elfring elfring@users.sourceforge.net Date: Thu, 4 May 2017 14:15:00 +0200
The script "checkpatch.pl" pointed information out like the following.
WARNING: quoted string split across lines
Thus fix the affected source code place.
Signed-off-by: Markus Elfring elfring@users.sourceforge.net --- drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 6f3119d40c50..dbd52ea89fb4 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b/drivers/gpu/drm/i915/i915_debugfs.c @@ -1529,8 +1529,8 @@ static int gen6_drpc_info(struct seq_file *m)
forcewake_count = READ_ONCE(dev_priv->uncore.fw_domain[FW_DOMAIN_ID_RENDER].wake_count); if (forcewake_count) { - seq_puts(m, "RC information inaccurate because somebody " - "holds a forcewake reference \n"); + seq_puts(m, + "RC information inaccurate because somebody holds a forcewake reference.\n"); } else { /* NB: we cannot use forcewake, else we read the wrong values */ while (count++ < 50 && (I915_READ_NOTRACE(FORCEWAKE_ACK) & 1))
On Thu, May 04, 2017 at 06:59:23PM +0200, SF Markus Elfring wrote:
From: Markus Elfring elfring@users.sourceforge.net Date: Thu, 4 May 2017 14:15:00 +0200
The script "checkpatch.pl" pointed information out like the following.
WARNING: quoted string split across lines
Thus fix the affected source code place.
Signed-off-by: Markus Elfring elfring@users.sourceforge.net
drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 6f3119d40c50..dbd52ea89fb4 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b/drivers/gpu/drm/i915/i915_debugfs.c @@ -1529,8 +1529,8 @@ static int gen6_drpc_info(struct seq_file *m)
forcewake_count = READ_ONCE(dev_priv->uncore.fw_domain[FW_DOMAIN_ID_RENDER].wake_count); if (forcewake_count) {
seq_puts(m, "RC information inaccurate because somebody ""holds a forcewake reference \n");
seq_puts(m,"RC information inaccurate because somebody holds a forcewake reference.\n");
And now you break the 80col rule. Blind adherence to checkpatch is impossible. -Chris
+++ b/drivers/gpu/drm/i915/i915_debugfs.c @@ -1529,8 +1529,8 @@ static int gen6_drpc_info(struct seq_file *m)
forcewake_count = READ_ONCE(dev_priv->uncore.fw_domain[FW_DOMAIN_ID_RENDER].wake_count); if (forcewake_count) {
seq_puts(m, "RC information inaccurate because somebody ""holds a forcewake reference \n");
seq_puts(m,"RC information inaccurate because somebody holds a forcewake reference.\n");And now you break the 80col rule. Blind adherence to checkpatch is impossible.
Have you got any other coding style preferences around the grepping of longer message strings from such source code?
Regards, Markus
On Thu, May 04, 2017 at 10:48:10PM +0200, SF Markus Elfring wrote:
+++ b/drivers/gpu/drm/i915/i915_debugfs.c @@ -1529,8 +1529,8 @@ static int gen6_drpc_info(struct seq_file *m)
forcewake_count = READ_ONCE(dev_priv->uncore.fw_domain[FW_DOMAIN_ID_RENDER].wake_count); if (forcewake_count) {
seq_puts(m, "RC information inaccurate because somebody ""holds a forcewake reference \n");
seq_puts(m,"RC information inaccurate because somebody holds a forcewake reference.\n");And now you break the 80col rule. Blind adherence to checkpatch is impossible.
Have you got any other coding style preferences around the grepping of longer message strings from such source code?
I personally use long strings (because they are less hassle to write), except when they are ridiculously long. But checkpatch complains either way, so checkpatch itself is not a reason to make a change.
Certainly grepping for a complete seq_printf() is unlikely (i.e. you had to open the debugfs file to see it, so you must already know where to look in the code). -Chris
On Thu, May 04, 2017 at 09:12:32PM +0100, Chris Wilson wrote:
On Thu, May 04, 2017 at 06:59:23PM +0200, SF Markus Elfring wrote:
From: Markus Elfring elfring@users.sourceforge.net Date: Thu, 4 May 2017 14:15:00 +0200
The script "checkpatch.pl" pointed information out like the following.
WARNING: quoted string split across lines
Thus fix the affected source code place.
Signed-off-by: Markus Elfring elfring@users.sourceforge.net
drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 6f3119d40c50..dbd52ea89fb4 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b/drivers/gpu/drm/i915/i915_debugfs.c @@ -1529,8 +1529,8 @@ static int gen6_drpc_info(struct seq_file *m)
forcewake_count = READ_ONCE(dev_priv->uncore.fw_domain[FW_DOMAIN_ID_RENDER].wake_count); if (forcewake_count) {
seq_puts(m, "RC information inaccurate because somebody ""holds a forcewake reference \n");
seq_puts(m,"RC information inaccurate because somebody holds a forcewake reference.\n");And now you break the 80col rule. Blind adherence to checkpatch is impossible. -Chris
No. Checkpatch allows you to go over 80 characters to avoid splitting a string.
regards, dan carpenter
dri-devel@lists.freedesktop.org
-
Chris Wilson -
Dan Carpenter -
SF Markus Elfring