This is a preliminary patch for building drm-mipi-dsi as a module. Add the module exit callback to unregister the bus properly.
Suggested-by: Thierry Reding treding@nvidia.com Signed-off-by: Takashi Iwai tiwai@suse.de --- drivers/gpu/drm/drm_mipi_dsi.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c index f5d80839a90c..e2f3441663be 100644 --- a/drivers/gpu/drm/drm_mipi_dsi.c +++ b/drivers/gpu/drm/drm_mipi_dsi.c @@ -1069,6 +1069,12 @@ static int __init mipi_dsi_bus_init(void) } postcore_initcall(mipi_dsi_bus_init);
+static void __exit mipi_dsi_bus_exit(void) +{ + bus_unregister(&mipi_dsi_bus_type); +} +module_exit(mipi_dsi_bus_exit); + MODULE_AUTHOR("Andrzej Hajda a.hajda@samsung.com"); MODULE_DESCRIPTION("MIPI DSI Bus"); MODULE_LICENSE("GPL and additional rights");
The drm-mipi-dsi driver has been only built-in although this isn't strictly required to be so. Since it's referred by lots of DRM drivers nowadays, most of distro kernels include the driver as built-in as a result, even though many systems don't need it at all.
This patch fixes Kconfig to allow drm-mipi-dsi driver built as a module, so that we can save footprint on systems without such DRM drivers. The probe order is managed by the module dependency, and postcore_initcall() works just fine as a module init call.
Signed-off-by: Takashi Iwai tiwai@suse.de --- drivers/gpu/drm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index fc357319de35..67668a04baf6 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -22,7 +22,7 @@ menuconfig DRM (/dev/agpgart) support if it is available for your platform.
config DRM_MIPI_DSI - bool + tristate depends on DRM
config DRM_DP_AUX_CHARDEV
On 08/02/2016 02:16 PM, Takashi Iwai wrote:
This is a preliminary patch for building drm-mipi-dsi as a module. Add the module exit callback to unregister the bus properly.
Suggested-by: Thierry Reding treding@nvidia.com Signed-off-by: Takashi Iwai tiwai@suse.de
For both patches:
Reviewed-by: Andrzej Hajda a.hajda@samsung.com
-- Regards Andrzej
drivers/gpu/drm/drm_mipi_dsi.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c index f5d80839a90c..e2f3441663be 100644 --- a/drivers/gpu/drm/drm_mipi_dsi.c +++ b/drivers/gpu/drm/drm_mipi_dsi.c @@ -1069,6 +1069,12 @@ static int __init mipi_dsi_bus_init(void) } postcore_initcall(mipi_dsi_bus_init);
+static void __exit mipi_dsi_bus_exit(void) +{
- bus_unregister(&mipi_dsi_bus_type);
+} +module_exit(mipi_dsi_bus_exit);
MODULE_AUTHOR("Andrzej Hajda a.hajda@samsung.com"); MODULE_DESCRIPTION("MIPI DSI Bus"); MODULE_LICENSE("GPL and additional rights");
dri-devel@lists.freedesktop.org
-
Andrzej Hajda -
Takashi Iwai