Fix the following coccicheck warning:
./drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c:907:47-52: WARNING: conversion to bool not needed here.
Reported-by: Abaci Robotabaci@linux.alibaba.com Signed-off-by: Jiapeng Chong jiapeng.chong@linux.alibaba.com --- drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c index d68d3df..b364862 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c @@ -904,7 +904,7 @@ static bool sienna_cichlid_is_support_fine_grained_dpm(struct smu_context *smu, dpm_desc = &pptable->DpmDescriptor[clk_index];
/* 0 - Fine grained DPM, 1 - Discrete DPM */ - return dpm_desc->SnapToDiscrete == 0 ? true : false; + return dpm_desc->SnapToDiscrete != 0; }
static int sienna_cichlid_print_clk_levels(struct smu_context *smu,
[AMD Official Use Only - Internal Distribution Only]
if possible, please correct the same issue in navi10_ppt.c
Reviewed-by: Kevin Wang kevin1.wang@amd.com
Best Regards, Kevin ________________________________ From: Jiapeng Chong jiapeng.chong@linux.alibaba.com Sent: Sunday, February 7, 2021 4:49 PM To: Deucher, Alexander Alexander.Deucher@amd.com Cc: Koenig, Christian Christian.Koenig@amd.com; airlied@linux.ie airlied@linux.ie; daniel@ffwll.ch daniel@ffwll.ch; amd-gfx@lists.freedesktop.org amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org linux-kernel@vger.kernel.org; Jiapeng Chong jiapeng.chong@linux.alibaba.com Subject: [PATCH] drm/amd/pm: Remove unnecessary conversion to bool
Fix the following coccicheck warning:
./drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c:907:47-52: WARNING: conversion to bool not needed here.
Reported-by: Abaci Robotabaci@linux.alibaba.com Signed-off-by: Jiapeng Chong jiapeng.chong@linux.alibaba.com --- drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c index d68d3df..b364862 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c @@ -904,7 +904,7 @@ static bool sienna_cichlid_is_support_fine_grained_dpm(struct smu_context *smu, dpm_desc = &pptable->DpmDescriptor[clk_index];
/* 0 - Fine grained DPM, 1 - Discrete DPM */ - return dpm_desc->SnapToDiscrete == 0 ? true : false; + return dpm_desc->SnapToDiscrete != 0; }
static int sienna_cichlid_print_clk_levels(struct smu_context *smu, -- 1.8.3.1
dri-devel@lists.freedesktop.org
-
Jiapeng Chong -
Wang, Kevin(Yang)