On Mon, Dec 30, 2019 at 2:41 PM Wambui Karuga wambui.karugax@gmail.com wrote:

As the if statement only checks for the value of the offset_name variable, it can be replaced by the more conscise BUG_ON macro for error reporting.

Signed-off-by: Wambui Karuga wambui.karugax@gmail.com

drivers/gpu/drm/msm/adreno/adreno_gpu.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/adreno/adreno_gpu.h index c7441fb8313e..0fe7907f5a7d 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h @@ -315,10 +315,7 @@ OUT_PKT7(struct msm_ringbuffer *ring, uint8_t opcode, uint16_t cnt) static inline bool adreno_reg_check(struct adreno_gpu *gpu, enum adreno_regs offset_name) {

•   if (offset_name >= REG_ADRENO_REGISTER_MAX ||
  

•                   !gpu->reg_offsets[offset_name]) {
  

•           BUG();
  

•   }
  

•   BUG_ON(offset_name >= REG_ADRENO_REGISTER_MAX || !gpu->reg_offsets[offset_name]);
  
  

Minor nit: This line is longer than 80 chars

Other than that,

Reviewed-by: Sean Paul sean@poorly.run

    /*
     * REG_SKIP is a special value that tell us that the register in

-- 2.17.1