Dan,

On 02/26/2016 05:30 AM, Dan Carpenter wrote:

We were accidentally returning PTR_ERR(NULL) which means success when we wanted to return a negative error code.

Fixes: 412d4ae6b7a5 ('drm/rockchip: hdmi: add Innosilicon HDMI support') Signed-off-by: Dan Carpenter dan.carpenter@oracle.com

Reviewed-by: Yakir Yang ykk@rock-chips.com

Thanks, - Yakir

diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c index 10d62ff..f252441 100644 --- a/drivers/gpu/drm/rockchip/inno_hdmi.c +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c @@ -855,8 +855,9 @@ static int inno_hdmi_bind(struct device *dev, struct device *master,

hdmi->ddc = inno_hdmi_i2c_adapter(hdmi); if (IS_ERR(hdmi->ddc)) {

• ret = PTR_ERR(hdmi->ddc);
  

  hdmi->ddc = NULL;

• return PTR_ERR(hdmi->ddc);
  

• return ret;
  

  }

  /*