Hi guys,
This warning in the radeon driver breaks my randconfig build on v5.19-rc2:
drivers/gpu/drm/radeon/radeon_object.c:186:2: error: #warning Please enable CONFIG_MTRR and CONFIG_X86_PAT for better performance thanks to write-combining [;;https://gcc.gnu.org/onl inedocs/gcc/Warning-Options.html#index-Wcpp-Werror=cpp;;]
Is anything being done to fix it? I don't see anything in -next or on dridevel list recently which it could be.
thanks, John
Hi John,
well, this warning is intentional.
The key point is that your random config results in a very suboptimal situation where the graphics driver only barely work.
And radeon is pointing that out with this warning. That is totally expected behavior.
Regards, Christian.
Am 17.06.22 um 12:57 schrieb John Garry:
Hi guys,
This warning in the radeon driver breaks my randconfig build on v5.19-rc2:
drivers/gpu/drm/radeon/radeon_object.c:186:2: error: #warning Please enable CONFIG_MTRR and CONFIG_X86_PAT for better performance thanks to write-combining [;;https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgcc.gnu.or... inedocs/gcc/Warning-Options.html#index-Wcpp-Werror=cpp;;]
Is anything being done to fix it? I don't see anything in -next or on dridevel list recently which it could be.
thanks, John
Hi Christian,
well, this warning is intentional.
The key point is that your random config results in a very suboptimal situation where the graphics driver only barely work.
ok
And radeon is pointing that out with this warning. That is totally expected behavior.
Sure, but I don't think that it should break the build.
Can you add a boot-time warning message instead?
And/Or compile out the warning when "warnings = errors"?
All the best, John
Regards, Christian.
Am 17.06.22 um 12:57 schrieb John Garry:
Hi guys,
This warning in the radeon driver breaks my randconfig build on v5.19-rc2:
drivers/gpu/drm/radeon/radeon_object.c:186:2: error: #warning Please enable CONFIG_MTRR and CONFIG_X86_PAT for better performance thanks to write-combining [;;https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgcc.gnu.or...
inedocs/gcc/Warning-Options.html#index-Wcpp-Werror=cpp;;]
Is anything being done to fix it? I don't see anything in -next or on dridevel list recently which it could be.
thanks, John
.
Hi John,
Am 17.06.22 um 13:52 schrieb John Garry:
Hi Christian,
well, this warning is intentional.
The key point is that your random config results in a very suboptimal situation where the graphics driver only barely work.
ok
And radeon is pointing that out with this warning. That is totally expected behavior.
Sure, but I don't think that it should break the build.
well, this doesn't break the build we already have that for years.
What breaks the build now is that warnings are handled as errors.
Can you add a boot-time warning message instead?
Yes, we already have that as well.
And/Or compile out the warning when "warnings = errors"?
That should be doable I think.
Regards, Christian.
All the best, John
Regards, Christian.
Am 17.06.22 um 12:57 schrieb John Garry:
Hi guys,
This warning in the radeon driver breaks my randconfig build on v5.19-rc2:
drivers/gpu/drm/radeon/radeon_object.c:186:2: error: #warning Please enable CONFIG_MTRR and CONFIG_X86_PAT for better performance thanks to write-combining [;;https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgcc.gnu.or...
inedocs/gcc/Warning-Options.html#index-Wcpp-Werror=cpp;;]
Is anything being done to fix it? I don't see anything in -next or on dridevel list recently which it could be.
thanks, John
.
On 17/06/2022 12:57, Christian König wrote:
Hi Christian,
Sure, but I don't think that it should break the build.
well, this doesn't break the build we already have that for years.
What breaks the build now is that warnings are handled as errors.
ok
Can you add a boot-time warning message instead?
Yes, we already have that as well.
And/Or compile out the warning when "warnings = errors"?
That should be doable I think.
ok, if something can be done then I would appreciate it. I do much randconfig builds as part of my upstream process and anything breaking is a bit of a pain.
Thanks!
Hi John,
Am 17.06.22 um 14:01 schrieb John Garry:
On 17/06/2022 12:57, Christian König wrote:
And/Or compile out the warning when "warnings = errors"?
That should be doable I think.
ok, if something can be done then I would appreciate it. I do much randconfig builds as part of my upstream process and anything breaking is a bit of a pain.
I've just double checked the code and we have already wrapped the warning into "#ifndef CONFIG_COMPILE_TEST".
So the question is why does your random config not set CONFIG_COMPILE_TEST?
Regards, Christian.
Thanks!
Hi Christian,
Am 17.06.22 um 14:01 schrieb John Garry:
On 17/06/2022 12:57, Christian König wrote:
And/Or compile out the warning when "warnings = errors"?
That should be doable I think.
ok, if something can be done then I would appreciate it. I do much randconfig builds as part of my upstream process and anything breaking is a bit of a pain.
I've just double checked the code and we have already wrapped the warning into "#ifndef CONFIG_COMPILE_TEST".
Yes
So the question is why does your random config not set CONFIG_COMPILE_TEST?
My randconfig does not have CONFIG_COMPILE_TEST set - see attached. AFAIK randconfig does not always set CONFIG_COMPILE_TEST.
Thanks, John
Am 17.06.22 um 16:22 schrieb John Garry:
Hi Christian,
Am 17.06.22 um 14:01 schrieb John Garry:
On 17/06/2022 12:57, Christian König wrote:
And/Or compile out the warning when "warnings = errors"?
That should be doable I think.
ok, if something can be done then I would appreciate it. I do much randconfig builds as part of my upstream process and anything breaking is a bit of a pain.
I've just double checked the code and we have already wrapped the warning into "#ifndef CONFIG_COMPILE_TEST".
Yes
So the question is why does your random config not set CONFIG_COMPILE_TEST?
My randconfig does not have CONFIG_COMPILE_TEST set - see attached. AFAIK randconfig does not always set CONFIG_COMPILE_TEST.
Mhm, we could probably change the ifdef. But a random configuration which doesn't sets CONFIG_COMPILE_TEST sounds like a bug to me as well.
Going to provide a patch for changing the ifdef, but not sure when I will have time for that.
Regards, Christian.
Thanks, John
On 20/06/2022 10:01, Christian König wrote:
So the question is why does your random config not set CONFIG_COMPILE_TEST?
My randconfig does not have CONFIG_COMPILE_TEST set - see attached. AFAIK randconfig does not always set CONFIG_COMPILE_TEST.
Mhm, we could probably change the ifdef. But a random configuration which doesn't sets CONFIG_COMPILE_TEST sounds like a bug to me as well.
Hmmm ... not sure. I just think that the whole point is that it is purely random - if we want better coverage for building then allmodconfig is there.
Going to provide a patch for changing the ifdef, but not sure when I will have time for th
ok, thanks. In the meantime I'll add a local patch to remove the warning.
Thanks, John
dri-devel@lists.freedesktop.org
-
Christian König -
Christian König -
John Garry