exynos_dpi_of_find_panel_node is local to this file.
Signed-off-by: Sachin Kamat sachin.kamat@linaro.org --- These patches are based on Inki Dae's tree (exynos-drm-next branch). --- drivers/gpu/drm/exynos/exynos_drm_dpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dpi.c b/drivers/gpu/drm/exynos/exynos_drm_dpi.c index 03cb126..aefc828 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dpi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dpi.c @@ -242,7 +242,7 @@ enum { FIMD_PORT_WRB, };
-struct device_node *exynos_dpi_of_find_panel_node(struct device *dev) +static struct device_node *exynos_dpi_of_find_panel_node(struct device *dev) { struct device_node *np, *ep;
i2c.h was included twice.
Signed-off-by: Sachin Kamat sachin.kamat@linaro.org --- drivers/gpu/drm/exynos/exynos_hdmi.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index ed6176e..d3f9684 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c @@ -34,7 +34,6 @@ #include <linux/io.h> #include <linux/of.h> #include <linux/of_address.h> -#include <linux/i2c.h> #include <linux/of_gpio.h> #include <linux/hdmi.h> #include <linux/component.h>
Hi Sachin,
On 05/22/2014 07:02 AM, Sachin Kamat wrote:
i2c.h was included twice.
Signed-off-by: Sachin Kamat sachin.kamat@linaro.org
drivers/gpu/drm/exynos/exynos_hdmi.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index ed6176e..d3f9684 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c @@ -34,7 +34,6 @@ #include <linux/io.h> #include <linux/of.h> #include <linux/of_address.h> -#include <linux/i2c.h> #include <linux/of_gpio.h> #include <linux/hdmi.h> #include <linux/component.h>
It would be also good to order headers alphabetically.
Regards Andrzej
Hi Andrzej,
On 23 May 2014 13:17, Andrzej Hajda a.hajda@samsung.com wrote:
Hi Sachin,
On 05/22/2014 07:02 AM, Sachin Kamat wrote:
i2c.h was included twice.
Signed-off-by: Sachin Kamat sachin.kamat@linaro.org
drivers/gpu/drm/exynos/exynos_hdmi.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index ed6176e..d3f9684 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c @@ -34,7 +34,6 @@ #include <linux/io.h> #include <linux/of.h> #include <linux/of_address.h> -#include <linux/i2c.h> #include <linux/of_gpio.h> #include <linux/hdmi.h> #include <linux/component.h>
It would be also good to order headers alphabetically.
That is outside the scope of this patch and can be taken up separately if needed.
These symbols are local to this file.
Signed-off-by: Sachin Kamat sachin.kamat@linaro.org --- drivers/gpu/drm/exynos/exynos_hdmi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index d3f9684..220f048 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c @@ -576,21 +576,21 @@ static const struct hdmiphy_config hdmiphy_5420_configs[] = { }, };
-struct hdmi_driver_data exynos5420_hdmi_driver_data = { +static struct hdmi_driver_data exynos5420_hdmi_driver_data = { .type = HDMI_TYPE14, .phy_confs = hdmiphy_5420_configs, .phy_conf_count = ARRAY_SIZE(hdmiphy_5420_configs), .is_apb_phy = 1, };
-struct hdmi_driver_data exynos4212_hdmi_driver_data = { +static struct hdmi_driver_data exynos4212_hdmi_driver_data = { .type = HDMI_TYPE14, .phy_confs = hdmiphy_v14_configs, .phy_conf_count = ARRAY_SIZE(hdmiphy_v14_configs), .is_apb_phy = 0, };
-struct hdmi_driver_data exynos5_hdmi_driver_data = { +static struct hdmi_driver_data exynos5_hdmi_driver_data = { .type = HDMI_TYPE14, .phy_confs = hdmiphy_v13_configs, .phy_conf_count = ARRAY_SIZE(hdmiphy_v13_configs),
dri-devel@lists.freedesktop.org
-
Andrzej Hajda -
Sachin Kamat