It's a bit silly to have to spec both -d and -f to see what dim would all complain about. And dry-run should never cause bad side-effects.
Signed-off-by: Daniel Vetter daniel.vetter@intel.com --- dim | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/dim b/dim index c0cbe352b165..96aaf7101d6b 100755 --- a/dim +++ b/dim @@ -126,6 +126,8 @@ function warn_or_fail { if [[ $FORCE ]] ; then echoerr "WARNING: $1, but continuing" + elif [[ $DRY ]] ; then + echoerr "WARNING: $1, but continuing dry-run" else echoerr "ERROR: $1, aborting" exit 1
On Thu, 27 Jul 2017, Daniel Vetter daniel.vetter@ffwll.ch wrote:
It's a bit silly to have to spec both -d and -f to see what dim would all complain about. And dry-run should never cause bad side-effects.
Ack.
We don't do dry-run all that well in general, partly because you need to have one part actually succeed to make the rest succeed. And some things don't do dry-run at all. Those could bail out with an error right away. To the endless todo list...
BR, Jani.
Signed-off-by: Daniel Vetter daniel.vetter@intel.com
dim | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/dim b/dim index c0cbe352b165..96aaf7101d6b 100755 --- a/dim +++ b/dim @@ -126,6 +126,8 @@ function warn_or_fail { if [[ $FORCE ]] ; then echoerr "WARNING: $1, but continuing"
- elif [[ $DRY ]] ; then
echoerr "WARNING: $1, but continuing dry-run"
On Thu, Aug 3, 2017 at 2:44 PM, Jani Nikula jani.nikula@linux.intel.com wrote:
On Thu, 27 Jul 2017, Daniel Vetter daniel.vetter@ffwll.ch wrote:
It's a bit silly to have to spec both -d and -f to see what dim would all complain about. And dry-run should never cause bad side-effects.
Ack.
We don't do dry-run all that well in general, partly because you need to have one part actually succeed to make the rest succeed. And some things don't do dry-run at all. Those could bail out with an error right away. To the endless todo list...
Yeah, one of the biggest things I'd like to see is dim push-branch not pushing until the dry-run (and entirely offline) rebuild-tip succeeded. I think otherwise we're fairly good with dry-runs ... -Daniel
BR, Jani.
Signed-off-by: Daniel Vetter daniel.vetter@intel.com
dim | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/dim b/dim index c0cbe352b165..96aaf7101d6b 100755 --- a/dim +++ b/dim @@ -126,6 +126,8 @@ function warn_or_fail { if [[ $FORCE ]] ; then echoerr "WARNING: $1, but continuing"
elif [[ $DRY ]] ; thenechoerr "WARNING: $1, but continuing dry-run" else echoerr "ERROR: $1, aborting" exit 1-- Jani Nikula, Intel Open Source Technology Center
dri-devel@lists.freedesktop.org
-
Daniel Vetter -
Jani Nikula