Add @cookie to dma_fence_end_signalling() to prevent kernel-doc warning in drivers/dma-buf/dma-fence.c:
../drivers/dma-buf/dma-fence.c:291: warning: Function parameter or member 'cookie' not described in 'dma_fence_end_signalling'
Signed-off-by: Randy Dunlap rdunlap@infradead.org Cc: Sumit Semwal sumit.semwal@linaro.org Cc: Gustavo Padovan gustavo@padovan.org Cc: Christian König christian.koenig@amd.com Cc: linux-media@vger.kernel.org Cc: dri-devel@lists.freedesktop.org --- drivers/dma-buf/dma-fence.c | 1 + 1 file changed, 1 insertion(+)
--- lnx-59-rc3.orig/drivers/dma-buf/dma-fence.c +++ lnx-59-rc3/drivers/dma-buf/dma-fence.c @@ -283,6 +283,7 @@ EXPORT_SYMBOL(dma_fence_begin_signalling
/** * dma_fence_end_signalling - end a critical DMA fence signalling section + * @cookie: opaque cookie from dma_fence_begin_signalling() * * Closes a critical section annotation opened by dma_fence_begin_signalling(). */
Am 31.08.20 um 06:17 schrieb Randy Dunlap:
Add @cookie to dma_fence_end_signalling() to prevent kernel-doc warning in drivers/dma-buf/dma-fence.c:
../drivers/dma-buf/dma-fence.c:291: warning: Function parameter or member 'cookie' not described in 'dma_fence_end_signalling'
Signed-off-by: Randy Dunlap rdunlap@infradead.org Cc: Sumit Semwal sumit.semwal@linaro.org Cc: Gustavo Padovan gustavo@padovan.org Cc: Christian König christian.koenig@amd.com Cc: linux-media@vger.kernel.org Cc: dri-devel@lists.freedesktop.org
Acked-by: Christian König christian.koenig@amd.com
drivers/dma-buf/dma-fence.c | 1 + 1 file changed, 1 insertion(+)
--- lnx-59-rc3.orig/drivers/dma-buf/dma-fence.c +++ lnx-59-rc3/drivers/dma-buf/dma-fence.c @@ -283,6 +283,7 @@ EXPORT_SYMBOL(dma_fence_begin_signalling
/**
- dma_fence_end_signalling - end a critical DMA fence signalling section
*/
- @cookie: opaque cookie from dma_fence_begin_signalling()
- Closes a critical section annotation opened by dma_fence_begin_signalling().
On Mon, Aug 31, 2020 at 12:02:03PM +0200, Christian König wrote:
Am 31.08.20 um 06:17 schrieb Randy Dunlap:
Add @cookie to dma_fence_end_signalling() to prevent kernel-doc warning in drivers/dma-buf/dma-fence.c:
../drivers/dma-buf/dma-fence.c:291: warning: Function parameter or member 'cookie' not described in 'dma_fence_end_signalling'
Signed-off-by: Randy Dunlap rdunlap@infradead.org Cc: Sumit Semwal sumit.semwal@linaro.org Cc: Gustavo Padovan gustavo@padovan.org Cc: Christian König christian.koenig@amd.com Cc: linux-media@vger.kernel.org Cc: dri-devel@lists.freedesktop.org
Acked-by: Christian König christian.koenig@amd.com
Will you merge these two to drm-misc-fixes or should someone else?
Always a bit confusing when maintainers reply with acks/r-b but not what they'll do with the patch :-)
Cheers, Daniel
drivers/dma-buf/dma-fence.c | 1 + 1 file changed, 1 insertion(+)
--- lnx-59-rc3.orig/drivers/dma-buf/dma-fence.c +++ lnx-59-rc3/drivers/dma-buf/dma-fence.c @@ -283,6 +283,7 @@ EXPORT_SYMBOL(dma_fence_begin_signalling /**
- dma_fence_end_signalling - end a critical DMA fence signalling section
*/
- @cookie: opaque cookie from dma_fence_begin_signalling()
- Closes a critical section annotation opened by dma_fence_begin_signalling().
dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Am 01.09.20 um 15:32 schrieb Daniel Vetter:
On Mon, Aug 31, 2020 at 12:02:03PM +0200, Christian König wrote:
Am 31.08.20 um 06:17 schrieb Randy Dunlap:
Add @cookie to dma_fence_end_signalling() to prevent kernel-doc warning in drivers/dma-buf/dma-fence.c:
../drivers/dma-buf/dma-fence.c:291: warning: Function parameter or member 'cookie' not described in 'dma_fence_end_signalling'
Signed-off-by: Randy Dunlap rdunlap@infradead.org Cc: Sumit Semwal sumit.semwal@linaro.org Cc: Gustavo Padovan gustavo@padovan.org Cc: Christian König christian.koenig@amd.com Cc: linux-media@vger.kernel.org Cc: dri-devel@lists.freedesktop.org
Acked-by: Christian König christian.koenig@amd.com
Will you merge these two to drm-misc-fixes or should someone else?
I was wondering the same thing and just waiting for Randy to reply with please pick them up or I'm going to push them because I have commit access.
Regards, Christian.
Always a bit confusing when maintainers reply with acks/r-b but not what they'll do with the patch :-)
Cheers, Daniel
drivers/dma-buf/dma-fence.c | 1 + 1 file changed, 1 insertion(+)
--- lnx-59-rc3.orig/drivers/dma-buf/dma-fence.c +++ lnx-59-rc3/drivers/dma-buf/dma-fence.c @@ -283,6 +283,7 @@ EXPORT_SYMBOL(dma_fence_begin_signalling /** * dma_fence_end_signalling - end a critical DMA fence signalling section
- @cookie: opaque cookie from dma_fence_begin_signalling()
*/
- Closes a critical section annotation opened by dma_fence_begin_signalling().
dri-devel mailing list dri-devel@lists.freedesktop.org https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.free...
On 9/1/20 6:37 AM, Christian König wrote:
Am 01.09.20 um 15:32 schrieb Daniel Vetter:
On Mon, Aug 31, 2020 at 12:02:03PM +0200, Christian König wrote:
Am 31.08.20 um 06:17 schrieb Randy Dunlap:
Add @cookie to dma_fence_end_signalling() to prevent kernel-doc warning in drivers/dma-buf/dma-fence.c:
../drivers/dma-buf/dma-fence.c:291: warning: Function parameter or member 'cookie' not described in 'dma_fence_end_signalling'
Signed-off-by: Randy Dunlap rdunlap@infradead.org Cc: Sumit Semwal sumit.semwal@linaro.org Cc: Gustavo Padovan gustavo@padovan.org Cc: Christian König christian.koenig@amd.com Cc: linux-media@vger.kernel.org Cc: dri-devel@lists.freedesktop.org
Acked-by: Christian König christian.koenig@amd.com
Will you merge these two to drm-misc-fixes or should someone else?
I was wondering the same thing and just waiting for Randy to reply with please pick them up or I'm going to push them because I have commit access.
I didn't realize that was needed, but anyway, Christian, please apply these 2 dma-buf kernel-doc patches.
thanks.
Regards, Christian.
Always a bit confusing when maintainers reply with acks/r-b but not what they'll do with the patch :-)
Agreed.
Cheers, Daniel
drivers/dma-buf/dma-fence.c | 1 + 1 file changed, 1 insertion(+)
--- lnx-59-rc3.orig/drivers/dma-buf/dma-fence.c +++ lnx-59-rc3/drivers/dma-buf/dma-fence.c @@ -283,6 +283,7 @@ EXPORT_SYMBOL(dma_fence_begin_signalling /** * dma_fence_end_signalling - end a critical DMA fence signalling section
- @cookie: opaque cookie from dma_fence_begin_signalling()
* * Closes a critical section annotation opened by dma_fence_begin_signalling(). */
dri-devel mailing list dri-devel@lists.freedesktop.org
dri-devel@lists.freedesktop.org
-
Christian König -
Daniel Vetter -
Randy Dunlap