When of_property_read_u32_array() returns an error code, a pairing refcount decrement is needed to keep np's refcount balanced.
Fixes: f705806c9f355 ("backlight: Add support Skyworks SKY81452 backlight driver") Signed-off-by: Dinghao Liu dinghao.liu@zju.edu.cn --- drivers/video/backlight/sky81452-backlight.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/sky81452-backlight.c b/drivers/video/backlight/sky81452-backlight.c index 0ce181585008..8268ac43d54f 100644 --- a/drivers/video/backlight/sky81452-backlight.c +++ b/drivers/video/backlight/sky81452-backlight.c @@ -217,6 +217,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt( num_entry); if (ret < 0) { dev_err(dev, "led-sources node is invalid.\n"); + of_node_put(np); return ERR_PTR(-EINVAL); }
On Wed, Aug 19, 2020 at 11:04:56AM +0800, Dinghao Liu wrote:
When of_property_read_u32_array() returns an error code, a pairing refcount decrement is needed to keep np's refcount balanced.
Fixes: f705806c9f355 ("backlight: Add support Skyworks SKY81452 backlight driver") Signed-off-by: Dinghao Liu dinghao.liu@zju.edu.cn
Reviewed-by: Daniel Thompson daniel.thompson@linaro.org
drivers/video/backlight/sky81452-backlight.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/sky81452-backlight.c b/drivers/video/backlight/sky81452-backlight.c index 0ce181585008..8268ac43d54f 100644 --- a/drivers/video/backlight/sky81452-backlight.c +++ b/drivers/video/backlight/sky81452-backlight.c @@ -217,6 +217,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt( num_entry); if (ret < 0) { dev_err(dev, "led-sources node is invalid.\n");
of_node_put(np); return ERR_PTR(-EINVAL);-- 2.17.1
dri-devel@lists.freedesktop.org
-
Daniel Thompson -
Dinghao Liu