Hi,
I’m from Silicon Motion Technology Corporation (NasdaqGS:SIMO) Shanghai Office. We have developed a kernel driver for all our graphics chips. We really want to know the way to submit a kernel driver to kernel.org. I have received a document file which is on http://kernel.org/doc/Documentation/SubmittingDrivers, but I still cannot find out a place to where our drivers should be uploaded. The document say “please submit it to the maintainer listed in MAINTAINERS in the kernel file.”So where can I find the maintainer and what to do next. Would you please help me. Thank you so much.
Regards Aaron
On Thu, 2012-03-01 at 14:28 +0800, Aaron.Chen 陈俊杰 wrote:
Hi,
I’m from Silicon Motion Technology Corporation (NasdaqGS:SIMO) Shanghai Office. We have developed a kernel driver for all our graphics chips. We really want to know the way to submit a kernel driver to kernel.org. I have received a document file which is on http://kernel.org/doc/Documentation/SubmittingDrivers, but I still cannot find out a place to where our drivers should be uploaded. The document say “please submit it to the maintainer listed in MAINTAINERS in the kernel file.”So where can I find the maintainer and what to do next. Would you please help me. Thank you so much.
Regards Aaron
All you need to do is send the kernel patch to dri-devel@lists.freedesktop.org
So they can get reviewed. Once they are reviewed, and if they comply with the requirement, the DRM maintainer (aka Dave) will integrate your patch in his tree and at some point ask Linus to pull them.
There is no ftp, or http web submission, everything is done through public mailing list.
Cheers, Jerome
Dear Aaron,
thank you for contacting the list. We are looking forward to your patches.
Am Donnerstag, den 01.03.2012, 14:05 -0500 schrieb Jerome Glisse:
On Thu, 2012-03-01 at 14:28 +0800, Aaron.Chen 陈俊杰 wrote:
I’m from Silicon Motion Technology Corporation (NasdaqGS:SIMO) Shanghai Office. We have developed a kernel driver for all our graphics chips. We really want to know the way to submit a kernel driver to kernel.org. I have received a document file which is on http://kernel.org/doc/Documentation/SubmittingDrivers, but I still cannot find out a place to where our drivers should be uploaded. The document say “please submit it to the maintainer listed in MAINTAINERS in the kernel file.”So where can I find the maintainer and what to do next. Would you please help me. Thank you so much.
All you need to do is send the kernel patch to dri-devel@lists.freedesktop.org
So they can get reviewed. Once they are reviewed, and if they comply with the requirement, the DRM maintainer (aka Dave) will integrate your patch in his tree and at some point ask Linus to pull them.
There is no ftp, or http web submission, everything is done through public mailing list.
if you are familiar with Git you should send a patch formatted using `git format-patch -15`. Replace the 15 by the number of commits you need patches for.
You can take a look in the archive. drm/exynos and drm/omap are good examples – I think – on how to get new drivers submitted.
Thanks,
Paul
PS: Please also try to follow the netiquette when posting to lists [1]. Especially just send plain text messages (no HTML).
Hi Paul&Jerome,
Thank you very much for your guide. It's a great help for me.
But I still have a little problem with the patch thing. I'm not familiar with the git. 1.Shall I need to do the clone and get the source location and target directory first? 2.Where is the source location and target directory? 3.Our driver has pass the customer's test from kernel version 2.6.5 to 3.0.0, So what shall I do to submit a driver cover all these kernel version. 4.or just email you the source code and tell you the changes?
I'm looking forward your re-guide. Thank you so much.
Regards Aaron
-----邮件原件----- 发件人: Paul Menzel [mailto:paulepanter@users.sourceforge.net] 发送时间: 2012年3月2日 5:50 收件人: Jerome Glisse 抄送: Aaron.Chen 陈俊杰; dri-devel@lists.freedesktop.org 主题: Re: [korg]help: How to submit a kernel driver on kernel.org.
Dear Aaron,
thank you for contacting the list. We are looking forward to your patches.
Am Donnerstag, den 01.03.2012, 14:05 -0500 schrieb Jerome Glisse:
On Thu, 2012-03-01 at 14:28 +0800, Aaron.Chen 陈俊杰 wrote:
I’m from Silicon Motion Technology Corporation (NasdaqGS:SIMO) Shanghai Office. We have developed a kernel driver for all our graphics chips. We really want to know the way to submit a kernel driver to kernel.org. I have received a document file which is on http://kernel.org/doc/Documentation/SubmittingDrivers, but I still cannot find out a place to where our drivers should be uploaded. The document say “please submit it to the maintainer listed in MAINTAINERS in the kernel file.”So where can I find the maintainer and what to do next. Would you please help me. Thank you so much.
All you need to do is send the kernel patch to dri-devel@lists.freedesktop.org
So they can get reviewed. Once they are reviewed, and if they comply with the requirement, the DRM maintainer (aka Dave) will integrate your patch in his tree and at some point ask Linus to pull them.
There is no ftp, or http web submission, everything is done through public mailing list.
if you are familiar with Git you should send a patch formatted using `git format-patch -15`. Replace the 15 by the number of commits you need patches for.
You can take a look in the archive. drm/exynos and drm/omap are good examples – I think – on how to get new drivers submitted.
Thanks,
Paul
PS: Please also try to follow the netiquette when posting to lists [1]. Especially just send plain text messages (no HTML).
On Mon, Mar 5, 2012 at 11:13 PM, Aaron.Chen �¿��� aaron.chen@siliconmotion.com wrote:
Hi Paul&Jerome,
Thank you very much for your guide. It's a great help for me.
But I still have a little problem with the patch thing. I'm not familiar with the git. 1.Shall I need to do the clone and get the source location and target directory first? 2.Where is the source location and target directory? 3.Our driver has pass the customer's test from kernel version 2.6.5 to 3.0.0, So what shall I do to submit a driver cover all these kernel version. 4.or just email you the source code and tell you the changes?
I'm looking forward your re-guide. Thank you so much.
Your best bet it to clone Linus' git tree and then apply your patches:
1. clone Linus' git tree: git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 2. a) apply your first patch b) if you patch adds new files to the source tree, add them: git add path/to/files/file.c git add path/to/files/file.h etc. if the patch only modifies patches that are already in the tree, you do not need to add them. c) when the patch is applied commit it: git commit -a -s d) when you run the commit command you will be prompted to enter a commit message. The commit message has the following format:
subsystem: patch description
description of what the patch does.
Signed-off-by: Your name your_email@domain.com
E.g.,
fb: add initial code for video 5000 graphics
This adds the initial support for the video 5000 graphics adapter. It supports vga and lcd connectors.
Signed-off-by: Joe Developer joe.developer@example.com
e) repeat steps a-d for all of your patches 3. generate patches: git format-patch -n
where n is the number of patches you committed. E.g., if your driver consists of 5 patches: git format-patch -5
4. Send the patches to the list.
Alex
Regards Aaron
-----�ʼ�ԭ��----- ������: Paul Menzel [mailto:paulepanter@users.sourceforge.net] ����ʱ��: 2012��3��2�� 5:50 �ռ���: Jerome Glisse ����: Aaron.Chen �¿���; dri-devel@lists.freedesktop.org ����: Re: [korg]help: How to submit a kernel driver on kernel.org.
Dear Aaron,
thank you for contacting the list. We are looking forward to your patches.
Am Donnerstag, den 01.03.2012, 14:05 -0500 schrieb Jerome Glisse:
On Thu, 2012-03-01 at 14:28 +0800, Aaron.Chen �¿��� wrote:
I��m from Silicon Motion Technology Corporation (NasdaqGS:SIMO) Shanghai Office. We have developed a kernel driver for all our graphics chips. We really want to know the way to submit a kernel driver to kernel.org. I have received a document file which is on http://kernel.org/doc/Documentation/SubmittingDrivers, but I still cannot find out a place to where our drivers should be uploaded. The document say ��please submit it to the maintainer listed in MAINTAINERS in the kernel file.��So where can I find the maintainer and what to do next. Would you please help me. Thank you so much.
All you need to do is send the kernel patch to dri-devel@lists.freedesktop.org
So they can get reviewed. Once they are reviewed, and if they comply with the requirement, the DRM maintainer (aka Dave) will integrate your patch in his tree and at some point ask Linus to pull them.
There is no ftp, or http web submission, everything is done through public mailing list.
if you are familiar with Git you should send a patch formatted using `git format-patch -15`. Replace the 15 by the number of commits you need patches for.
You can take a look in the archive. drm/exynos and drm/omap are good examples �C I think �C on how to get new drivers submitted.
Thanks,
Paul
PS: Please also try to follow the netiquette when posting to lists [1]. Especially just send plain text messages (no HTML).
[1] http://en.opensuse.org/openSUSE:Mailing_list_netiquette _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Dear Aaron,
Am Dienstag, den 06.03.2012, 08:47 -0500 schrieb Alex Deucher:
On Mon, Mar 5, 2012 at 11:13 PM, Aaron.Chen 陈俊杰 wrote:
Thank you very much for your guide. It's a great help for me.
But I still have a little problem with the patch thing. I'm not familiar with the git. 1.Shall I need to do the clone and get the source location and target directory first? 2.Where is the source location and target directory? 3.Our driver has pass the customer's test from kernel version 2.6.5 to 3.0.0, So what shall I do to submit a driver cover all these kernel version.
you can only get new features included upstream in the latest Linux kernel. So earliest version would be 3.4. You have to maintain you own repository for earlier version. But backporting should be not so much trouble if you have it included upstream.
4.or just email you the source code and tell you the changes?
I'm looking forward your re-guide. Thank you so much.
Your best bet it to clone Linus' git tree and then apply your patches:
- clone Linus' git tree: git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
you can do this in between.
cd linux git config --global user.name "陈俊杰 (Aaron Chen)" git config --global user.email aaron.chen@siliconmotion.com
- a) apply your first patch b) if you patch adds new files to the source tree, add them: git add path/to/files/file.c git add path/to/files/file.h etc. if the patch only modifies patches that are already
in the tree, you do not need to add them. c) when the patch is applied commit it: git commit -a -s d) when you run the commit command you will be prompted to enter a commit message. The commit message has the following format:
subsystem: patch description
description of what the patch does.
Signed-off-by: Your name your_email@domain.com
E.g.,
fb: add initial code for video 5000 graphics
This adds the initial support for the video 5000 graphics adapter. It supports vga and lcd connectors.
Signed-off-by: Joe Developer joe.developer@example.com
e) repeat steps a-d for all of your patches
- generate patches:
git format-patch -n
where n is the number of patches you committed. E.g., if your driver consists of 5 patches: git format-patch -5
- Send the patches to the list.
Aaron, Git is nowadays documented pretty well. So just use
git help command
(like `git help commit`) to read the manual. Additionally you can just search for it using your favorite search engine. Interesting reads should be [1][2][3].
Thanks,
Paul
[1] http://schacon.github.com/git/user-manual.html#cleaning-up-history [2] http://git-scm.com/documentation [3] http://progit.org/book/
Hi Paul&Alex,
Thank you very much for your great help.
Here is the first patch.
Regards Aaron
-----邮件原件----- 发件人: Paul Menzel [mailto:paulepanter@users.sourceforge.net] 发送时间: 2012年3月6日 22:38 收件人: Alex Deucher 抄送: Aaron.Chen 陈俊杰; caesar.qiu 裘赛海; dri-devel@lists.freedesktop.org 主题: Re: [korg]help: How to submit a kernel driver on kernel.org.
Dear Aaron,
Am Dienstag, den 06.03.2012, 08:47 -0500 schrieb Alex Deucher:
On Mon, Mar 5, 2012 at 11:13 PM, Aaron.Chen 陈俊杰 wrote:
Thank you very much for your guide. It's a great help for me.
But I still have a little problem with the patch thing. I'm not familiar with the git. 1.Shall I need to do the clone and get the source location and target directory first? 2.Where is the source location and target directory? 3.Our driver has pass the customer's test from kernel version 2.6.5 to 3.0.0, So what shall I do to submit a driver cover all these kernel version.
you can only get new features included upstream in the latest Linux kernel. So earliest version would be 3.4. You have to maintain you own repository for earlier version. But backporting should be not so much trouble if you have it included upstream.
4.or just email you the source code and tell you the changes?
I'm looking forward your re-guide. Thank you so much.
Your best bet it to clone Linus' git tree and then apply your patches:
- clone Linus' git tree: git clone
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
you can do this in between.
cd linux git config --global user.name "陈俊杰 (Aaron Chen)" git config --global user.email aaron.chen@siliconmotion.com
- a) apply your first patch b) if you patch adds new files to the source tree, add them: git add path/to/files/file.c git add path/to/files/file.h etc. if the patch only modifies patches that are already
in the tree, you do not need to add them. c) when the patch is applied commit it: git commit -a -s d) when you run the commit command you will be prompted to enter a commit message. The commit message has the following format:
subsystem: patch description
description of what the patch does.
Signed-off-by: Your name your_email@domain.com
E.g.,
fb: add initial code for video 5000 graphics
This adds the initial support for the video 5000 graphics adapter. It supports vga and lcd connectors.
Signed-off-by: Joe Developer joe.developer@example.com
e) repeat steps a-d for all of your patches 3. generate patches:
git format-patch -n
where n is the number of patches you committed. E.g., if your driver consists of 5 patches: git format-patch -5
- Send the patches to the list.
Aaron, Git is nowadays documented pretty well. So just use
git help command
(like `git help commit`) to read the manual. Additionally you can just search for it using your favorite search engine. Interesting reads should be [1][2][3].
Thanks,
Paul
[1] http://schacon.github.com/git/user-manual.html#cleaning-up-history [2] http://git-scm.com/documentation [3] http://progit.org/book/
A couple of non-technical things. First, I think you are sending the patch to the wrong list. dri-devel is for drivers that go under drivers/gpu/drm. Your driver is apparently fbdev driver and thus belongs to linux-fbdev@vger.kernel.org list (see the Maintainers file)
Second, your patch generates about 9000 coding style errors when you run through ./scripts/checkpatch.pl script available in the Linux kernel tree. You need to clean up. See also Documentation/CodingStyle. Also, you must break up the patch into smaller self-contained units that logically make sense. Nobody can review 17000 lines of code in one shot.
Last, but probably the most important. All your files have the proprietary license in the comment overhead. You (actually your company lawyers) have to decide which license you are releasing this dirver under and make sure it is compatible with Linux kernel (i.e. GPL) and you have to state that in each file that is being added.
-- Ilija
On Fri, 9 Mar 2012, [utf-8] Aaron.Chen �~Y~H�~J�~]� wrote:
Hi Paul&Alex,
Thank you very much for your great help.
Here is the first patch.
Regards Aaron
-----邮件原件----- 发件人: Paul Menzel [mailto:paulepanter@users.sourceforge.net] 发送时间: 2012年3月6日 22:38 收件人: Alex Deucher 抄送: Aaron.Chen 陈俊杰; caesar.qiu 裘赛海; dri-devel@lists.freedesktop.org 主题: Re: [korg]help: How to submit a kernel driver on kernel.org.
Dear Aaron,
Am Dienstag, den 06.03.2012, 08:47 -0500 schrieb Alex Deucher:
On Mon, Mar 5, 2012 at 11:13 PM, Aaron.Chen 陈俊杰 wrote:
Thank you very much for your guide. It's a great help for me.
But I still have a little problem with the patch thing. I'm not familiar with the git. 1.Shall I need to do the clone and get the source location and target directory first? 2.Where is the source location and target directory? 3.Our driver has pass the customer's test from kernel version 2.6.5 to 3.0.0, So what shall I do to submit a driver cover all these kernel version.
you can only get new features included upstream in the latest Linux kernel. So earliest version would be 3.4. You have to maintain you own repository for earlier version. But backporting should be not so much trouble if you have it included upstream.
4.or just email you the source code and tell you the changes?
I'm looking forward your re-guide. Thank you so much.
Your best bet it to clone Linus' git tree and then apply your patches:
- clone Linus' git tree: git clone
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
you can do this in between.
cd linux git config --global user.name "陈俊杰 (Aaron Chen)" git config --global user.email aaron.chen@siliconmotion.com
- a) apply your first patch b) if you patch adds new files to the source tree, add them: git add path/to/files/file.c git add path/to/files/file.h etc. if the patch only modifies patches that are already
in the tree, you do not need to add them. c) when the patch is applied commit it: git commit -a -s d) when you run the commit command you will be prompted to enter a commit message. The commit message has the following format:
subsystem: patch description
description of what the patch does.
Signed-off-by: Your name your_email@domain.com
E.g.,
fb: add initial code for video 5000 graphics
This adds the initial support for the video 5000 graphics adapter. It supports vga and lcd connectors.
Signed-off-by: Joe Developer joe.developer@example.com
e) repeat steps a-d for all of your patches 3. generate patches:
git format-patch -n
where n is the number of patches you committed. E.g., if your driver consists of 5 patches: git format-patch -5
- Send the patches to the list.
Aaron, Git is nowadays documented pretty well. So just use
git help command
(like `git help commit`) to read the manual. Additionally you can just search for it using your favorite search engine. Interesting reads should be [1][2][3].
Thanks,
Paul
[1] http://schacon.github.com/git/user-manual.html#cleaning-up-history [2] http://git-scm.com/documentation [3] http://progit.org/book/
Hi Ilija,
Thank you for your reply. We will check the coding style next time.
I don't know about the license thing. Is there any different license for choosing?
Regards Aaron
-----邮件原件----- 发件人: Ilija Hadzic [mailto:ihadzic@research.bell-labs.com] 发送时间: 2012年3月10日 0:30 收件人: Aaron.Chen 陈俊杰 抄送: Paul Menzel; Alex Deucher; dri-devel@lists.freedesktop.org; caesar.qiu 裘赛海 主题: Re: 答复: [korg]help: How to submit a kernel driver on kernel.org.
A couple of non-technical things. First, I think you are sending the patch to the wrong list. dri-devel is for drivers that go under drivers/gpu/drm. Your driver is apparently fbdev driver and thus belongs to linux-fbdev@vger.kernel.org list (see the Maintainers file)
Second, your patch generates about 9000 coding style errors when you run through ./scripts/checkpatch.pl script available in the Linux kernel tree. You need to clean up. See also Documentation/CodingStyle. Also, you must break up the patch into smaller self-contained units that logically make sense. Nobody can review 17000 lines of code in one shot.
Last, but probably the most important. All your files have the proprietary license in the comment overhead. You (actually your company lawyers) have to decide which license you are releasing this dirver under and make sure it is compatible with Linux kernel (i.e. GPL) and you have to state that in each file that is being added.
-- Ilija
On Fri, 9 Mar 2012, [utf-8] Aaron.Chen ~Y~H~J~] wrote:
Hi Paul&Alex,
Thank you very much for your great help.
Here is the first patch.
Regards Aaron
-----邮件原件----- 发件人: Paul Menzel [mailto:paulepanter@users.sourceforge.net] 发送时间: 2012年3月6日 22:38 收件人: Alex Deucher 抄送: Aaron.Chen 陈俊杰; caesar.qiu 裘赛海; dri-devel@lists.freedesktop.org 主题: Re: [korg]help: How to submit a kernel driver on kernel.org.
Dear Aaron,
Am Dienstag, den 06.03.2012, 08:47 -0500 schrieb Alex Deucher:
On Mon, Mar 5, 2012 at 11:13 PM, Aaron.Chen 陈俊杰 wrote:
Thank you very much for your guide. It's a great help for me.
But I still have a little problem with the patch thing. I'm not familiar with the git. 1.Shall I need to do the clone and get the source location and target directory first? 2.Where is the source location and target directory? 3.Our driver has pass the customer's test from kernel version 2.6.5 to 3.0.0, So what shall I do to submit a driver cover all these kernel version.
you can only get new features included upstream in the latest Linux kernel. So earliest version would be 3.4. You have to maintain you own repository for earlier version. But backporting should be not so much trouble if you have it included upstream.
4.or just email you the source code and tell you the changes?
I'm looking forward your re-guide. Thank you so much.
Your best bet it to clone Linus' git tree and then apply your patches:
- clone Linus' git tree: git clone
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
you can do this in between.
cd linux git config --global user.name "陈俊杰 (Aaron Chen)" git config --global user.email aaron.chen@siliconmotion.com
- a) apply your first patch b) if you patch adds new files to the source tree, add them: git add path/to/files/file.c git add path/to/files/file.h etc. if the patch only modifies patches that are already
in the tree, you do not need to add them. c) when the patch is applied commit it: git commit -a -s d) when you run the commit command you will be prompted to enter a commit message. The commit message has the following format:
subsystem: patch description
description of what the patch does.
Signed-off-by: Your name your_email@domain.com
E.g.,
fb: add initial code for video 5000 graphics
This adds the initial support for the video 5000 graphics adapter. It supports vga and lcd connectors.
Signed-off-by: Joe Developer joe.developer@example.com
e) repeat steps a-d for all of your patches 3. generate patches:
git format-patch -n
where n is the number of patches you committed. E.g., if your driver consists of 5 patches: git format-patch -5
- Send the patches to the list.
Aaron, Git is nowadays documented pretty well. So just use
git help command
(like `git help commit`) to read the manual. Additionally you can just search for it using your favorite search engine. Interesting reads should be [1][2][3].
Thanks,
Paul
[1] http://schacon.github.com/git/user-manual.html#cleaning-up-history [2] http://git-scm.com/documentation [3] http://progit.org/book/
Hi Paul&Jerome,
Our driver is a frambuffer driver and there's no DRM functions.
Regards Aaron
-----邮件原件----- 发件人: Aaron.Chen 陈俊杰 发送时间: 2012年3月6日 12:14 收件人: 'Paul Menzel'; Jerome Glisse 抄送: dri-devel@lists.freedesktop.org; caesar.qiu 裘赛海 主题: Re: [korg]help: How to submit a kernel driver on kernel.org.
Hi Paul&Jerome,
Thank you very much for your guide. It's a great help for me.
But I still have a little problem with the patch thing. I'm not familiar with the git. 1.Shall I need to do the clone and get the source location and target directory first? 2.Where is the source location and target directory? 3.Our driver has pass the customer's test from kernel version 2.6.5 to 3.0.0, So what shall I do to submit a driver cover all these kernel version. 4.or just email you the source code and tell you the changes?
I'm looking forward your re-guide. Thank you so much.
Regards Aaron
-----邮件原件----- 发件人: Paul Menzel [mailto:paulepanter@users.sourceforge.net] 发送时间: 2012年3月2日 5:50 收件人: Jerome Glisse 抄送: Aaron.Chen 陈俊杰; dri-devel@lists.freedesktop.org 主题: Re: [korg]help: How to submit a kernel driver on kernel.org.
Dear Aaron,
thank you for contacting the list. We are looking forward to your patches.
Am Donnerstag, den 01.03.2012, 14:05 -0500 schrieb Jerome Glisse:
On Thu, 2012-03-01 at 14:28 +0800, Aaron.Chen 陈俊杰 wrote:
I’m from Silicon Motion Technology Corporation (NasdaqGS:SIMO) Shanghai Office. We have developed a kernel driver for all our graphics chips. We really want to know the way to submit a kernel driver to kernel.org. I have received a document file which is on http://kernel.org/doc/Documentation/SubmittingDrivers, but I still cannot find out a place to where our drivers should be uploaded. The document say “please submit it to the maintainer listed in MAINTAINERS in the kernel file.”So where can I find the maintainer and what to do next. Would you please help me. Thank you so much.
All you need to do is send the kernel patch to dri-devel@lists.freedesktop.org
So they can get reviewed. Once they are reviewed, and if they comply with the requirement, the DRM maintainer (aka Dave) will integrate your patch in his tree and at some point ask Linus to pull them.
There is no ftp, or http web submission, everything is done through public mailing list.
if you are familiar with Git you should send a patch formatted using `git format-patch -15`. Replace the 15 by the number of commits you need patches for.
You can take a look in the archive. drm/exynos and drm/omap are good examples – I think – on how to get new drivers submitted.
Thanks,
Paul
PS: Please also try to follow the netiquette when posting to lists [1]. Especially just send plain text messages (no HTML).
dri-devel@lists.freedesktop.org