When submitting a fenced command we must lock the object reservations because virtio_gpu_queue_fenced_ctrl_buffer() unlocks after adding the fence.
Reported-by: Jann Horn jannh@google.com Signed-off-by: Gerd Hoffmann kraxel@redhat.com --- drivers/gpu/drm/virtio/virtgpu_plane.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c index 390524143139..1635a9ff4794 100644 --- a/drivers/gpu/drm/virtio/virtgpu_plane.c +++ b/drivers/gpu/drm/virtio/virtgpu_plane.c @@ -232,6 +232,7 @@ static void virtio_gpu_cursor_plane_update(struct drm_plane *plane, if (!objs) return; virtio_gpu_array_add_obj(objs, vgfb->base.obj[0]); + virtio_gpu_array_lock_resv(objs); virtio_gpu_cmd_transfer_to_host_2d (vgdev, 0, plane->state->crtc_w,
On Fri, Jan 10, 2020 at 10:45 AM Gerd Hoffmann kraxel@redhat.com wrote:
When submitting a fenced command we must lock the object reservations because virtio_gpu_queue_fenced_ctrl_buffer() unlocks after adding the fence.
Thanks a lot! With this patch applied, my VM doesn't throw lockdep warnings anymore. If you want, you can add:
Tested-by: Jann Horn jannh@google.com
Reported-by: Jann Horn jannh@google.com Signed-off-by: Gerd Hoffmann kraxel@redhat.com
drivers/gpu/drm/virtio/virtgpu_plane.c | 1 + 1 file changed, 1 insertion(+)
On Fri, Jan 10, 2020 at 6:27 AM Jann Horn jannh@google.com wrote:
On Fri, Jan 10, 2020 at 10:45 AM Gerd Hoffmann kraxel@redhat.com wrote:
When submitting a fenced command we must lock the object reservations because virtio_gpu_queue_fenced_ctrl_buffer() unlocks after adding the fence.
Thanks a lot! With this patch applied, my VM doesn't throw lockdep warnings anymore. If you want, you can add:
Tested-by: Jann Horn jannh@google.com
Reported-by: Jann Horn jannh@google.com Signed-off-by: Gerd Hoffmann kraxel@redhat.com
Reviewed-by: Chia-I Wu olvaffe@gmail.com
drivers/gpu/drm/virtio/virtgpu_plane.c | 1 + 1 file changed, 1 insertion(+)
dri-devel@lists.freedesktop.org