The NT39016 panel is a fun beast, even though the documentation states that the CS line is active-low, it will work just fine if the CS line is configured as active-high, but it won't work if the CS line is forced low or forced high.
Since it did actually work with the spi-cs-high property, this is not a bugfix, but we should nonetheless remove that property from the example to match the documentation.
Signed-off-by: Paul Cercueil paul@crapouillou.net --- .../bindings/display/panel/kingdisplay,kd035g6-54nt.yaml | 1 - 1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.yaml b/Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.yaml index 6960036975fa..c45c92a3d41f 100644 --- a/Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.yaml +++ b/Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.yaml @@ -47,7 +47,6 @@ examples:
spi-max-frequency = <3125000>; spi-3wire; - spi-cs-high;
reset-gpios = <&gpe 2 GPIO_ACTIVE_LOW>;
The NT39016 panel is a fun beast, even though the documentation states that the CS line is active-low, it will work just fine if the CS line is configured as active-high, but it won't work if the CS line is forced low or forced high.
Since it did actually work with the spi-cs-high property, this is not a bugfix, but we should nonetheless remove that property to match the documentation.
Signed-off-by: Paul Cercueil paul@crapouillou.net --- arch/mips/boot/dts/ingenic/gcw0.dts | 1 - 1 file changed, 1 deletion(-)
diff --git a/arch/mips/boot/dts/ingenic/gcw0.dts b/arch/mips/boot/dts/ingenic/gcw0.dts index bc72304a2440..f4c04f2263ea 100644 --- a/arch/mips/boot/dts/ingenic/gcw0.dts +++ b/arch/mips/boot/dts/ingenic/gcw0.dts @@ -345,7 +345,6 @@ nt39016@0 {
spi-max-frequency = <3125000>; spi-3wire; - spi-cs-high;
reset-gpios = <&gpe 2 GPIO_ACTIVE_LOW>;
On Sun, Mar 07, 2021 at 07:28:30PM +0000, Paul Cercueil wrote:
The NT39016 panel is a fun beast, even though the documentation states that the CS line is active-low, it will work just fine if the CS line is configured as active-high, but it won't work if the CS line is forced low or forced high.
Since it did actually work with the spi-cs-high property, this is not a bugfix, but we should nonetheless remove that property to match the documentation.
Signed-off-by: Paul Cercueil paul@crapouillou.net
arch/mips/boot/dts/ingenic/gcw0.dts | 1 - 1 file changed, 1 deletion(-)
applied to mips-next.
Thomas.
On Sun, 07 Mar 2021 19:28:29 +0000, Paul Cercueil wrote:
The NT39016 panel is a fun beast, even though the documentation states that the CS line is active-low, it will work just fine if the CS line is configured as active-high, but it won't work if the CS line is forced low or forced high.
Since it did actually work with the spi-cs-high property, this is not a bugfix, but we should nonetheless remove that property from the example to match the documentation.
Signed-off-by: Paul Cercueil paul@crapouillou.net
.../bindings/display/panel/kingdisplay,kd035g6-54nt.yaml | 1 - 1 file changed, 1 deletion(-)
Acked-by: Rob Herring robh@kernel.org
On Sun, Mar 07, 2021 at 07:28:29PM +0000, Paul Cercueil wrote:
The NT39016 panel is a fun beast, even though the documentation states that the CS line is active-low, it will work just fine if the CS line is configured as active-high, but it won't work if the CS line is forced low or forced high.
Since it did actually work with the spi-cs-high property, this is not a bugfix, but we should nonetheless remove that property from the example to match the documentation.
Signed-off-by: Paul Cercueil paul@crapouillou.net
.../bindings/display/panel/kingdisplay,kd035g6-54nt.yaml | 1 - 1 file changed, 1 deletion(-)
applied to mips-next.
Thomas.
dri-devel@lists.freedesktop.org
-
Paul Cercueil -
Rob Herring -
Thomas Bogendoerfer