Use resource_size function on resource object instead of explicit computation.
Clean up coccicheck warning: ./drivers/gpu/drm/amd/amdkfd/kfd_migrate.c:905:10-13: ERROR: Missing resource_size with res
Reported-by: Abaci Robot abaci@linux.alibaba.com Signed-off-by: Yang Li yang.lee@linux.alibaba.com --- drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c index 4a16e3c..f53e17a 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c @@ -901,8 +901,7 @@ int svm_migrate_init(struct amdgpu_device *adev)
/* Disable SVM support capability */ pgmap->type = 0; - devm_release_mem_region(adev->dev, res->start, - res->end - res->start + 1); + devm_release_mem_region(adev->dev, res->start, resource_size(res)); return PTR_ERR(r); }
On Sun, Sep 26, 2021 at 3:17 PM Yang Li yang.lee@linux.alibaba.com wrote:
Use resource_size function on resource object instead of explicit computation.
Clean up coccicheck warning: ./drivers/gpu/drm/amd/amdkfd/kfd_migrate.c:905:10-13: ERROR: Missing resource_size with res
Reported-by: Abaci Robot abaci@linux.alibaba.com Signed-off-by: Yang Li yang.lee@linux.alibaba.com
drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c index 4a16e3c..f53e17a 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c @@ -901,8 +901,7 @@ int svm_migrate_init(struct amdgpu_device *adev)
/* Disable SVM support capability */ pgmap->type = 0;
devm_release_mem_region(adev->dev, res->start,res->end - res->start + 1);
devm_release_mem_region(adev->dev, res->start,resource_size(res));
Looks good. Reviewed-by: Amos Kong kongjianjun@gmail.com
return PTR_ERR(r); }-- 1.8.3.1
Applied. Thanks!
Alex
On Sun, Sep 26, 2021 at 3:10 PM Amos Jianjun Kong kongjianjun@gmail.com wrote:
On Sun, Sep 26, 2021 at 3:17 PM Yang Li yang.lee@linux.alibaba.com wrote:
Use resource_size function on resource object instead of explicit computation.
Clean up coccicheck warning: ./drivers/gpu/drm/amd/amdkfd/kfd_migrate.c:905:10-13: ERROR: Missing resource_size with res
Reported-by: Abaci Robot abaci@linux.alibaba.com Signed-off-by: Yang Li yang.lee@linux.alibaba.com
drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c index 4a16e3c..f53e17a 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c @@ -901,8 +901,7 @@ int svm_migrate_init(struct amdgpu_device *adev)
/* Disable SVM support capability */ pgmap->type = 0;
devm_release_mem_region(adev->dev, res->start,res->end - res->start + 1);
devm_release_mem_region(adev->dev, res->start, resource_size(res));Looks good. Reviewed-by: Amos Kong kongjianjun@gmail.com
return PTR_ERR(r); }-- 1.8.3.1
dri-devel@lists.freedesktop.org
-
Alex Deucher -
Amos Jianjun Kong -
Yang Li