On Thu, May 30, 2019 at 03:31:05PM +0200, Janusz Krzysztofik wrote:

In order to support driver hot unbind, some cleanup operations, now performed on PCI driver remove, must be called later, after all device file descriptors are closed.

Split out those operations from the tail of pci_driver.remove() callback and put them into drm_driver.release() which is called as soon as all references to the driver are put. As a result, those cleanups will be now run on last drm_dev_put(), either still called from pci_driver.remove() if all device file descriptors are already closed, or on last drm_release() file operation.

Signed-off-by: Janusz Krzysztofik janusz.krzysztofik@linux.intel.com Reviewed-by: Chris Wilson chris@chris-wilson.co.uk

---

Changelog: v1 -> v2:

• defer intel_engines_cleanup() as well. (Chris)

Just an aside, we generally keep the changelog in the commit message on dri-devel, it's occasionally useful to reference in the future. Yes that's different from some other areas of the kernel. -Daniel

drivers/gpu/drm/i915/i915_drv.c | 17 +++++++++++++---- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_gem.c | 10 +++++++++- 3 files changed, 23 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 83d2eb9e74cb..8be69f84eb6d 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i915/i915_drv.c @@ -738,6 +738,7 @@ static int i915_load_modeset_init(struct drm_device *dev)

cleanup_gem: i915_gem_suspend(dev_priv);

• i915_gem_fini_hw(dev_priv); i915_gem_fini(dev_priv);

cleanup_modeset: intel_modeset_cleanup(dev); @@ -1685,7 +1686,6 @@ static void i915_driver_cleanup_hw(struct drm_i915_private *dev_priv) pci_disable_msi(pdev);

pm_qos_remove_request(&dev_priv->pm_qos);

• i915_ggtt_cleanup_hw(dev_priv);

}

/** @@ -1909,6 +1909,7 @@ int i915_driver_load(struct pci_dev *pdev, const struct pci_device_id *ent)

out_cleanup_hw: i915_driver_cleanup_hw(dev_priv);

• i915_ggtt_cleanup_hw(dev_priv);

out_cleanup_mmio: i915_driver_cleanup_mmio(dev_priv); out_runtime_pm_put: @@ -1960,21 +1961,29 @@ void i915_driver_unload(struct drm_device *dev) cancel_delayed_work_sync(&dev_priv->gpu_error.hangcheck_work); i915_reset_error_state(dev_priv);

• i915_gem_fini(dev_priv);

• i915_gem_fini_hw(dev_priv);

  intel_power_domains_fini_hw(dev_priv);

  i915_driver_cleanup_hw(dev_priv);

• i915_driver_cleanup_mmio(dev_priv);

  enable_rpm_wakeref_asserts(dev_priv);

• intel_runtime_pm_cleanup(dev_priv);

}

static void i915_driver_release(struct drm_device *dev) { struct drm_i915_private *dev_priv = to_i915(dev);

• disable_rpm_wakeref_asserts(dev_priv);
• i915_gem_fini(dev_priv);
• i915_ggtt_cleanup_hw(dev_priv);
• i915_driver_cleanup_mmio(dev_priv);
• enable_rpm_wakeref_asserts(dev_priv);
• intel_runtime_pm_cleanup(dev_priv);
• i915_driver_cleanup_early(dev_priv); i915_driver_destroy(dev_priv);

} diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index a2664ea1395b..d08e7bd83544 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -3047,6 +3047,7 @@ void i915_gem_init_mmio(struct drm_i915_private *i915); int __must_check i915_gem_init(struct drm_i915_private *dev_priv); int __must_check i915_gem_init_hw(struct drm_i915_private *dev_priv); void i915_gem_init_swizzling(struct drm_i915_private *dev_priv); +void i915_gem_fini_hw(struct drm_i915_private *dev_priv); void i915_gem_fini(struct drm_i915_private *dev_priv); int i915_gem_wait_for_idle(struct drm_i915_private *dev_priv, unsigned int flags, long timeout); diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 7cafd5612f71..20d3f7532cef 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@ -4667,7 +4667,7 @@ int i915_gem_init(struct drm_i915_private *dev_priv) return ret; }

-void i915_gem_fini(struct drm_i915_private *dev_priv) +void i915_gem_fini_hw(struct drm_i915_private *dev_priv) { GEM_BUG_ON(dev_priv->gt.awake);

@@ -4680,6 +4680,14 @@ void i915_gem_fini(struct drm_i915_private *dev_priv) mutex_lock(&dev_priv->drm.struct_mutex); intel_uc_fini_hw(dev_priv); intel_uc_fini(dev_priv);

• mutex_unlock(&dev_priv->drm.struct_mutex);
• i915_gem_drain_freed_objects(dev_priv);

+}

+void i915_gem_fini(struct drm_i915_private *dev_priv) +{

• mutex_lock(&dev_priv->drm.struct_mutex); intel_engines_cleanup(dev_priv); i915_gem_contexts_fini(dev_priv); i915_gem_fini_scratch(dev_priv);

-- 2.21.0