Hi Tobias.

On Thu, Jan 09, 2020 at 12:29:52PM +0100, Tobias Schramm wrote:

This patch adds support for the BOE NV140FHM-N49 panel to the panel-simple driver. The panel is used by the pine64 Pinebook Pro.

Signed-off-by: Tobias Schramm t.schramm@manjaro.org

Applied to drm-misc-next togher with the bindings patch. Thanks for the quick r-b.

Sam

---

drivers/gpu/drm/panel/panel-simple.c | 35 ++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 5d487686d25c..6320df9765f3 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1036,6 +1036,38 @@ static const struct panel_desc boe_nv101wxmn51 = { }, };

+static const struct drm_display_mode boe_nv140fhmn49_modes[] = {

• {

• .clock = 148500,
  

• .hdisplay = 1920,
  

• .hsync_start = 1920 + 48,
  

• .hsync_end = 1920 + 48 + 32,
  

• .htotal = 2200,
  

• .vdisplay = 1080,
  

• .vsync_start = 1080 + 3,
  

• .vsync_end = 1080 + 3 + 5,
  

• .vtotal = 1125,
  

• .vrefresh = 60,
  

• },

+};

+static const struct panel_desc boe_nv140fhmn49 = {

• .modes = boe_nv140fhmn49_modes,
• .num_modes = ARRAY_SIZE(boe_nv140fhmn49_modes),
• .bpc = 6,
• .size = {

• .width = 309,
  

• .height = 174,
  

• },
• .delay = {

• .prepare = 210,
  

• .enable = 50,
  

• .unprepare = 160,
  

• },
• .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
• .connector_type = DRM_MODE_CONNECTOR_eDP,

+};

static const struct drm_display_mode cdtech_s043wq26h_ct7_mode = { .clock = 9000, .hdisplay = 480, @@ -3161,6 +3193,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "boe,nv101wxmn51", .data = &boe_nv101wxmn51,

• }, {

• .compatible = "boe,nv140fhmn49",
  

• .data = &boe_nv140fhmn49,
  

  }, { .compatible = "cdtech,s043wq26h-ct7", .data = &cdtech_s043wq26h_ct7,

-- 2.24.1

Hi Tobias.

We need binding schema before we can apply this patch.

Knew I forgot something

See patch below. Please review/ack the patch, then we can process your panel-simple patch.

LGTM, thanks!

Sam

On Thu, Jan 09, 2020 at 12:29:51PM +0100, Tobias Schramm wrote:

...

This patch adds support for the 14 inch BOE NV140FHM-N49 eDP panel to the panel-simple driver. The panel is used by the Pinebook Pro.

Resending with changed CCs due to lack of feedback.

...

Tobias Schramm (1): drm/panel: Add support for BOE NV140FHM-N49 panel to panel-simple

drivers/gpu/drm/panel/panel-simple.c | 35 ++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+)

From ad19c4636475bb05ba5c0b6cec2bee85045d628e Mon Sep 17 00:00:00 2001 From: Sam Ravnborg sam@ravnborg.org Date: Thu, 9 Jan 2020 14:48:41 +0100 Subject: [PATCH] dt-bindings: display: add BOE 14" panel

Add bindings for the BOE NV140FHM-N49 14" 1920x1080 panel.

The panel is used by the pine64 Pinebook Pro.

Signed-off-by: Sam Ravnborg sam@ravnborg.org Cc: Thierry Reding thierry.reding@gmail.com Cc: Tobias Schramm t.schramm@manjaro.org

---

.../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml index ddc00480b6fe..6c098a0b6e1e 100644 --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml @@ -35,6 +35,8 @@ properties: - ampire,am800480r3tmqwa1h # AUO B116XAK01 eDP TFT LCD panel - auo,b116xa01

•    # BOE NV140FHM-N49 14.0" FHD a-Si FT panel
  

•  - boe,nv140fhmn49
      # GiantPlus GPM940B0 3.0" QVGA TFT LCD panel
    - giantplus,gpm940b0
      # Sharp LS020B1DD01D 2.0" HQVGA TFT LCD panel
  
  

Reviewed-by: Tobias Schramm t.schramm@manjaro.org