During normal usage, especially if jobs are started and stopped in rapid succession, the kernel log is filled with messages like this:
[38732.522910] Restoring PASID 0x8003 queues [38732.666767] Evicting PASID 0x8003 queues [38732.714074] Restoring PASID 0x8003 queues [38732.815633] Evicting PASID 0x8003 queues [38732.834961] Restoring PASID 0x8003 queues [38732.840536] Evicting PASID 0x8003 queues [38732.869846] Restoring PASID 0x8003 queues [38732.893655] Evicting PASID 0x8003 queues [38732.927975] Restoring PASID 0x8003 queues
According to [1], these messages are expected, but they carry little value for the end user, so turn them into debug messages.
[1] https://github.com/RadeonOpenCompute/ROCm/issues/343
Signed-off-by: Julian Sax jsbc@gmx.de --- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c index 984c2f2b24b6..3dc0e8c3b91b 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c @@ -604,7 +604,7 @@ static int evict_process_queues_nocpsch(struct device_queue_manager *dqm, goto out;
pdd = qpd_to_pdd(qpd); - pr_info_ratelimited("Evicting PASID 0x%x queues\n", + pr_debug_ratelimited("Evicting PASID 0x%x queues\n", pdd->process->pasid);
/* Mark all queues as evicted. Deactivate all active queues on @@ -650,7 +650,7 @@ static int evict_process_queues_cpsch(struct device_queue_manager *dqm, goto out;
pdd = qpd_to_pdd(qpd); - pr_info_ratelimited("Evicting PASID 0x%x queues\n", + pr_debug_ratelimited("Evicting PASID 0x%x queues\n", pdd->process->pasid);
/* Mark all queues as evicted. Deactivate all active queues on @@ -696,7 +696,7 @@ static int restore_process_queues_nocpsch(struct device_queue_manager *dqm, goto out; }
- pr_info_ratelimited("Restoring PASID 0x%x queues\n", + pr_debug_ratelimited("Restoring PASID 0x%x queues\n", pdd->process->pasid);
/* Update PD Base in QPD */ @@ -772,7 +772,7 @@ static int restore_process_queues_cpsch(struct device_queue_manager *dqm, goto out; }
- pr_info_ratelimited("Restoring PASID 0x%x queues\n", + pr_debug_ratelimited("Restoring PASID 0x%x queues\n", pdd->process->pasid);
/* Update PD Base in QPD */ -- 2.24.1
On Sun, 2020-02-02 at 00:11 +0100, Julian Sax wrote:
During normal usage, especially if jobs are started and stopped in rapid succession, the kernel log is filled with messages like this:
[38732.522910] Restoring PASID 0x8003 queues [38732.666767] Evicting PASID 0x8003 queues [38732.714074] Restoring PASID 0x8003 queues [38732.815633] Evicting PASID 0x8003 queues [38732.834961] Restoring PASID 0x8003 queues [38732.840536] Evicting PASID 0x8003 queues [38732.869846] Restoring PASID 0x8003 queues [38732.893655] Evicting PASID 0x8003 queues [38732.927975] Restoring PASID 0x8003 queues
According to [1], these messages are expected, but they carry little value for the end user, so turn them into debug messages.
trivia:
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
[]
@@ -604,7 +604,7 @@ static int evict_process_queues_nocpsch(struct device_queue_manager *dqm, goto out;
pdd = qpd_to_pdd(qpd);
- pr_info_ratelimited("Evicting PASID 0x%x queues\n",
- pr_debug_ratelimited("Evicting PASID 0x%x queues\n", pdd->process->pasid);
It would be nicer to realign all the subsequent lines in a single statement to the now moved open parenthesis.
/* Mark all queues as evicted. Deactivate all active queues on @@ -650,7 +650,7 @@ static int evict_process_queues_cpsch(struct device_queue_manager *dqm, goto out;
pdd = qpd_to_pdd(qpd);
- pr_info_ratelimited("Evicting PASID 0x%x queues\n",
- pr_debug_ratelimited("Evicting PASID 0x%x queues\n", pdd->process->pasid);
etc...
Joe Perches joe@perches.com writes:
On Sun, 2020-02-02 at 00:11 +0100, Julian Sax wrote:
During normal usage, especially if jobs are started and stopped in rapid succession, the kernel log is filled with messages like this:
[38732.522910] Restoring PASID 0x8003 queues [38732.666767] Evicting PASID 0x8003 queues [38732.714074] Restoring PASID 0x8003 queues [38732.815633] Evicting PASID 0x8003 queues [38732.834961] Restoring PASID 0x8003 queues [38732.840536] Evicting PASID 0x8003 queues [38732.869846] Restoring PASID 0x8003 queues [38732.893655] Evicting PASID 0x8003 queues [38732.927975] Restoring PASID 0x8003 queues
According to [1], these messages are expected, but they carry little value for the end user, so turn them into debug messages.
trivia:
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
[]
@@ -604,7 +604,7 @@ static int evict_process_queues_nocpsch(struct device_queue_manager *dqm, goto out;
pdd = qpd_to_pdd(qpd);
- pr_info_ratelimited("Evicting PASID 0x%x queues\n",
- pr_debug_ratelimited("Evicting PASID 0x%x queues\n", pdd->process->pasid);
It would be nicer to realign all the subsequent lines in a single statement to the now moved open parenthesis.
/* Mark all queues as evicted. Deactivate all active queues on @@ -650,7 +650,7 @@ static int evict_process_queues_cpsch(struct device_queue_manager *dqm, goto out;
pdd = qpd_to_pdd(qpd);
- pr_info_ratelimited("Evicting PASID 0x%x queues\n",
- pr_debug_ratelimited("Evicting PASID 0x%x queues\n", pdd->process->pasid);
etc...
Yeah, absolutely, thanks for pointing that out. v2 coming shortly.
Julian
During normal usage, especially if jobs are started and stopped in rapid succession, the kernel log is filled with messages like this:
[38732.522910] Restoring PASID 0x8003 queues [38732.666767] Evicting PASID 0x8003 queues [38732.714074] Restoring PASID 0x8003 queues [38732.815633] Evicting PASID 0x8003 queues [38732.834961] Restoring PASID 0x8003 queues [38732.840536] Evicting PASID 0x8003 queues [38732.869846] Restoring PASID 0x8003 queues [38732.893655] Evicting PASID 0x8003 queues [38732.927975] Restoring PASID 0x8003 queues
According to [1], these messages are expected, but they carry little value for the end user, so turn them into debug messages.
[1] https://github.com/RadeonOpenCompute/ROCm/issues/343
Signed-off-by: Julian Sax jsbc@gmx.de --- v2: fixed indenting of following lines
.../drm/amd/amdkfd/kfd_device_queue_manager.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c index 2870553a2ce0..13bd588c4419 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c @@ -604,8 +604,8 @@ static int evict_process_queues_nocpsch(struct device_queue_manager *dqm, goto out;
pdd = qpd_to_pdd(qpd); - pr_info_ratelimited("Evicting PASID 0x%x queues\n", - pdd->process->pasid); + pr_debug_ratelimited("Evicting PASID 0x%x queues\n", + pdd->process->pasid);
/* Mark all queues as evicted. Deactivate all active queues on * the qpd. @@ -650,8 +650,8 @@ static int evict_process_queues_cpsch(struct device_queue_manager *dqm, goto out;
pdd = qpd_to_pdd(qpd); - pr_info_ratelimited("Evicting PASID 0x%x queues\n", - pdd->process->pasid); + pr_debug_ratelimited("Evicting PASID 0x%x queues\n", + pdd->process->pasid);
/* Mark all queues as evicted. Deactivate all active queues on * the qpd. @@ -696,8 +696,8 @@ static int restore_process_queues_nocpsch(struct device_queue_manager *dqm, goto out; }
- pr_info_ratelimited("Restoring PASID 0x%x queues\n", - pdd->process->pasid); + pr_debug_ratelimited("Restoring PASID 0x%x queues\n", + pdd->process->pasid);
/* Update PD Base in QPD */ qpd->page_table_base = pd_base; @@ -772,8 +772,8 @@ static int restore_process_queues_cpsch(struct device_queue_manager *dqm, goto out; }
- pr_info_ratelimited("Restoring PASID 0x%x queues\n", - pdd->process->pasid); + pr_debug_ratelimited("Restoring PASID 0x%x queues\n", + pdd->process->pasid);
/* Update PD Base in QPD */ qpd->page_table_base = pd_base; -- 2.24.1
dri-devel@lists.freedesktop.org
-
Joe Perches -
Julian Sax