Re: [PATCH 07/10] vfio/mdev: Allow the mdev_parent_ops to specify the device driver to bind
On Tue, Jun 15, 2021 at 03:35:16PM +0200, Christoph Hellwig wrote:
From: Jason Gunthorpe jgg@nvidia.com
This allows a mdev driver to opt out of using vfio_mdev.c, instead the driver will provide a 'struct mdev_driver' and register directly with the driver core.
Much of mdev_parent_ops becomes unused in this mode:
- create()/remove() are done via the mdev_driver probe()/remove()
- mdev_attr_groups becomes mdev_driver driver.dev_groups
- Wrapper function callbacks are replaced with the same ones from struct vfio_device_ops
Signed-off-by: Jason Gunthorpe jgg@nvidia.com Signed-off-by: Christoph Hellwig hch@lst.de
Messy, but ok...
Reviewed-by: Greg Kroah-Hartman gregkh@linuxfoundation.org
On Tue, Jun 15, 2021 at 04:11:29PM +0200, Greg Kroah-Hartman wrote:
On Tue, Jun 15, 2021 at 03:35:16PM +0200, Christoph Hellwig wrote:
From: Jason Gunthorpe jgg@nvidia.com
This allows a mdev driver to opt out of using vfio_mdev.c, instead the driver will provide a 'struct mdev_driver' and register directly with the driver core.
Much of mdev_parent_ops becomes unused in this mode:
- create()/remove() are done via the mdev_driver probe()/remove()
- mdev_attr_groups becomes mdev_driver driver.dev_groups
- Wrapper function callbacks are replaced with the same ones from struct vfio_device_ops
Signed-off-by: Jason Gunthorpe jgg@nvidia.com Signed-off-by: Christoph Hellwig hch@lst.de
Messy, but ok...
Is there something you'd like to see changed, eg in later patches? This whole work still has another approx 30 patches to go and much of this ends up being erased once the drivers are all converted.
Jason
On Tue, Jun 15, 2021 at 09:00:40PM -0300, Jason Gunthorpe wrote:
On Tue, Jun 15, 2021 at 04:11:29PM +0200, Greg Kroah-Hartman wrote:
On Tue, Jun 15, 2021 at 03:35:16PM +0200, Christoph Hellwig wrote:
From: Jason Gunthorpe jgg@nvidia.com
This allows a mdev driver to opt out of using vfio_mdev.c, instead the driver will provide a 'struct mdev_driver' and register directly with the driver core.
Much of mdev_parent_ops becomes unused in this mode:
- create()/remove() are done via the mdev_driver probe()/remove()
- mdev_attr_groups becomes mdev_driver driver.dev_groups
- Wrapper function callbacks are replaced with the same ones from struct vfio_device_ops
Signed-off-by: Jason Gunthorpe jgg@nvidia.com Signed-off-by: Christoph Hellwig hch@lst.de
Messy, but ok...
Is there something you'd like to see changed, eg in later patches? This whole work still has another approx 30 patches to go and much of this ends up being erased once the drivers are all converted.
If this mostly gets removed in the end, I'm happy. Let's see how it looks after all of that is done. This is going forward in the right way, so I do not object to this at all.
thanks,
greg k-h
dri-devel@lists.freedesktop.org
-
Greg Kroah-Hartman -
Jason Gunthorpe