From: Markus Elfring elfring@users.sourceforge.net Date: Sun, 5 Apr 2020 11:25:30 +0200
The function “platform_get_irq” can log an error already. Thus omit a redundant message for the exception handling in the calling function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring elfring@users.sourceforge.net --- drivers/gpu/drm/ingenic/ingenic-drm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c b/drivers/gpu/drm/ingenic/ingenic-drm.c index 9dfe7cb530e1..06ca752b76ee 100644 --- a/drivers/gpu/drm/ingenic/ingenic-drm.c +++ b/drivers/gpu/drm/ingenic/ingenic-drm.c @@ -661,10 +661,8 @@ static int ingenic_drm_probe(struct platform_device *pdev) }
irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(dev, "Failed to get platform irq"); + if (irq < 0) return irq; - }
if (soc_info->needs_dev_clk) { priv->lcd_clk = devm_clk_get(dev, "lcd"); -- 2.26.0
Hi,
Le dim. 5 avril 2020 à 11:30, Markus Elfring Markus.Elfring@web.de a écrit :
Reviewed-by: Paul Cercueil paul@crapouillou.net
Cheers, -Paul
Hi Markus,
Le dim. 5 avril 2020 à 11:30, Markus Elfring Markus.Elfring@web.de a écrit :
Applied to drm-misc-next, thanks.
-Paul
dri-devel@lists.freedesktop.org