From: Srinivasan S srinivasan.s@intel.com
This patch avoids DP MST payload error message in dmesg, as it is trying to update the payload to the disconnected DP MST device. After DP MST device is disconnected we should not be updating the payload and hence remove the error.
v2: Removed the connector status check and converted from error to debug.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111632 Signed-off-by: Srinivasan S srinivasan.s@intel.com --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c index eeeb3f933aa4..497a6ae0d2c0 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c @@ -215,7 +215,7 @@ static void intel_mst_disable_dp(struct intel_encoder *encoder,
ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr); if (ret) { - DRM_ERROR("failed to update payload %d\n", ret); + DRM_DEBUG_KMS("failed to update payload %d\n", ret); } if (old_crtc_state->has_audio) intel_audio_codec_disable(encoder,
On Wed, Sep 25, 2019 at 06:05:42AM +0530, srinivasan.s@intel.com wrote:
From: Srinivasan S srinivasan.s@intel.com
This patch avoids DP MST payload error message in dmesg, as it is trying to update the payload to the disconnected DP MST device. After DP MST device is disconnected we should not be updating the payload and hence remove the error.
v2: Removed the connector status check and converted from error to debug.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111632 Signed-off-by: Srinivasan S srinivasan.s@intel.com
Pushed to dinq. Thanks for the patch.
PS. Next time please use --in-reply-to when sending an updated patch so that it's easier to keep track of the discussion.
drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c index eeeb3f933aa4..497a6ae0d2c0 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c @@ -215,7 +215,7 @@ static void intel_mst_disable_dp(struct intel_encoder *encoder,
ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr); if (ret) {
DRM_ERROR("failed to update payload %d\n", ret);
DRM_DEBUG_KMS("failed to update payload %d\n", ret);-- 2.7.4
Thanks a lot Manasi, Ville, Mika, Jani, Lakshmi, for all your time in reviewing this patch.
Best Regards,
-----Original Message----- From: dri-devel dri-devel-bounces@lists.freedesktop.org On Behalf Of Ville Syrjälä Sent: Tuesday, October 1, 2019 5:31 PM To: S, Srinivasan srinivasan.s@intel.com Cc: Navare, Manasi D manasi.d.navare@intel.com; intel- gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Vudum, Lakshminarayana lakshminarayana.vudum@intel.com Subject: Re: [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable
On Wed, Sep 25, 2019 at 06:05:42AM +0530, srinivasan.s@intel.com wrote:
From: Srinivasan S srinivasan.s@intel.com
This patch avoids DP MST payload error message in dmesg, as it is trying to update the payload to the disconnected DP MST device. After DP MST device is disconnected we should not be updating the payload and hence remove the error.
v2: Removed the connector status check and converted from error to debug.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111632 Signed-off-by: Srinivasan S srinivasan.s@intel.com
Pushed to dinq. Thanks for the patch.
PS. Next time please use --in-reply-to when sending an updated patch so that it's easier to keep track of the discussion.
drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c
b/drivers/gpu/drm/i915/display/intel_dp_mst.c
index eeeb3f933aa4..497a6ae0d2c0 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c @@ -215,7 +215,7 @@ static void intel_mst_disable_dp(struct intel_encoder
*encoder,
ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr); if (ret) {
DRM_ERROR("failed to update payload %d\n", ret);
DRM_DEBUG_KMS("failed to update payload %d\n", ret);-- 2.7.4
-- Ville Syrjälä Intel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
dri-devel@lists.freedesktop.org
-
S, Srinivasan -
srinivasan.s＠intel.com
-
Ville Syrjälä