From: Colin Ian King colin.king@canonical.com
Don't populate the array frs_limits on the stack but instead make it static. Makes the object code smaller by 123 bytes
Before: text data bss dec hex filename 23456 5712 64 29232 7230 drivers/gpu/drm/bridge/tc358768.o
After: text data bss dec hex filename 23333 5712 64 29109 71b5 drivers/gpu/drm/bridge/tc358768.o
(gcc version 9.3.0, amd64)
Signed-off-by: Colin Ian King colin.king@canonical.com --- drivers/gpu/drm/bridge/tc358768.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c index 6650fe4cfc20..bd3fa3cbac16 100644 --- a/drivers/gpu/drm/bridge/tc358768.c +++ b/drivers/gpu/drm/bridge/tc358768.c @@ -291,7 +291,7 @@ static int tc358768_calc_pll(struct tc358768_priv *priv, const struct drm_display_mode *mode, bool verify_only) { - const u32 frs_limits[] = { + static const u32 frs_limits[] = { 1000000000, 500000000, 250000000,
On Thu, 2020-06-11 at 14:39 +0100, Colin King wrote:
From: Colin Ian King colin.king@canonical.com
Don't populate the array frs_limits on the stack but instead make it static. Makes the object code smaller by 123 bytes
Before: text data bss dec hex filename 23456 5712 64 29232 7230 drivers/gpu/drm/bridge/tc358768.o
After: text data bss dec hex filename 23333 5712 64 29109 71b5 drivers/gpu/drm/bridge/tc358768.o
(gcc version 9.3.0, amd64)
It's curious that the data size didn't change.
Perhaps you should make sure you do not compile with allyesconfig when you show these change.
For instance: x86-64 defconfig with this bridge enabled:
$ size drivers/gpu/drm/bridge/tc358768.o text data bss dec hex filename 9423 300 0 9723 25fb drivers/gpu/drm/bridge/tc358768.o
dri-devel@lists.freedesktop.org
-
Colin King -
Joe Perches