This one is a bit harder to notice.
Signed-off-by: Connor Behan connor.behan@gmail.com --- xf86drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xf86drm.c b/xf86drm.c index e73cddd..ffc53b8 100644 --- a/xf86drm.c +++ b/xf86drm.c @@ -1719,7 +1719,7 @@ int drmAgpEnable(int fd, unsigned long mode) { drm_agp_mode_t m;
- memclear(mode); + memclear(m); m.mode = mode; if (drmIoctl(fd, DRM_IOCTL_AGP_ENABLE, &m)) return -errno;
On 24 March 2015 at 17:53, Connor Behan connor.behan@gmail.com wrote:
This one is a bit harder to notice.
Plus not so widely used any more :-)
Mildly related - with EXA support for the r128 ddx done for a while now, do you have any plans on updating the dri module to dri2 ?
Signed-off-by: Connor Behan connor.behan@gmail.com
Reviewed-by: Emil Velikov emil.l.velikov@gmail.com
Thanks ! Emil
On 26/03/15 08:06 PM, Emil Velikov wrote:
On 24 March 2015 at 17:53, Connor Behan connor.behan@gmail.com wrote:
This one is a bit harder to notice.
Plus not so widely used any more :-)
Mildly related - with EXA support for the r128 ddx done for a while now, do you have any plans on updating the dri module to dri2 ?
Yes, that is still the eventual goal. I'm looking at how the radeon kernel module is setup these days. So I should be able to start porting r128 to KMS at some point this year.
Thanks for the interest!
Signed-off-by: Connor Behan connor.behan@gmail.com
Reviewed-by: Emil Velikov emil.l.velikov@gmail.com
Thanks ! Emil
On Thu, Mar 26, 2015 at 10:26 PM, Connor Behan connor.behan@gmail.com wrote:
On 26/03/15 08:06 PM, Emil Velikov wrote:
On 24 March 2015 at 17:53, Connor Behan connor.behan@gmail.com wrote:
This one is a bit harder to notice.
Plus not so widely used any more :-)
Mildly related - with EXA support for the r128 ddx done for a while now, do you have any plans on updating the dri module to dri2 ?
Yes, that is still the eventual goal. I'm looking at how the radeon kernel module is setup these days. So I should be able to start porting r128 to KMS at some point this year.
I think it would be easiest to port r128 support to the radeon kernel module. You can re-use 90% of the r100 code.
Alex
Thanks for the interest!
Signed-off-by: Connor Behan connor.behan@gmail.com
Reviewed-by: Emil Velikov emil.l.velikov@gmail.com
Thanks ! Emil
dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
On 24 March 2015 at 17:53, Connor Behan connor.behan@gmail.com wrote:
This one is a bit harder to notice.
Signed-off-by: Connor Behan connor.behan@gmail.com
Thanks for the patch Connor. Just pushed it to master.
-Emil
dri-devel@lists.freedesktop.org