https://bugs.freedesktop.org/show_bug.cgi?id=89327
Bug ID: 89327 Summary: Loss of HDMI audio on auto screen off (energy saving) Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel@lists.freedesktop.org Reporter: john.ettedgui@gmail.com QA Contact: dri-devel@lists.freedesktop.org
Since moving to 4.0-rc1 when my screen goes off (energy saving), I lose the hdmi audio, standard stuff. When I move the mouse I get the screen back but not the audio anymore. Switching it back on with xrandr works.
Thanks
https://bugs.freedesktop.org/show_bug.cgi?id=89327
Alex Deucher alexdeucher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|Drivers/Gallium/radeonsi |DRM/Radeon Version|git |unspecified Product|Mesa |DRI QA Contact|dri-devel@lists.freedesktop | |.org |
--- Comment #1 from Alex Deucher alexdeucher@gmail.com --- Please attach your xorg log and dmesg output.
https://bugs.freedesktop.org/show_bug.cgi?id=89327
--- Comment #2 from Dieter Nützel Dieter@nuetzel-hh.de --- (In reply to John from comment #0)
Since moving to 4.0-rc1 when my screen goes off (energy saving), I lose the hdmi audio, standard stuff. When I move the mouse I get the screen back but not the audio anymore. Switching it back on with xrandr works.
Thanks
Can you please attach the 'right' xrandr line, please? I do not hear anything after screen goes off (energy saving) with drm-next-4.1-wip on r600/NI/Turks, too.
So it seems to be not only with radeonsi.
-Dieter
https://bugs.freedesktop.org/show_bug.cgi?id=89327
--- Comment #3 from Dieter Nützel Dieter@nuetzel-hh.de --- Created attachment 113830 --> https://bugs.freedesktop.org/attachment.cgi?id=113830&action=edit dmesg-drm-next-4.1-wip.log.xz
https://bugs.freedesktop.org/show_bug.cgi?id=89327
--- Comment #4 from Dieter Nützel Dieter@nuetzel-hh.de --- Created attachment 113831 --> https://bugs.freedesktop.org/attachment.cgi?id=113831&action=edit Xorg.0.log-drm-next-4.1-wip.xz
https://bugs.freedesktop.org/show_bug.cgi?id=89327
--- Comment #5 from Alex Deucher alexdeucher@gmail.com --- Please don't compress attachments unless they are really large, it makes them much harder to review.
https://bugs.freedesktop.org/show_bug.cgi?id=89327
--- Comment #6 from Alex Deucher alexdeucher@gmail.com --- Can you bisect?
https://bugs.freedesktop.org/show_bug.cgi?id=89327
--- Comment #7 from Dieter Nützel Dieter@nuetzel-hh.de --- (In reply to Alex Deucher from comment #6)
Can you bisect?
So I have to go before your -rc1 merge?
https://bugs.freedesktop.org/show_bug.cgi?id=89327
--- Comment #8 from Dieter Nützel Dieter@nuetzel-hh.de --- (In reply to Dieter Nützel from comment #7)
(In reply to Alex Deucher from comment #6)
Can you bisect?
So I have to go before your -rc1 merge?
Alex,
my reportet drm-next-4.1-wip error [drm:radeon_atom_pick_dig_encoder [radeon]] *ERROR* chosen encoder in use 4 is related to this.
If I reenable audio with xrandr --output HDMI-0 --set audio on I get next line in dmesg.
2cond time do NOT work but xrandr --output HDMI-0 --set audio auto do?!
Is this right? [ 4.722072] snd_hda_intel 0000:01:00.1: Handle VGA-switcheroo audio client
There is no other 'enable audio' in dmesg.
https://bugs.freedesktop.org/show_bug.cgi?id=89327
--- Comment #9 from John john.ettedgui@gmail.com --- Created attachment 113833 --> https://bugs.freedesktop.org/attachment.cgi?id=113833&action=edit john's dmesg
https://bugs.freedesktop.org/show_bug.cgi?id=89327
--- Comment #10 from John john.ettedgui@gmail.com --- Created attachment 113834 --> https://bugs.freedesktop.org/attachment.cgi?id=113834&action=edit john's xorg.log
https://bugs.freedesktop.org/show_bug.cgi?id=89327
--- Comment #11 from John john.ettedgui@gmail.com --- (In reply to Dieter Nützel from comment #2)
(In reply to John from comment #0)
Since moving to 4.0-rc1 when my screen goes off (energy saving), I lose the hdmi audio, standard stuff. When I move the mouse I get the screen back but not the audio anymore. Switching it back on with xrandr works.
Thanks
Can you please attach the 'right' xrandr line, please? I do not hear anything after screen goes off (energy saving) with drm-next-4.1-wip on r600/NI/Turks, too.
So it seems to be not only with radeonsi.
-Dieter
xrandr --output HDMI-0 --set audio on works for me
https://bugs.freedesktop.org/show_bug.cgi?id=89327
--- Comment #12 from Dieter Nützel Dieter@nuetzel-hh.de --- Bisected
6f945693be7eea24b1a8e5ce252a96df98d55a5c is the first bad commit commit 6f945693be7eea24b1a8e5ce252a96df98d55a5c Author: Slava Grigorev slava.grigorev@amd.com Date: Wed Dec 10 14:52:43 2014 -0500
radeon/audio: applied audio_dpms() and audio_mode_set() calls
Reviewed-by: Christian König christian.koenig@amd.com Signed-off-by: Slava Grigorev slava.grigorev@amd.com Signed-off-by: Alex Deucher alexander.deucher@amd.com
:040000 040000 33622643fd03f2afac723aa1356fe9c638a8fb3c fac1a0f988f61f513a75af0b0e55cccc4246d500 M drivers
git bisect start # bad: [308de41ba3bde80d50833718a2e37e49be868f5a] drm/radeon: use NULL rather then 0 in audio detect git bisect bad 308de41ba3bde80d50833718a2e37e49be868f5a # good: [49ead33b9f0e0ba0b528951a05986486196848ef] drm/radeon: comment out some currently unused 7xx dpm code git bisect good 49ead33b9f0e0ba0b528951a05986486196848ef # good: [64424d6e45aeee311a4231def7e125bcc2de0855] radeon/audio: consolidate update_acr() functions (v2) git bisect good 64424d6e45aeee311a4231def7e125bcc2de0855 # good: [3be2e7d0e705621c1bb41eeabb63b122d50ecff3] radeon/audio: moved mute programming to a separate function git bisect good 3be2e7d0e705621c1bb41eeabb63b122d50ecff3 # bad: [6f945693be7eea24b1a8e5ce252a96df98d55a5c] radeon/audio: applied audio_dpms() and audio_mode_set() calls git bisect bad 6f945693be7eea24b1a8e5ce252a96df98d55a5c # good: [6e72376dcc663e4b8a00cdd08f61a8623f572ef1] radeon/audio: consolidate audio_mode_set() functions git bisect good 6e72376dcc663e4b8a00cdd08f61a8623f572ef1 # first bad commit: [6f945693be7eea24b1a8e5ce252a96df98d55a5c] radeon/audio: applied audio_dpms() and audio_mode_set() calls
https://bugs.freedesktop.org/show_bug.cgi?id=89327
--- Comment #13 from Dieter Nützel Dieter@nuetzel-hh.de --- But I can't revert commit 6f94569 on top of HEAD.
During some restarts I got this in dmesg: [ 4.159787] [drm:btc_dpm_set_power_state [radeon]] *ERROR* rv770_restrict_performance_levels_before_switch failed
And my reported r600 - NI/Turks: flickering with 'geom-outlining-150' seems to be related!?
It was first gone under drm-next-4.1-wip but arise with going bak to drm-next-3.20-wip (3.19-rc5). I had to power down my system to get it back after 'git bisect reset' and got the above messages during some power cycles.
https://bugs.freedesktop.org/show_bug.cgi?id=89327
--- Comment #14 from John john.ettedgui@gmail.com --- (In reply to Dieter Nützel from comment #12)
Bisected
6f945693be7eea24b1a8e5ce252a96df98d55a5c is the first bad commit commit 6f945693be7eea24b1a8e5ce252a96df98d55a5c Author: Slava Grigorev slava.grigorev@amd.com Date: Wed Dec 10 14:52:43 2014 -0500
radeon/audio: applied audio_dpms() and audio_mode_set() calls Reviewed-by: Christian König <christian.koenig@amd.com> Signed-off-by: Slava Grigorev <slava.grigorev@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
:040000 040000 33622643fd03f2afac723aa1356fe9c638a8fb3c fac1a0f988f61f513a75af0b0e55cccc4246d500 M drivers
git bisect start # bad: [308de41ba3bde80d50833718a2e37e49be868f5a] drm/radeon: use NULL rather then 0 in audio detect git bisect bad 308de41ba3bde80d50833718a2e37e49be868f5a # good: [49ead33b9f0e0ba0b528951a05986486196848ef] drm/radeon: comment out some currently unused 7xx dpm code git bisect good 49ead33b9f0e0ba0b528951a05986486196848ef # good: [64424d6e45aeee311a4231def7e125bcc2de0855] radeon/audio: consolidate update_acr() functions (v2) git bisect good 64424d6e45aeee311a4231def7e125bcc2de0855 # good: [3be2e7d0e705621c1bb41eeabb63b122d50ecff3] radeon/audio: moved mute programming to a separate function git bisect good 3be2e7d0e705621c1bb41eeabb63b122d50ecff3 # bad: [6f945693be7eea24b1a8e5ce252a96df98d55a5c] radeon/audio: applied audio_dpms() and audio_mode_set() calls git bisect bad 6f945693be7eea24b1a8e5ce252a96df98d55a5c # good: [6e72376dcc663e4b8a00cdd08f61a8623f572ef1] radeon/audio: consolidate audio_mode_set() functions git bisect good 6e72376dcc663e4b8a00cdd08f61a8623f572ef1 # first bad commit: [6f945693be7eea24b1a8e5ce252a96df98d55a5c] radeon/audio: applied audio_dpms() and audio_mode_set() calls
Based on the commit's name I'd say it looks like a good match. Thank you for doing the bisecting instead of me :)
https://bugs.freedesktop.org/show_bug.cgi?id=89327
--- Comment #15 from Alex Deucher alexdeucher@gmail.com --- Created attachment 113872 --> https://bugs.freedesktop.org/attachment.cgi?id=113872&action=edit patch 1/5
Please try the attached patch set.
https://bugs.freedesktop.org/show_bug.cgi?id=89327
--- Comment #16 from Alex Deucher alexdeucher@gmail.com --- Created attachment 113873 --> https://bugs.freedesktop.org/attachment.cgi?id=113873&action=edit patch 2/5
https://bugs.freedesktop.org/show_bug.cgi?id=89327
--- Comment #17 from Alex Deucher alexdeucher@gmail.com --- Created attachment 113874 --> https://bugs.freedesktop.org/attachment.cgi?id=113874&action=edit patch 3/5
https://bugs.freedesktop.org/show_bug.cgi?id=89327
--- Comment #18 from Alex Deucher alexdeucher@gmail.com --- Created attachment 113875 --> https://bugs.freedesktop.org/attachment.cgi?id=113875&action=edit patch 4/5
https://bugs.freedesktop.org/show_bug.cgi?id=89327
--- Comment #19 from Alex Deucher alexdeucher@gmail.com --- Created attachment 113876 --> https://bugs.freedesktop.org/attachment.cgi?id=113876&action=edit patch 5/5
https://bugs.freedesktop.org/show_bug.cgi?id=89327
--- Comment #20 from Dieter Nützel Dieter@nuetzel-hh.de --- Thank you Alex,
it is under works. But could you offer a git tree? Can't find them in drm-next-4.1-wip. I couldn't apply patches to my old former drm-next-3.19 and now moved (during system change) to drm-next-4.1-wip tree any longer?! - Any hints?
Maybe I have to work with a new checked out one. Or could it be, that I only have forgotten to add me to the git 'system'? Have to investigate.
-Dieter
https://bugs.freedesktop.org/show_bug.cgi?id=89327
--- Comment #21 from Alex Deucher alexdeucher@gmail.com --- These plus some additional fixes: http://cgit.freedesktop.org/~agd5f/linux/log/?h=audio-fixes
https://bugs.freedesktop.org/show_bug.cgi?id=89327
--- Comment #22 from Dieter Nützel Dieter@nuetzel-hh.de --- Patches 1-5 are Tested-by: Dieter Nützel Dieter@nuetzel-hh.de on drm-next-4.1-wip
Got all applied fine with 'git am ...' I think that I couldn't apply 'extern' patches (e.g. from Dave) on the tree.
Thanks a lot Alex!
Cheers, Dieter
https://bugs.freedesktop.org/show_bug.cgi?id=89327
John john.ettedgui@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #23 from John john.ettedgui@gmail.com --- I have patched rc2 and so far after more than a day I have not needed to re-enable the audio, so I'd guess the patches do work fine.
Thanks for the quick fix!
https://bugs.freedesktop.org/show_bug.cgi?id=89327
--- Comment #24 from John john.ettedgui@gmail.com --- It seems rc3 includes these already, so that's all good.
https://bugs.freedesktop.org/show_bug.cgi?id=89327
John john.ettedgui@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
dri-devel@lists.freedesktop.org