On Tue, Nov 16, 2021 at 02:49:16PM +0300, Dan Carpenter wrote:

The intel_engine_create_virtual() function does not return NULL. It returns error pointers.

Fixes: e5e32171a2cf ("drm/i915/guc: Connect UAPI to GuC multi-lrc interface") Signed-off-by: Dan Carpenter dan.carpenter@oracle.com

Reviewed-by: Rodrigo Vivi rodrigo.vivi@intel.com

---

drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c index 38b47e73e35d..c48557dfa04c 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c @@ -3080,8 +3080,8 @@ guc_create_parallel(struct intel_engine_cs **engines,

ce = intel_engine_create_virtual(siblings, num_siblings,
				 FORCE_VIRTUAL);

• if (!ce) {
  

• 	err = ERR_PTR(-ENOMEM);
  

• if (IS_ERR(ce)) {
  

• 	err = ERR_CAST(ce);
  goto unwind;
  

  }

-- 2.20.1